Ian Lance Taylor
6358cac7d8
We should not silently permit a named type to match an unnamed
...
type. This is OK in a conversion but not in an assignment.
R=rsc
http://go/go-review/1016024
2009-11-02 11:58:47 -08:00
Rob Pike
a82465103f
use the new routine regexp.MustCompile to clean up some code that uses global regexps.
...
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
2009-11-02 11:37:52 -08:00
Russ Cox
9c13215859
rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit.
...
R=r
http://go/go-review/1016027
2009-11-02 11:37:21 -08:00
Rob Pike
cd82d490fc
eliminate goroutine from testing/regexp too.
...
R=rsc
CC=go-dev
http://go/go-review/1018021
2009-11-02 11:24:47 -08:00
Adam Langley
ad67a86626
Split constant time functions into crypto/subtle.
...
R=rsc
CC=go-dev
http://go/go-review/1018020
2009-11-02 11:12:07 -08:00
Russ Cox
d00248980b
do not emit USED for global x when compiling "_ = x;"
...
R=ken@golang.org
CC=r
http://go/go-review/1018019
2009-11-02 10:50:18 -08:00
Ian Lance Taylor
102357f028
Recognize gccgo error message.
...
runtime.go:19:10: error: reference to undefined identifier ‘runtime.printbool’
R=rsc
http://go/go-review/1018018
2009-11-02 10:12:40 -08:00
Rob Pike
acc54b6c70
take goroutines out of regexp so they can be created
...
during initialization.
R=rsc
CC=go-dev
http://go/go-review/1016023
2009-11-02 10:08:22 -08:00
Robert Griesemer
e6f85af2bb
cleaning up bug132
...
R=rsc
http://go/go-review/1017012
2009-11-02 09:42:53 -08:00
Robert Griesemer
49d295d592
- initial steps towards showing directory tree instead of
...
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree
R=rsc
http://go/go-review/1018016
2009-11-02 09:25:39 -08:00
Robert Griesemer
b67352110f
- collect line comments for methods in interfaces
...
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)
R=rsc, r
http://go/go-review/1016019
2009-11-02 09:18:02 -08:00
Russ Cox
9dd2e1e30f
nil pointer checks in 8g.
...
fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.
R=ken@golang.org
CC=iant
http://go/go-review/1016022
2009-11-01 21:04:16 -08:00
Rob Pike
4d310f2434
reverse the arguments to io.Copy so the destination is on the
...
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/1016011
2009-11-01 20:59:49 -08:00
Rob Pike
4e5296d4ba
fixups for memory model document
...
R=rsc
CC=go-dev
http://go/go-review/1016018
2009-11-01 20:58:33 -08:00
Rob Pike
6ac19ecefa
correct a few things in Go for C++ Programmers
...
R=iant, rsc
CC=go-dev
http://go/go-review/1016015
2009-11-01 20:57:13 -08:00
Rob Pike
c2b6418c26
fixups to "effective go"
...
R=rsc
CC=go-dev
http://go/go-review/1016020
2009-11-01 20:54:11 -08:00
Rob Pike
a411cea124
a few tweaks to the language design faq
...
R=rsc
CC=go-dev
http://go/go-review/1017007
2009-11-01 20:51:42 -08:00
Rob Pike
0c2a479a39
significant cleanup of the main FAQ
...
R=rsc
CC=go-dev
http://go/go-review/1017008
2009-11-01 20:50:42 -08:00
Rob Pike
5b72f9cd0b
save some text from the old FAQ; will get reworked in time
...
R=rsc
http://go/go-review/1018008
2009-11-01 20:48:21 -08:00
Rob Pike
83f0b718ed
fixups in the tutorial
...
also add a section about compiling programs because some found it surprising not to have one
R=rsc
CC=go-dev
http://go/go-review/1018011
2009-11-01 20:47:03 -08:00
Russ Cox
dde666dab5
code review: avoid subject changes, fix http_proxy submit bug
...
R=r
http://go/go-review/1016021
2009-11-01 18:46:07 -08:00
Ian Lance Taylor
f4e3947ffe
Permit the CC environment variable to include arguments
...
(I should have tested the last change a bit more before
submitting).
R=rsc
http://go/go-review/1017011
2009-11-01 16:29:33 -08:00
Ian Lance Taylor
fab7ae15ee
Use the environment variable CC as the bootstrap compiler used
...
to build 6g, 6l, etc.
R=rsc
CC=go-dev
http://go/go-review/1018015
2009-11-01 16:13:37 -08:00
Robert Griesemer
b96ad80949
enable all (but one) test cases in test.sh that
...
were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)
R=rsc
http://go/go-review/1018014
2009-11-01 15:27:10 -08:00
Ian Lance Taylor
d8efcdcd52
These files were moved to encoding/base64. The directory was
...
already removed from the Makefile.
R=rsc
http://go/go-review/1017006
2009-11-01 15:04:46 -08:00
Russ Cox
35ace1d1f5
split ipsock.go, sock.go, and unixsock.go out of net.go
...
prior to cleanup. no changes, only moving.
remove dependencies on strconv and strings
R=r
http://go/go-review/1017010
2009-11-01 11:15:34 -08:00
Russ Cox
fd1add2768
syscall cleanup.
...
* rename PORT.sh -> mkall.sh (hopefully more obvious),
change behavior: run commands by default.
* pull more constants out of #defines automatically,
instead of editing large lists by hand.
* add Recvfrom, Sendto
add os.O_EXCL.
R=r
http://go/go-review/1017009
2009-11-01 11:13:27 -08:00
Robert Griesemer
5223218307
don't update sync time if no files have changed
...
(and thus avoid re-indexing after every sync attempt)
R=rsc
http://go/go-review/1016010
2009-11-01 10:33:16 -08:00
Russ Cox
a64b69da9e
os cleanup.
...
dir_* and stat_* are just os specific,
not os+arch-specific.
R=r
http://go/go-review/1018010
2009-11-01 09:37:13 -08:00
Russ Cox
7732d80ceb
misc cleanup
...
R=r
http://go/go-review/1016017
2009-11-01 09:25:55 -08:00
Russ Cox
45495249e1
code review fixes
...
* clean up error handling: show Exception info
* white space fixes
* clean up output when creating CL
* simplify hg change command; add hg file
* fix stale cookie bug (thanks iant)
* in LoadAllCL, load each CL in a different thread,
to parallelize the slow web fetches
* throw away support for Mercurial before version 1.3
* add @CL-number file pattern for commands like diff
* make hg sync show files being sync'ed
R=r
http://go/go-review/1016016
2009-11-01 05:49:35 -08:00
Russ Cox
b72153310d
allow unpacking of json map into Go map,
...
now that reflection supports it.
R=r
http://go/go-review/1015008
2009-11-01 05:49:07 -08:00
Russ Cox
bf991bb7df
Make.pkg: add DEPS= support
...
allow Makefiles using Make.pkg to specify a
list of directories that should be installed
before trying to build the package.
this is a stopgap for small package trees
maintained outside the standard tree.
R=r
http://go/go-review/1016012
2009-11-01 05:43:26 -08:00
Russ Cox
eef3fbb83e
more file patterns to ignore
...
R=r
http://go/go-review/1016014
2009-11-01 05:20:30 -08:00
Rob Pike
bb3e3090c6
concurrency
...
R=go-dev, iant, rsc
http://go/go-review/1018004
2009-10-31 18:29:06 -07:00
Rob Pike
63e668d2ad
return "<nil>" when calling String() on a nil bytes.Buffer.
...
R=rsc
CC=go-dev
http://go/go-review/1016005
2009-10-31 13:28:22 -07:00
Rob Pike
aa0c811317
add PDF for go talk on Oct 30 2009
...
R=rsc
CC=go-dev
http://go/go-review/1018007
2009-10-30 18:04:32 -07:00
Ian Lance Taylor
b534eb462b
Don't use fallthrough in a type switch.
...
R=rsc
http://go/go-review/1018005
2009-10-30 16:10:42 -07:00
Robert Griesemer
fb12ad063e
fix build
...
R=agl
CC=rsc
http://go/go-review/1016008
2009-10-30 13:19:04 -07:00
Robert Griesemer
1e984cb913
improved comment formatting:
...
- print comments line by line, strip common prefix but do not
modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment
R=rsc
http://go/go-review/1017002
2009-10-30 13:17:14 -07:00
Russ Cox
09f4261841
split godoc/godoc.go into godoc/godoc.go
...
and godoc/main.go.
R=gri
CC=r
http://go/go-review/1017005
2009-10-30 10:58:53 -07:00
Rob Pike
2ea8ecda8f
repair corrupted sieve.gif
...
R=rsc
CC=go-dev
http://go/go-review/1016007
2009-10-30 10:34:01 -07:00
Kai Backman
1d0b65d33f
added missing sgen reverse character copy code.
...
R=rsc
http://go/go-review/1018006
2009-10-30 09:38:30 -07:00
Kai Backman
770b872752
clone and futex
...
go/test: passes 99% (343/347)
R=rsc
http://go/go-review/1016004
2009-10-29 21:21:14 -07:00
Adam Langley
09d68334cc
Forgot to change quickcheck to quick in the Makefile.
...
TBR=rsc
R=rsc
http://go/go-review/1017004
2009-10-29 18:34:44 -07:00
Adam Langley
9e96f25fa2
Add RSA PKCS#1 v1.5 support.
...
R=go-dev
APPROVED=rsc
DELTA=407 (400 added, 0 deleted, 7 changed)
OCL=36007
CL=36146
2009-10-29 17:38:25 -07:00
Adam Langley
878d0e1efd
Add a quickcheck package which is a little like the Haskell one of the same
...
name.
R=rsc
APPROVED=rsc
DELTA=566 (566 added, 0 deleted, 0 changed)
OCL=35974
CL=36111
2009-10-28 15:16:20 -07:00
Stephen Ma
74aa9dd55a
Hack to make cgo's generated go code compile when there are no
...
unsafe.Pointer references inside the C declarations.
R=go-dev
APPROVED=rsc
DELTA=1 (1 added, 0 deleted, 0 changed)
OCL=36063
CL=36063
2009-10-26 21:21:53 -07:00
Ian Lance Taylor
f305d04943
Bug: 6g accepts fallthrough in type switch.
...
R=r
CC=go-dev
http://go/go-review/1016006
2009-10-29 15:41:02 -07:00
Rob Pike
449086eec9
Change Stat to Lstat in Readdir so we don't recur when someone symlinks "."
...
R=rsc
CC=go-dev
http://go/go-review/1018003
2009-10-29 10:53:37 -07:00