David Symonds
85f2d18a72
bytes: document Compare/Equal semantics for nil arguments, and add tests.
...
R=golang-dev, bradfitz, r, r
CC=golang-dev
https://golang.org/cl/5676090
2012-02-18 17:39:40 +11:00
Rob Pike
701fb580bd
html/template: replace obsolete reference to template.Set
...
Fixes #3053 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5656094
2012-02-18 16:02:51 +11:00
Nigel Tao
130b29b637
image: add Decode example.
...
R=r, bradfitz, r, adg
CC=golang-dev
https://golang.org/cl/5675076
2012-02-18 15:09:01 +11:00
Rob Pike
420f713b7a
encoding/gob: cache engine for user type, not base type
...
When we build the encode engine for a recursive type, we
mustn't disregard the indirections or we can try to reuse an
engine at the wrong indirection level.
Fixes #3026 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5675087
2012-02-18 14:38:37 +11:00
Rob Pike
793f6f3cc3
encoding/gob: fix mutually recursive slices of structs
...
Fix by setting the element type if we discover it's zero while building.
We could have fixed this better with foresight by doing the id setting in a
different sequence, but doing that now would break binary compatibility.
Fixes #2995 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5675083
2012-02-18 12:43:08 +11:00
Andrew Gerrand
3e804f98d7
pkg: a slew of examples
...
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/5676071
2012-02-18 11:48:33 +11:00
Robert Griesemer
3063ff5168
crypto/dsa: add missing period in package comment
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5673087
2012-02-17 14:48:44 -08:00
Rob Pike
7d1c5328ed
math/rand: Intn etc. should panic if their argument is <= 0.
...
I am making a unilateral decision here. I could also settle for returning 0,
as long it's documented, but I argue that it's equivalent to an index
out of bounds.
Fixes #2892 .
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5676079
2012-02-18 08:53:03 +11:00
Anthony Martin
566e0fe785
os: fix existential typo
...
R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/5675081
2012-02-18 07:44:38 +11:00
Robert Griesemer
b6e2d6b778
go/doc: move Example code from go/ast to go/doc.
...
Fixes #3048 .
R=rsc
CC=golang-dev
https://golang.org/cl/5672081
2012-02-17 12:00:12 -08:00
Gustavo Niemeyer
ce020ffacd
runtime: remove use of ?:
...
Fixes #3061 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5656089
2012-02-17 17:13:16 -02:00
Robert Griesemer
f7ce57b1c8
go/parser: example for ParseFile use
...
R=r
CC=golang-dev
https://golang.org/cl/5675074
2012-02-17 09:31:42 -08:00
Robert Griesemer
ac6357b44d
go/scanner: replace comment with example
...
R=r
CC=golang-dev
https://golang.org/cl/5676074
2012-02-17 09:26:36 -08:00
Evan Shaw
fc444ebac1
8a, 8l: add EMMS instruction
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5673081
2012-02-17 11:21:46 -05:00
Dmitriy Vyukov
76eb911a3c
sync: say that Cond.Wait can not return spuriously
...
R=golang-dev, r, rsc, remyoudompheng, r
CC=golang-dev
https://golang.org/cl/5674086
2012-02-17 13:20:11 +04:00
Dmitriy Vyukov
649f771b7b
net/rpc: fix spurious panic in test
...
The panic happens if -benchtime flag is specified:
go test -bench=EndToEndAsyncHTTP -benchtime=120
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5677075
2012-02-17 11:42:02 +04:00
Alex Brainman
b8f465644c
runtime: silence warnings
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5656084
2012-02-17 17:05:41 +11:00
Russ Cox
b27bd42a9a
net/url: API
...
Convert cryptotype to general go1rename fix.
Add os.Exec -> syscall.Exec fix along with new
URL fixes.
Fixes #2946 .
R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/5672072
2012-02-16 23:46:28 -05:00
David Symonds
d8e715cab4
net/url: spell the package name correctly.
...
R=bradfitz
CC=golang-dev
https://golang.org/cl/5676076
2012-02-17 15:31:07 +11:00
David Symonds
3d8ebefbbe
runtime: Permit default behaviour of SIGTSTP, SIGTTIN, SIGTTOU.
...
Fixes #3037 .
R=rsc, minux.ma, r, rsc
CC=golang-dev
https://golang.org/cl/5674072
2012-02-17 14:36:40 +11:00
Rob Pike
efb28b2ac1
os: add a simple example to the package doc.
...
Shows error handling and slices for Read and Write.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5676075
2012-02-17 14:30:25 +11:00
Russ Cox
a4d124d75b
log/syslog: disable on Windows
...
We want to be able to implement good Windows support
after Go 1. Right now Windows tries to use Unix domain
sockets, and I'd rather just have it not be available.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5671076
2012-02-16 22:04:13 -05:00
Brad Fitzpatrick
008e64da39
net: package doc overview / examples
...
Fixes #2774
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5673076
2012-02-17 13:07:06 +11:00
Mikio Hara
03d4c7c7d7
net, os, syscall: delete os.EPLAN9
...
Also fixes plan9 cross-build.
R=rsc, r
CC=golang-dev
https://golang.org/cl/5675073
2012-02-17 10:59:30 +09:00
Rob Pike
a15f59ef1d
debug/dwarf: address TODO in doc comment for New
...
Fixes #2844 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5675072
2012-02-17 12:47:56 +11:00
Rob Pike
785ee50c55
net/textproto: delete spurious quote
...
Sigh.
R=golang-dev, gri, nigeltao
CC=golang-dev
https://golang.org/cl/5675071
2012-02-17 11:35:38 +11:00
Rob Pike
c49edc6137
net/textproto: add Conn to doc comment
...
This revolutionary transfiguration undergirding the code base
Fixes #2945 .
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5676072
2012-02-17 10:21:12 +11:00
Rob Pike
56069f0333
os: delete os.EINVAL and so on
...
The set of errors forwarded by the os package varied with system and
was therefore non-portable.
Three helpers added for portable error checking: IsExist, IsNotExist, and IsPermission.
One or two more may need to come, but let's keep the set very small to discourage
thinking about errors that way.
R=mikioh.mikioh, gustavo, r, rsc
CC=golang-dev
https://golang.org/cl/5672047
2012-02-17 10:04:29 +11:00
Rob Pike
c560a0742b
path/filepath: fix test on darwin
...
/tmp being itself a symlink causes problems for the test, so use / as the absolute path.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5675070
2012-02-17 09:56:14 +11:00
Robert Griesemer
f43d2b7fa8
go/parser: imaginary constants and ! may start an expression
...
Complete list of tokens that can start a top-level expression.
R=rsc
CC=golang-dev
https://golang.org/cl/5671074
2012-02-16 14:13:31 -08:00
David Symonds
4b171e5040
runtime: rename Cgocalls and Goroutines to NumCgoCall and NumGoroutine, respectively.
...
Update some other docs too.
Update #2955 .
R=rsc
CC=golang-dev
https://golang.org/cl/5676060
2012-02-17 08:49:41 +11:00
Russ Cox
014568bee1
syscall: fix bounds check in Error
...
Fixes #3042 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5675067
2012-02-16 15:23:50 -05:00
Rob Pike
e574480ed1
encoding/gob: catch internal error when it happens
...
It was being skipped due to an oversight.
Also adjust naming parameters for map type construction - makes debugging easier.
Prelude to issue 3026.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5674071
2012-02-17 07:07:53 +11:00
Rémy Oudompheng
3e7d804749
path, path/filepath: polish documentation.
...
Fixes #2950 .
Fixes #2951 .
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/5672044
2012-02-16 20:05:39 +01:00
David du Colombier
11f4a6c9df
os,syscall: fix plan 9 build
...
NewFile take uintptr
make syscall.ProcAttr.Files be []uintptr
R=rsc
CC=golang-dev
https://golang.org/cl/5656073
2012-02-16 14:04:51 -05:00
Sébastien Paolacci
5c598d3c9f
runtime: release unused memory to the OS.
...
Periodically browse MHeap's freelists for long unused spans and release them if any.
Current hardcoded settings:
- GC is forced if none occured over the last 2 minutes.
- spans are handed back after 5 minutes of uselessness.
SysUnused (for Unix) is a wrapper on madvise MADV_DONTNEED on Linux and MADV_FREE on BSDs.
R=rsc, dvyukov, remyoudompheng
CC=golang-dev
https://golang.org/cl/5451057
2012-02-16 13:30:04 -05:00
Nigel Tao
85d33918a0
cmd, pkg/go/*: fix "go vet" warnings for go/ast and go/printer
...
struct literals.
R=gri
CC=golang-dev
https://golang.org/cl/5653073
2012-02-16 22:43:41 +11:00
Rob Pike
fa8bc8a648
os: fix build
...
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5674070
2012-02-16 17:39:04 +11:00
Rob Pike
dfef0c2dcc
html/template: clone is implemented elsewhere, so delete this implementation
...
R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/5676064
2012-02-16 17:36:06 +11:00
Rob Pike
edf1c038e3
os: remove use of _test
...
Part of issue 2573.
R=dsymonds, golang-dev
CC=golang-dev
https://golang.org/cl/5674064
2012-02-16 17:05:43 +11:00
Rob Pike
7e8a369426
exp/inotify: remove use of _test
...
Fixes #2573 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5676063
2012-02-15 21:23:58 -08:00
Rob Pike
cc34f4b565
windows: fix build
...
R=golang-dev
TBR=dsymonds
CC=golang-dev
https://golang.org/cl/5673064
2012-02-16 16:07:26 +11:00
David Symonds
8342793e7b
net/url: Rename ParseWithReference to ParseWithFragment.
...
Updates #2946 .
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5671061
2012-02-16 15:56:03 +11:00
Rob Pike
34de45c435
exp/winfsnotify: remove reference to _test
...
Updates #2573 .
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5677063
2012-02-16 15:34:27 +11:00
David Symonds
2f8d94fe4b
net/url: regularise receiver names.
...
Update #2946 .
R=golang-dev, bradfitz, bradfitz
CC=golang-dev
https://golang.org/cl/5674065
2012-02-16 15:07:54 +11:00
David Symonds
7ec5499d36
debug/gosym: more carefully build the test binary.
...
TBR=r
CC=golang-dev
https://golang.org/cl/5676062
2012-02-16 15:06:12 +11:00
Gustavo Niemeyer
aed20a6951
encoding/xml: add MarshalIndent and move the example
...
An unindented XML example is hard to follow. MarshalIndent
allows moving the example over to a test file (and fixing it).
R=golang-dev, r, gustavo, r, rsc
CC=golang-dev
https://golang.org/cl/5674050
2012-02-16 02:01:46 -02:00
David Symonds
0fc441b053
debug/gosym: dump 6a/6l output to process stdout/stderr so we can see failures.
...
TBR=r
CC=golang-dev
https://golang.org/cl/5671060
2012-02-16 14:54:45 +11:00
David Symonds
3430599306
debug/gosym: Remove Makefile, rewrite test using go tool.
...
Update #2573 .
R=r
CC=golang-dev
https://golang.org/cl/5656071
2012-02-16 14:47:14 +11:00
Andrew Gerrand
8bb7f7791b
sort: add interface examples
...
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5677060
2012-02-16 13:16:07 +11:00