2 Commits

Author	SHA1	Message	Date
Michael Matloob	84cebe1034	go/packages: fix incorrect needtypes and needsrcs logic ... This logic is really fiddly and I'm not really 100% sure it's right, though I've thought about it for quite abit (and added comments to help me reason through it). Also always request CompiledGoFiles when NeedTypes is true because we might need to fall back to loading from source when type data is incorrect. Fixes golang/go#36441 Fixes golang/go#36547 Change-Id: I1cc27ca2e4401a9abc8502990b0da7d0480f6f84 Reviewed-on: https://go-review.googlesource.com/c/tools/+/214943 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-01-16 22:59:55 +00:00
Rohan Challa	428f1ab0ca	internal/lsp/mod: test go.mod is unchanged when tempModfile=true ... This change adds a test to ensure that your go.mod file remains unchanged when the tempModfile flag is activated. Specifically, it adds a test to ensure that a go directive does not get added to a user's go.mod file when there was not one included before. Updates golang/go#36247 Change-Id: If8db5508ace5b7222112408255ffa66e4d38797f Reviewed-on: https://go-review.googlesource.com/c/tools/+/214260 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2020-01-10 14:27:00 +00:00