1
0
mirror of https://github.com/golang/go synced 2024-11-05 14:56:10 -07:00
Commit Graph

118 Commits

Author SHA1 Message Date
Brad Fitzpatrick
7dca24ee7e codereview: explain how to get hgpatch in error message
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5623045
2012-02-02 11:53:28 -08:00
Andrew Gerrand
e10150f96d codereview: don't check default paths when codereview disabled
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5622043
2012-02-02 14:25:13 -05:00
Russ Cox
deeb1b36dd codereview: ignore test files during 'hg gofmt'
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5581047
2012-01-30 13:41:29 -05:00
Russ Cox
fd693388e6 codereview: fix initialization check
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5596046
2012-01-29 14:04:24 -05:00
Russ Cox
ba31d662fe codereview: die if initialized twice
If this happens, something is misconfigured.
If we don't test for this explicitly, MatchAt ends
up calling itself recursively forever.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5576066
2012-01-29 12:33:13 -05:00
Russ Cox
ceb59b069e codereview: more fixes
Python and Mercurial are a matched pair.

R=adg
CC=golang-dev
https://golang.org/cl/5570065
2012-01-25 14:46:10 -05:00
Russ Cox
79d2c57043 codereview: support for subrepositories
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5564054
2012-01-25 14:32:10 -05:00
Miki Tebeka
a3008e235e codereview: Initialize "found" in codereview.py.
Fixes #2569 (hg undo crashes when CL not found).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489052
2011-12-16 10:39:20 -05:00
Yasuhiro Matsumoto
e62b40344d codereview: fix path slash issue.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487057
2011-12-13 16:18:56 -05:00
David Crawshaw
28cead8b6c codereview: gofmt check for non-src/ files
Gives other projects the benefit of the gofmt presubmit.
Results in minor changes in the doc/ directory:
        find doc -name \*.go -exec gofmt -d {} \;

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5158042
2011-11-18 12:42:30 -08:00
Russ Cox
cf5a1c0909 codereview: put message back in post-commit mails
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5417049
2011-11-18 14:30:06 -05:00
Russ Cox
ab957154b6 codereview: undo last night's rollback
Update version check from 1.4 to 1.9.  Suggest 2.0.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5413046
2011-11-18 12:58:44 -05:00
Andrew Gerrand
5ca38eda49 undo CL 5395044 / d88e746d3785
Breaks with hg 1.6.4. Roll back until it's fixed.

««« original CL description
codereview: cleanup + basic tests

R=adg, bradfitz
CC=golang-dev
https://golang.org/cl/5395044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/5410047
2011-11-18 21:33:04 +11:00
Russ Cox
bbf952c3b4 codereview: cleanup + basic tests
R=adg, bradfitz
CC=golang-dev
https://golang.org/cl/5395044
2011-11-18 00:16:15 -05:00
Russ Cox
c0523e1db9 codereview: show LGTMs in hg p
Shows first line of any response that the codereview server
has identified as an LGTM.  Example output below.

5305046:
        big: update for fmt interface changes

        Nothing terribly interesting here.

        Reviewer: gri@golang.org
                gri: LGTM
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/big/int.go
                src/pkg/big/nat.go
                src/pkg/big/nat_test.go
                src/pkg/big/rat.go

5307044:
        exp/template/html: use rune

        Nothing terribly interesting here.

        Reviewer: mikesamuel@gmail.com, nigeltao@golang.org
                mikesamuel: I don't see a type def for rune.  Assuming that's a new intrinsic, LGTM.
        CC: golang-dev@googlegroups.com
        Files:
                src/pkg/exp/template/html/css.go
                src/pkg/exp/template/html/css_test.go
                src/pkg/exp/template/html/html.go
                src/pkg/exp/template/html/js.go

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5297045
2011-10-19 15:08:33 -04:00
Russ Cox
351e1d5745 codereview: fix for Mercurial 1.9.2
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5127052
2011-10-05 12:08:41 -04:00
Yasuhiro Matsumoto
319dba4750 codereview: fix hg change in Windows console
lib/codereview: Unable to use vim for 'hg change' from windows console
reload(sys) break workaround for windows.
see:
http://mercurial.selenic.com/bts/issue2888
http://mercurial.selenic.com/bts/issue1452
Also does not work with backslash paths.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5150054
2011-10-05 12:07:13 -04:00
Russ Cox
1fa87ada55 codereview: extra repo sanity check
Also work around Mercurial issue 3023.

If anyone has local changes in their repo (due to
patch queues or whatever) stop them from leaking
into the main repository.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5144043
2011-09-26 18:32:16 -04:00
Russ Cox
762729b50e codereview: save CL messages in $(hg root)/last-change
Fixes #2279.

R=bradfitz, r, r
CC=golang-dev
https://golang.org/cl/5096042
2011-09-20 14:56:15 -04:00
Russ Cox
e7af22a64e codereview: Mercurial 1.9 fix for hg diff @nnn
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4969063
2011-09-08 10:08:49 -04:00
Russ Cox
d118905c2c codereview: set status while committing CL
Not sure how to detect read-only but at least
this pins the blame on the hg server.

R=r, bradfitz
CC=golang-dev
https://golang.org/cl/4847053
2011-08-10 21:36:59 -04:00
Andrew Gerrand
87d71a3815 codereview: fix for Mercurial 1.9
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4686049
2011-07-11 22:58:40 -04:00
Andrew Gerrand
b4f0e8ffd3 undo CL 4675045 / 0e11e08951f7
Breaks Mercurial 1.8.3.

««« original CL description
codereview: fix for Mercurial 1.9

Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4685055
2011-07-12 09:57:39 +10:00
Andrew Gerrand
762ea79057 codereview: fix for Mercurial 1.9
Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
2011-07-12 09:36:46 +10:00
Russ Cox
3379414b21 codereview: restrict sync to default branch
'default' is the name of the main branch,
the one that isn't a release branch.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4636072
2011-06-29 00:45:29 -04:00
Russ Cox
f79bcb4b86 codereview: make --ignore_hgpatch_failure work again
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4627067
2011-06-27 13:45:17 -04:00
Robert Hencke
58ff8c1dfd codereview.py: note that hg change -d abandons a change list
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4644043
2011-06-20 14:50:00 -04:00
Russ Cox
404d49154b codereview: handle 'null as missing field' in rietveld json
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4543046
2011-05-13 11:17:06 -04:00
Russ Cox
71102ad25b codereview: fix clpatch
TBR=gri
CC=golang-dev
https://golang.org/cl/4534052
2011-05-12 23:11:52 -04:00
Russ Cox
9d2a697fb9 codereview: fetch metadata using JSON API, not XML scraping
Fixes hg clpatch.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/4524045
2011-05-11 23:26:52 -04:00
Russ Cox
35a37f1735 codereview: add release branch support
Note that if you are working on the upcoming release
branch you have to point your extension path to a
copy of lib/codereview/codereview.py that won't change
as the repository flips between release-branch and default branch.
This warning should only apply to this one branch and only to rsc,
but you never know.

R=adg
CC=golang-dev
https://golang.org/cl/4446076
2011-05-03 10:39:11 -04:00
Russ Cox
4efdeeec51 codereview: various fixes
Set mailed bit correctly for self-clpatch.
Use repo.rollback correctly.
Allow leading spaces in some C code.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4438064
2011-04-25 12:12:53 -04:00
Russ Cox
0c6df25df1 codereview: add 'hg undo' command
R=adg, r
CC=golang-dev
https://golang.org/cl/4423045
2011-04-17 14:15:51 -04:00
Russ Cox
740051ae75 codereview: automatically port old diffs forward
In the current codereview, if a patch was written against
a version of a file that had subsequently been edited,
hg clpatch would fail, even if the patch and the edits were
in different parts of the file.  In this situation the reviewer
typically wrote back saying "please hg sync and hg mail
to update the patch".

This change rewrites the patch automatically, using the
same transformation that hg sync + hg mail would.

If the interim changes (since the patch was created)
affect the same line ranges as the patch, clpatch will
still refuse to apply it.  But this CL should make
of the trivial conflicts we see just go away.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4377046
2011-04-08 13:00:40 -04:00
Russ Cox
88bbf4f1df codereview: fix clpatch
I love Python.  Write once, crash anywhere.

TBR=r
CC=golang-dev
https://golang.org/cl/4382043
2011-04-07 13:06:02 -04:00
Russ Cox
710028d3a4 codereview: drop Author: line on self-clpatch
Right now if a Go developer makes a patch on one machine
and then clpatches it onto another machine, changes
subsequently made to the description are kept only
locally, under the assumption that you are running
clpatch because someone else wrote the CL, so you
don't have permission to update the web.

This change makes clpatch discard the "this was a
clpatch" information from the metadata when you
clpatch your own CLs from one machine to another.

This should eliminate some confusion (for example
in CL 4314054) but will no doubt introduce other
confusion.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/4387041
2011-04-07 13:03:06 -04:00
Russ Cox
5b0ef4ac1f codereview: recognize code URL without trailing slash
R=adg
CC=golang-dev
https://golang.org/cl/4385042
2011-04-06 23:07:08 -04:00
Russ Cox
36c009d465 codereview: only retry on HTTP 500 error
R=r
CC=golang-dev
https://golang.org/cl/4353047
2011-04-04 15:47:32 -04:00
Andrew Gerrand
5dd0869bf5 codereview: permit CLs of the form weekly.DATE
gobuilder: recognize CLs of the form weekly.DATE

R=rsc, r
CC=golang-dev
https://golang.org/cl/4282052
2011-03-17 09:11:08 +11:00
Robert Hencke
1ddc27888b codereview.py: do not suggest hg change -d if current user is not CL author
R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4253064
2011-03-08 12:23:06 -05:00
Gustavo Niemeyer
73aacbda20 codereview: fix clpatch with empty diffs
Avoid passing the placeholder diff to hgpatch, so that
clpatch-ing an empty diff grabs the metadata and warns
about it being empty, rather than failing with a
hard-to-debug problem ("mkdir: no such file or dir",
no metadata, etc).

R=rsc
CC=golang-dev
https://golang.org/cl/4172060
2011-02-23 11:48:40 -05:00
Yasuhiro Matsumoto
3108f3f4a0 codereview: use cmd.communicate.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4145046
2011-02-08 22:30:06 -05:00
Yasuhiro Matsumoto
27191b558c codereview: fix hgpatch on windows
R=rsc
CC=golang-dev
https://golang.org/cl/3989059
2011-02-02 22:43:40 -05:00
Russ Cox
fdb46fb470 codereview: record repository, base revision
Include repository URL in initial mail.
Record repository and base revision in patch description.

R=r
CC=golang-dev
https://golang.org/cl/4126052
2011-02-02 16:39:31 -05:00
Russ Cox
dc9a02fa66 codereview: more ascii vs unicode nonsense
R=r
CC=golang-dev
https://golang.org/cl/4124047
2011-02-01 14:17:41 -05:00
Hector Chu
59a6395279 codereview: fix windows
Uploading go files on Windows aborts with gofmt: exceptions.ValueError:
close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr

R=rsc, mattn, Joe Poirier
CC=golang-dev
https://golang.org/cl/4025046
2011-01-24 14:16:24 -05:00
Russ Cox
17fc373af7 codereview: handle file patterns better
If a file pattern is given and matches files that look
like they need to be hg added or hg removed, offer to do so.

If a file pattern is given and matches files in another CL, warn.

If a file pattern doesn't match anything, point that out.

Vet first line of CL description.

Fixes #972.

R=adg, niemeyer
CC=bradfitzgo, golang-dev
https://golang.org/cl/4099042
2011-01-24 14:14:26 -05:00
Hector Chu
1e0efcd579 codereview: fix hg change on Windows
hg change fails on Windows with 'No valid patches found in output from hg diff'.

R=rsc
CC=golang-dev
https://golang.org/cl/4006043
2011-01-19 19:02:47 -05:00
Ryan Hitchman
30c85bf14c codereview: don't mail change lists with no files
R=rsc
CC=golang-dev
https://golang.org/cl/3561041
2011-01-19 14:46:06 -05:00
Eoghan Sherry
2f8ff0b81d codereview: keep quiet when not in use
This prevents status messages from filling the
screen when using a command like 'hg log | less'.

R=rsc
CC=golang-dev
https://golang.org/cl/3666042
2010-12-15 11:49:43 -05:00