1
0
mirror of https://github.com/golang/go synced 2024-11-05 17:26:11 -07:00
Commit Graph

30 Commits

Author SHA1 Message Date
Brad Fitzpatrick
e113e405de doc: auto-generated html change missing from 7ee7980ea06d
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515077
2011-05-13 08:12:34 -07:00
Brad Fitzpatrick
05a1b7ec41 http: remove finalURL from Client.Get; move to Response
This CL:

-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
   the final url to the blank identifier; warning otherwise

Caller who did:

res, finalURL, err := http.Get(...)

now need to do:

res, err := http.Get(...)
if err != nil {
   ...
}
finalURL := res.Request.URL.String()

R=rsc
CC=golang-dev
https://golang.org/cl/4535056
2011-05-13 07:31:24 -07:00
Johan Euphrosine
5f6e1cfca7 doc/codelab: correct typo.
s/Sprintf/Fprintf/

R=golang-dev, rsc
CC=adg, golang-dev
https://golang.org/cl/4519053
2011-05-12 11:21:10 -04:00
Russ Cox
6b3357129a build: add all-qemu.bash, handful of arm fixes
R=r
CC=golang-dev
https://golang.org/cl/4313051
2011-03-27 23:39:42 -04:00
Andrew Gerrand
4896b17584 doc: update codelab wiki to fix template.Execute argument order
Fixes #1595.

R=r
CC=golang-dev
https://golang.org/cl/4243067
2011-03-09 12:59:13 +11:00
Alex Brainman
2ae4f356cc doc/codelab/wiki: include into windows build
R=adg, rsc
CC=Joe Poirier, golang-dev
https://golang.org/cl/4257052
2011-03-07 15:48:39 +11:00
Rob Pike
fb9e37cd9b template: reverse order of arguments to Execute
In line with other functions such as Fprintf, put the
thing to be written first.

Apologies for the breakages this is sure to cause.

R=rsc, gri, adg, eds, r2, aam
CC=golang-dev
https://golang.org/cl/4169042
2011-02-09 14:23:01 -08:00
Robert Griesemer
2a81292ac3 srcextract: HTML-escape output if so desired
This functionality was removed with CL 4169041.

Minor simplifications.

R=r, adg
CC=golang-dev
https://golang.org/cl/4171042
2011-02-09 14:08:19 -08:00
Rob Pike
6d51fc6c1e codelab: update due to recent changes in go/printer
R=gri, adg
CC=golang-dev
https://golang.org/cl/4169041
2011-02-09 12:46:34 -08:00
Andrey Mirtchovski
b2b29814bf Codelab/wiki: fix typo
Missing closing bracket renders the next code snippet unreadable.

R=adg, gri
CC=golang-dev
https://golang.org/cl/4119060
2011-02-07 11:51:17 -08:00
Andrey Mirtchovski
61c93cac3e Codelab: correct function definitions for handlers before closures are introduced.
A couple of post-closure function definitions were introduced too early, making the resulting
code fail compilation.

Also, the TitleValidator regexp was missing.

R=adg
CC=golang-dev
https://golang.org/cl/4105054
2011-02-07 09:23:18 +01:00
Rob Pike
eea18d959e log: rename Exit* to Fatal*
This aligns the naming scheme with the testing package and
also lets govet work on more logging calls.

R=rsc
CC=golang-dev
https://golang.org/cl/4001048
2011-02-01 12:47:35 -08:00
Russ Cox
634cef25c3 doc/codelab/wiki: fixes
make test.sh runnable as a command.
announce only on 127.0.0.1.
rebuild final-test.bin when final-test.go changes.

R=adg, r
CC=golang-dev
https://golang.org/cl/4030044
2011-01-28 09:42:51 -05:00
Andrew Gerrand
5899cab037 doc/codelab/wiki: tests use available TCP port
R=bradfitz, dsymonds, r2, dangabrad, rsc
CC=golang-dev
https://golang.org/cl/4043043
2011-01-27 23:19:37 +10:00
Andrew Gerrand
9ec785af2f doc/codelab/wiki: replace curl with a Go program
R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4087043
2011-01-27 10:32:41 +10:00
Russ Cox
bba20fc1fa codelab/wiki: fix freebsd build
TBR=adg
CC=golang-dev
https://golang.org/cl/4092042
2011-01-26 13:02:09 -05:00
Russ Cox
770acbe7b8 codelab/wiki: fix build
TBR=adg
CC=golang-dev
https://golang.org/cl/4077045
2011-01-26 12:54:07 -05:00
Andrew Gerrand
549d7f49d5 doc/codelab/wiki: rename textarea name from Body to body
R=mattn
CC=golang-dev
https://golang.org/cl/4034046
2011-01-26 17:25:37 +10:00
Andrew Gerrand
add4e167e3 doc/codelab/wiki: update to work with template changes, add to run.bash
Fixes #1444.

R=rsc, r
CC=golang-dev
https://golang.org/cl/3979045
2011-01-26 14:56:52 +10:00
Stephen Ma
a2332a32b8 doc: update http handler usage for new signature
R=adg, r2
CC=golang-dev
https://golang.org/cl/2302041
2010-09-30 13:19:33 +10:00
Christian Himpel
5c603dbb75 build: remove unnecessary references to GOBIN and GOROOT
All scripts and makefiles assume that GOBIN is correctly set
in PATH.

R=rsc
CC=golang-dev
https://golang.org/cl/2043041
2010-08-30 15:40:56 -04:00
Andrew Gerrand
91a141675f doc: fix wiki codelab title and srcextract.go
R=r, rsc1
CC=golang-dev
https://golang.org/cl/1953048
2010-08-27 11:02:54 +10:00
Russ Cox
da392d9136 build: no required environment variables
R=adg, r, PeterGo
CC=golang-dev
https://golang.org/cl/1942044
2010-08-18 10:08:49 -04:00
Joe Poirier
2fa388e063 edit simple typos
R=golang-dev, adg
CC=golang-dev, rsc
https://golang.org/cl/1426042
2010-06-01 16:21:34 +02:00
Andrew Gerrand
fbf8d263f9 codelab/wiki: fix typo in demo URL
R=r
CC=golang-dev
https://golang.org/cl/1148041
2010-05-07 10:16:16 +10:00
Andrew Gerrand
a0514459aa codelab/wiki: switch edit/view, as they were backwards
Fixes #757.

R=rsc
CC=golang-dev
https://golang.org/cl/1064041
2010-05-03 12:09:44 +10:00
Andrey Mirtchovski
452dd3829e codelab/index.html: a few typos.
R=adg
CC=golang-dev
https://golang.org/cl/993042
2010-04-29 14:33:19 +10:00
Andrey Mirtchovski
ad26019ba6 codelab/index.html "os" needs to be imported because os.Error is used almost immediately
Also, calling fmt, ioutil and os "builtin" is probably confusing.

R=adg
CC=golang-dev
https://golang.org/cl/965045
2010-04-29 14:06:27 +10:00
Andrew Gerrand
0f945b972d wiki codelab: typo fix
noticed this as I was submitting the previous CL :(

R=r
CC=golang-dev
https://golang.org/cl/989045
2010-04-28 12:39:17 +10:00
Andrew Gerrand
78d9a6074d Wiki codelab, complete with tests.
R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/887045
2010-04-28 12:36:39 +10:00