1
0
mirror of https://github.com/golang/go synced 2024-11-18 11:04:42 -07:00
Commit Graph

365 Commits

Author SHA1 Message Date
David Symonds
23f4e43564 lib/time: update to IANA release 2015e.
Fixes #11810.

Change-Id: I8453e53a72e242a69ea34eb393999e7291d4358f
Reviewed-on: https://go-review.googlesource.com/12502
Run-TryBot: David Symonds <dsymonds@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
2015-07-22 02:56:31 +00:00
David Symonds
439b329363 remove the obsolete lib/codereview.
Change-Id: Idd2e74053ce4a2be3d757aef1bb83313973de6f0
Reviewed-on: https://go-review.googlesource.com/1175
Reviewed-by: Andrew Gerrand <adg@golang.org>
2014-12-08 07:51:54 +00:00
Russ Cox
444839014b [dev.garbage] all: merge dev.cc (81884b89bd88) into dev.garbage
TBR=rlh
CC=golang-codereviews
https://golang.org/cl/181100044
2014-12-05 11:40:41 -05:00
Russ Cox
829b286f2c [dev.cc] all: merge default (8d42099cdc23) into dev.cc
TBR=austin
CC=golang-codereviews
https://golang.org/cl/178700044
2014-12-05 11:18:10 -05:00
Rob Pike
b2950a2931 lib/time: update to ICANN time zone database 2014j
Fixes #9189.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews
https://golang.org/cl/178660043
2014-12-03 20:07:48 -08:00
Russ Cox
3e804631d9 [dev.cc] all: merge dev.power64 (7667e41f3ced) into dev.cc
This is to reduce the delta between dev.cc and dev.garbage to just garbage collector changes.

These are the files that had merge conflicts and have been edited by hand:
        malloc.go
        mem_linux.go
        mgc.go
        os1_linux.go
        proc1.go
        panic1.go
        runtime1.go

LGTM=austin
R=austin
CC=golang-codereviews
https://golang.org/cl/174180043
2014-11-14 12:10:52 -05:00
Russ Cox
3dcc62e1da [dev.garbage] all: merge default (f38460037b72) into dev.garbage
This is the revision that dev.cc is branched from.

LGTM=austin
R=austin
CC=golang-codereviews
https://golang.org/cl/169590043
2014-11-14 11:37:54 -05:00
Andrew Gerrand
7f0be1f781 all: use golang.org/x/... import paths
LGTM=rsc, r
R=r, rsc
CC=golang-codereview, golang-codereviews
https://golang.org/cl/168050043
2014-11-10 09:15:57 +11:00
Adam Langley
03c008bcb2 lib/codereview: fix with more recent hg revisions.
I've Mercurial version 3.2 and hg submit fails with:

  File "/home/agl/devel/go/lib/codereview/codereview.py", line 3567, in get_hg_status
    ret = hg_commands.status(fui, self.repo, *[], **{'rev': [rev], 'copies': True})
  File "/usr/lib/python2.7/site-packages/mercurial/commands.py", line 5714, in status
    fm = ui.formatter('status', opts)
  File "/home/agl/devel/go/lib/codereview/codereview.py", line 3464, in formatter
    return plainformatter(self, topic, opts)
  File "/usr/lib/python2.7/site-packages/mercurial/formatter.py", line 57, in __init__
    if ui.debugflag:
  AttributeError: 'FakeMercurialUI' object has no attribute 'debugflag'

This change dumbly adds a boolean debugflag and that seems to work.

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://golang.org/cl/167410043
2014-11-08 17:12:23 -08:00
Russ Cox
d6f4e5020b [dev.garbage] all: merge dev.power64 (5ad5e85cfb99) into dev.garbage
The goal here is to get the big-endian fixes so that
in some upcoming code movement for write barriers
I don't make them unmergeable.

LGTM=rlh
R=rlh
CC=golang-codereviews
https://golang.org/cl/166890043
2014-10-29 12:25:24 -04:00
Austin Clements
3208250185 [dev.power64] build: merge default into dev.power64
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/160200044
2014-10-22 11:21:16 -04:00
Russ Cox
af282f0011 [dev.garbage] lib/codereview: allow hg submit to commit new branch if CL description says so
This means I won't have to edit the plugin when I create
the next dev branch.

LGTM=r, adg
R=r, adg
CC=golang-codereviews
https://golang.org/cl/148950045
2014-09-25 13:11:57 -04:00
Russ Cox
2185dbcd85 codereview: do not hit upload_complete on first patch
Causes server 500 error, so don't do it.

TBR=minux
CC=golang-codereviews
https://golang.org/cl/125770043
2014-08-06 16:12:24 -04:00
Russ Cox
4cc8be60e9 codereview: fix submit of merge + include branch prefix in submitted message
hg insists that we not list explicit files for a merge.

for benefit of other tools reading logs, include branch prefix
at start of every commit message.

LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/124780044
2014-08-06 16:10:08 -04:00
Russ Cox
c1fcdb0e00 codereview: handle upload of merge
LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/118690043
2014-08-06 15:25:17 -04:00
Russ Cox
6ff5c317eb codereview: preserve branch prefix in subject during hg mail
LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/124800043
2014-08-06 15:15:45 -04:00
Russ Cox
69c2e2b9e0 codereview: enable work and code reviews in development branches
This is an experiment. See mail on golang-dev
(subject: "an experiment: development branches").

LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/117660043
2014-08-06 14:52:12 -04:00
Shenghou Ma
09a9ef6115 codereview: abort 'hg commit' before entering commit message.
Hook pre-commit runs before 'hg commit' command whereas hook precommit runs
after the user has entered commit message.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/106320043
2014-07-18 21:04:56 -04:00
Shenghou Ma
9a8a20bdb8 codereview: revive the tests.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/105500043
2014-07-18 21:00:35 -04:00
Brad Fitzpatrick
4eb4dc0cfc codereview: update name of the a+c tool
LGTM=rsc
R=rsc, minux
CC=golang-codereviews
https://golang.org/cl/105480043
2014-07-01 09:25:34 -07:00
Russ Cox
32d8b9ffb8 lib/codereview: fix doc/go1.*.txt exception
LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/108950046
2014-06-12 20:12:50 -04:00
Russ Cox
ff9af906f6 codereview: no LGTM needed for doc/go1.x.txt
Rob asked for this change to make maintaining go1.4.txt easier.
If you are not sure of a change, it is still okay to send for review.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/109880044
2014-06-12 16:35:12 -04:00
Russ Cox
32a5c898e3 codereview: do not add defaultcc for private CLs
LGTM=r
R=r, 0xjnml, bradfitz, iant
CC=golang-codereviews
https://golang.org/cl/103070046
2014-06-05 16:40:09 -04:00
Rob Pike
aa92b3e5d4 lib/timezone: update to IANA 2014d
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/102040045
2014-06-01 00:15:23 +00:00
Rob Pike
b04146e492 lib/time/zoneinfo.zip: update to IANA release 2014c
LGTM=minux.ma
R=golang-codereviews, minux.ma
CC=golang-codereviews
https://golang.org/cl/93420046
2014-05-16 22:06:37 +00:00
Robert Hencke
bdff7f91d8 lib/time: update time zone info to v.2014b
Fixes #7412.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/92850043
2014-04-29 21:41:54 -04:00
Patrick Mézard
dd449a1cfa codereview: remove unused upload_options.revision
LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://golang.org/cl/60640052
2014-02-24 10:11:37 -05:00
Anthony Martin
881e23d36f codereview: fix for Mercurial 2.9
The branchtags method was removed but we should've
been using branchmap all along.

http://selenic.com/hg/rev/4274eda143cb

LGTM=franciscossouza, r
R=golang-codereviews, franciscossouza, r
CC=golang-codereviews
https://golang.org/cl/57500045
2014-02-14 15:56:58 -08:00
Russ Cox
673917f878 codereview: warn about 'hg upload' not uploading
This seems to be what causes the 'chunk mismatch' errors.
I don't know why the server tells us there's nothing to upload,
but at the least we can warn that it did, so that the user
will try again.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/62840043
2014-02-13 05:06:46 +00:00
Russ Cox
d0252b17ce lib/codereview: allow addca CLs without LGTM
LGTM=gri
R=golang-codereviews, gri
CC=golang-codereviews
https://golang.org/cl/61610043
2014-02-10 14:40:19 -05:00
Russ Cox
672ab62981 lib/codereview: add LGTM= line to commit messages
The R= is populated by Rietveld, so it's basically
anyone who replied to the CL. The LGTM= is meant
to record who actually signed off on the CL.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/55390043
2014-01-23 15:10:38 -05:00
Russ Cox
1cf3f501ad codereview: switch defaultcc to golang-codereviews
See this thread for background:
https://groups.google.com/forum/#!topic/golang-dev/xG7vPi21r8g

R=golang-codereviews, gobot, golang-dev, dsymonds
CC=golang-codereviews, golang-dev
https://golang.org/cl/44450043
2013-12-20 10:53:50 -05:00
Jeff Sickel
6d86d064e5 plan9: correct create permissions with union directory
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/15360045
2013-10-23 10:28:28 -04:00
Francesc Campoy
b6c0c4228d lib/codereview: return an empty list when CONTRIBUTORS is not found instead of None.
R=adg, campoy, r
CC=golang-dev
https://golang.org/cl/14419059
2013-10-10 17:16:17 -07:00
Dominik Honnef
50d4dae80b codereview: fix hg sync closing of CLs for subrepositories
The regexp for closing CLs that were sent by you but committed by
someone else only matched messages for the main repository,
because of the added &repo=... for subrepositories.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14512045
2013-10-10 16:30:47 -07:00
Rob Pike
158c56ef8a lib/time: update time zone files to version 2013g
This dataset is current as of Sep 30, 2013.

Fixes #6524

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14570044
2013-10-08 16:16:24 -07:00
Jeff Sickel
e67b0e6885 codereview: move dotfiles out of user home director to something sane.
See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp

R=golang-dev, r, rsc
CC=aram.h, golang-dev
https://golang.org/cl/14374045
2013-10-07 11:41:27 -04:00
Anthony Martin
8f764fb689 codereview: update use of promptchoice for Mercurial 2.7
Fixes #6186.

R=golang-dev, bradfitz, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/13112043
2013-09-06 15:48:21 -04:00
Andrew Gerrand
4fa83edf06 cmd/godoc: delete from core repository
The godoc command now lives at code.google.com/p/go.tools/cmd/godoc.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12206044
2013-08-01 11:21:17 +10:00
Andrew Gerrand
d920d8d849 doc: don't block page load on JavaScript fetch
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/12050045
2013-07-30 14:22:14 +10:00
Andrew Gerrand
493538adbf cmd/godoc: set up playground for examples that are already visible
This fixes an issue where linking directly to an example makes it not
runnable and visible only in a tiny window. To see the bug in action,
visit this link: http://golang.org/pkg/strings/#example_Map

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/10679050
2013-07-02 08:44:25 +10:00
Russ Cox
75aab13741 codereview: force hg update after hg pull -u during hg sync
If you hg update your client to an earlier CL, then
hg sync will move you back to tip if it pulls anything in,
but it will leave you where you are if it doesn't pull anything in.
That's confusing: make hg sync always update to tip.

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
https://golang.org/cl/10456044
2013-06-25 17:23:21 -04:00
Andrew Gerrand
573c2fd4fe godoc: always use local jQuery script
Fixes #5075.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/10084044
2013-06-07 10:46:56 +10:00
Anthony Martin
2bcc30891c codereview: don't warn about secret commits
Normally the codereview plugin disables adding new commits
when not using the submit command. Unfortunately this makes
it impossible to use the Mercurial Queues extension at the
same time.

A feature called "Phases" was introduced in Mercurial 2.1
that allows marking commits as being secret; this means
they will never be pushed to the upstream repository.

We can take advantage of this feature to allow the use of
Mercurial Queues if the mq.secret option has been set in
hgrc(5) and a recent version of Mercurial is used.

R=golang-dev, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/7398055
2013-06-04 15:02:28 -07:00
Francesc Campoy
4b2eb3f9f8 codereview.py: improve error message when user is not a committer
R=adg, bradfitz, r
CC=golang-dev
https://golang.org/cl/9626045
2013-05-22 16:27:39 -07:00
Rob Pike
05e8db985a lib/time: update to IANA 2013c
This should do it for the release.
There was a new data set pushed out a couple of days ago.

Fixes #4553.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8621044
2013-04-22 16:28:42 -07:00
Rob Pike
26e0ddcf2a lib/time: update time zone to IANA version 2013b
Update #4553.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8293043
2013-04-02 16:49:45 -07:00
Robert Griesemer
79682199ce cmd/godoc: don't linkify index entries
Fixes #5186.

R=bradfitz
CC=golang-dev
https://golang.org/cl/8267044
2013-04-02 12:05:14 -07:00
Robert Griesemer
f1b7c140ff cmd/godoc: provide a link from notes to source location
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8122043
2013-03-28 14:40:59 -07:00
Robert Griesemer
04341b246e cmd/godoc: cleanups
- removed gratuitous empty lines that creeped into command line output
- changed comment color to a dark green so that links don't visually melt into them
- removed some TODOs
- updated doc.go

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/8108044
2013-03-28 13:05:30 -07:00