2 Commits

Author	SHA1	Message	Date
Rohan Challa	46bd65c853	internal/lsp/cache: add concurrency error check for go cmds ... This change attempts to fix a concurrency error that would cause textDocument/CodeLens, textDocument/Formatting, textDocument/DocumentLink, and textDocument/Hover from failing on go.mod files. The issue was that the go command would return a potential concurrency error since the ModHandle and the ModTidyHandle are both using the temporary go.mod file. Updates golang/go#37824 Change-Id: I6cd63c1f75817c7308e033aec473966536a2a3bd Reviewed-on: https://go-review.googlesource.com/c/tools/+/224917 Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2020-04-08 03:22:09 +00:00
Rebecca Stambler	f8bfb4ee30	internal/gocommand: fix environment on Windows ... Seems like os.Environ() is necessary after all. My bad for not testing my earlier change on Windows. I'm not able to reproduce the behavior in my test, so it's not really testing the crash correctly. Fixes golang/go#38062 Change-Id: Ied45bbf572023a9dcd5d020db49bf3e95c824602 Reviewed-on: https://go-review.googlesource.com/c/tools/+/226370 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>	2020-03-30 18:31:14 +00:00