Sameer Ajmani
a96a983606
C: correct entry: jmeurin, not jme.
...
R=golang-dev, rsc
CC=golang-dev, jme, jmeurin
https://golang.org/cl/6192057
2012-05-07 11:40:43 -04:00
Sameer Ajmani
80790ab740
C: Jeremy Ellington (Google CLA)
...
R=golang-dev, rsc
CC=golang-dev, jme
https://golang.org/cl/6197058
2012-05-07 10:47:58 -04:00
Marcel van Lohuizen
56a76c88f8
exp/locale/collate: from the regression test we derive that the spec
...
dictates a CJK rune is only part of a certain specified range if it
is explicitly defined in the Unicode Codepoint Database.
Fixed the code and some of the tests accordingly.
R=r
CC=golang-dev
https://golang.org/cl/6160044
2012-05-07 11:51:40 +02:00
Marcel van Lohuizen
18aded7ab9
exp/norm: It is important that the unicode versions of the various packages align.
...
Replace hard-coded version strings with unicode.Version.
R=r, r
CC=golang-dev
https://golang.org/cl/6163045
2012-05-07 11:41:40 +02:00
Ian Lance Taylor
6c8447d429
test: add bug438, a valid test case that gccgo used to fail to compile
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6196047
2012-05-04 13:14:09 -07:00
Shenghou Ma
4d724f4c5b
sync/atomic: fix 64-bit atomic cas for Linux/ARM
...
This is a follow-up to CL 5978051.
Use kernel cas64 helper if we can, fallback to LDREXD/STREXD if
we are on ARMv6 or higher, and to lock-emulated cas64 if on ARMv5.
A future CL will fix {Add,Load,Store}{Int,Uint}64 and issue 3331.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6034048
2012-05-05 02:02:36 +08:00
Shenghou Ma
a642ca4930
runtime: get per-process random number from auxv for hash table
...
Decode AT_RANDOM, AT_HWCAP, and AT_PLATFORM.
This CL only make use of AT_RANDOM, but future CLs will make use of the others.
R=dave, rsc
CC=golang-dev
https://golang.org/cl/5978051
2012-05-05 01:59:14 +08:00
Shenghou Ma
dac4c3eee9
cmd/cgo, cmd/cc, cmd/ld: detect dynamic linker automatically
...
Some newer Linux distributions (Ubuntu ARM at least) use a new multiarch
directory organization, where dynamic linker is no longer in the hardcoded
path in our linker.
For example, Ubuntu 12.04 ARM hardfloat places its dynamic linker at
/lib/arm-linux-gnueabihf/ld-linux.so.3
Ref: http://lackof.org/taggart/hacking/multiarch/
Also, to support Debian GNU/kFreeBSD as a FreeBSD variant, we need this capability, so it's part of issue 3533.
This CL add a new pragma (#pragma dynlinker "path") to cc.
R=iant, rsc
CC=golang-dev
https://golang.org/cl/6086043
2012-05-05 01:54:16 +08:00
Shenghou Ma
a29304bfb8
runtime: fix c compiler warning
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6185047
2012-05-05 01:39:09 +08:00
Shenghou Ma
018bcc3535
runtime, misc/cgo/test: fix build for Linux/ARM
...
1. In CL 5989057, I made a mistake in the last minute change.
"MOVW.W R4, -4(SP)" should really be "MOVW.W R4, -4(R13)",
as 5l will rewrite offset for SP.
2. misc/cgo/test/issue1560.go tests for parallel sleep of 1s,
but on ARM, the deadline is frequently missed, so change sleep
time to 2s on ARM.
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6202043
2012-05-05 01:35:13 +08:00
Rémy Oudompheng
018c60bd8f
math/big: fix superpolynomial complexity in Karatsuba algorithm.
...
benchmark old ns/op new ns/op delta
BenchmarkExp3Power0x10 732 734 +0.27%
BenchmarkExp3Power0x40 834 836 +0.24%
BenchmarkExp3Power0x100 1600 1579 -1.31%
BenchmarkExp3Power0x400 3478 3417 -1.75%
BenchmarkExp3Power0x1000 19388 19229 -0.82%
BenchmarkExp3Power0x4000 160274 156881 -2.12%
BenchmarkExp3Power0x10000 1552050 1372058 -11.60%
BenchmarkExp3Power0x40000 27328710 15216920 -44.32%
BenchmarkExp3Power0x100000 612349000 131407100 -78.54%
BenchmarkExp3Power0x400000 44073524000 1122195000 -97.45%
R=golang-dev, mtj, gri, rsc
CC=golang-dev, remy
https://golang.org/cl/6176043
2012-05-04 19:05:26 +02:00
Akshat Kumar
ccdca2cd6b
pkg/runtime: Plan 9 signal handling in Go
...
This adds proper note handling for Plan 9,
and fixes the issue of properly killing go procs.
Without this change, the first go proc that dies
(using runtime·exit()) would kill all the running
go procs. Proper signal handling is needed.
R=golang-dev, ality, rminnich, rsc
CC=golang-dev, john, mirtchovski
https://golang.org/cl/5617048
2012-05-04 03:48:34 -07:00
Anthony Martin
fe5005f721
syscall: remove the Signal type on Plan 9
...
Instead use a new type, "Note", whose underlying
type is just a string. This change allows us to
remove the exported os.Plan9Note type.
R=bradfitz, seed, rsc
CC=golang-dev
https://golang.org/cl/6015046
2012-05-04 03:44:41 -07:00
Shenghou Ma
2bed8a7e95
go/build: cgo is supported on Linux/ARM
...
Last Part of CL 5601044 (cgo: Linux/ARM support)
Fixes #1880 .
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5988057
2012-05-04 18:34:04 +08:00
Shenghou Ma
e7a0a7595a
cmd/go: cgo for Linux/ARM
...
Part 4 of CL 5601044 (cgo: Linux/ARM support)
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5989058
2012-05-04 18:29:40 +08:00
Shenghou Ma
9602dd5e87
cmd/cgo: support Linux/ARM
...
Part 3 of CL 5601044 (cgo: Linux/ARM support)
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991066
2012-05-04 18:26:16 +08:00
Shenghou Ma
5cffce611a
runtime: cgo support for Linux/ARM
...
Part 2 of CL 5601044 (cgo: Linux/ARM support)
R=dave, rsc
CC=golang-dev
https://golang.org/cl/5989057
2012-05-04 18:20:09 +08:00
Shenghou Ma
452a9e452b
cmd/5l, cmd/ld: dynamic linking library support
...
Part 1 of CL 5601044 (cgo: Linux/ARM support)
Limitation: doesn't support thumb library yet.
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991065
2012-05-04 18:14:26 +08:00
David Symonds
c44a22cc49
misc/dashboard/codereview: remove transitional code.
...
All current CLs have subject lines, so we don't need to check any more.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044
2012-05-04 16:40:24 +10:00
Michael Chaten
3fab2a97e4
encoding/json: Fix panic when trying to unmarshal the empty string into an integer
...
Fixes #3450 .
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6035050
2012-05-03 17:35:44 -04:00
Francisco Souza
61060acdc1
syscall: add Termios support on darwin
...
Update #3316 .
R=dave, kevlar, devon.odell, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6063053
2012-05-03 17:33:19 -04:00
Ian Lance Taylor
890be5ced0
test: add bug437, a test that used to fail with gccgo at link time
...
Updates #3391 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6177045
2012-05-03 14:25:11 -07:00
Adam Langley
c8e1946f33
crypto/x509: fix panic when using unavailable hash function.
...
crypto.Hash.New() changed to panicking when the hash function isn't
linked in, but crypto/x509 still expects it to return nil.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6175047
2012-05-03 16:39:57 -04:00
Shenghou Ma
278d4a583d
cmd/5c, cmd/5a, cmd/5l: ARM support for PREFETCH built-in
...
R=rsc
CC=golang-dev
https://golang.org/cl/6174049
2012-05-04 03:24:14 +08:00
Ian Lance Taylor
df64448932
test: add bug436, valid code that crashed gccgo
...
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6158046
2012-05-03 10:33:10 -07:00
Shenghou Ma
52ec4aa24a
cmd/dist: remove stray src/pkg/runtime/z* when cleaning
...
R=golang-dev, bradfitz, dave, rsc, lstoakes, rsc
CC=golang-dev
https://golang.org/cl/6180044
2012-05-04 00:58:48 +08:00
Andrew Gerrand
7a77645aa8
misc/dashboard/codereview: add copyright notices to Go files
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6177043
2012-05-03 09:22:45 +10:00
Russ Cox
d42495aa80
cmd/cc: add PREFETCH built-in (like SET, USED)
...
This makes it possible to inline the prefetch of upcoming
memory addresses during garbage collection, instead of
needing to flush registers, make a function call, and
reload registers. On garbage collection-heavy workloads,
this results in a 5% speedup.
Fixes #3493 .
R=dvyukov, ken, r, dave
CC=golang-dev
https://golang.org/cl/5990066
2012-05-02 16:22:56 -04:00
Marcel van Lohuizen
10838165d8
exp/locale/collate: fixed two bugs uncovered by regression tests.
...
The first bug was that tertiary ignorables had the same colElem as
implicit colElems, yielding unexpected results. The current encoding
ensures that a non-implicit colElem is never 0. This fix uncovered
another bug of the trie that indexed incorrectly into the null block.
This was caused by an unfinished optimization that would avoid the
need to max out the most-significant bits of continuation bytes.
This bug was also present in the trie used in exp/norm and has been
fixed there as well. The appearence of the bug was rare, as the lower
blocks happened to be nearly nil.
R=r
CC=golang-dev
https://golang.org/cl/6127070
2012-05-02 17:01:41 +02:00
Luuk van Dijk
81d9621534
cmd/gc: test for issue 3552
...
R=rsc
CC=golang-dev
https://golang.org/cl/6128051
2012-05-02 16:56:26 +02:00
Dmitriy Vyukov
c1c851bbe8
runtime: avoid unnecessary zeroization of huge memory blocks
...
+move zeroization out of the heap mutex
R=golang-dev, iant, rsc
CC=golang-dev
https://golang.org/cl/6094050
2012-05-02 18:01:11 +04:00
Alex Brainman
0d55d9832f
os/signal: run windows TestCtrlBreak during build
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6136054
2012-05-02 17:05:52 +10:00
Anthony Martin
90626864dc
os: conform to Go 1 API on Plan 9
...
R=golang-dev, r, bradfitz, r
CC=golang-dev
https://golang.org/cl/6117062
2012-05-01 22:44:38 -07:00
Anthony Martin
3859032980
build: dist-based build for Plan 9
...
R=rsc, iant, iant, seed
CC=golang-dev
https://golang.org/cl/5608059
2012-05-01 22:32:46 -07:00
Rob Pike
ce30769ce3
misc/dashboard/codereview: LGTM favicon
...
R=dsymonds
CC=golang-dev
https://golang.org/cl/6158043
2012-05-02 13:48:49 +10:00
Dave Cheney
d472d3faf1
bytes: add assembly version of Equal for ARM
...
BenchmarkEqual32 662 159 -75.98%
BenchmarkEqual4K 76545 13719 -82.08%
BenchmarkEqual4M 90136700 23588870 -73.83%
BenchmarkEqual64M 2147483647 1419616000 -42.63%
BenchmarkEqual32 48.32 201.15 4.16x
BenchmarkEqual4K 53.51 298.56 5.58x
BenchmarkEqual4M 46.53 177.81 3.82x
BenchmarkEqual64M 27.12 47.27 1.74x
R=golang-dev, qyzhai, minux.ma, rsc, iant, nigeltao
CC=golang-dev
https://golang.org/cl/6118049
2012-05-02 12:10:24 +10:00
Ian Lance Taylor
82e30c681c
cgo: rename C names for Go types to avoid conflicting with package
...
Fixes #3371 .
R=rsc, bsiegert, r, mtj, iant
CC=golang-dev
https://golang.org/cl/6131060
2012-05-01 09:04:13 -07:00
David Symonds
cc9a5c3be7
misc/dashboard/codereview: preserve CL ordering.
...
R=r
CC=golang-dev
https://golang.org/cl/6136056
2012-05-01 16:15:32 +10:00
Nigel Tao
86a91539b8
compress/flate: add a copy overrun test.
...
R=rsc, r
CC=golang-dev
https://golang.org/cl/6143043
2012-05-01 14:28:33 +10:00
David Symonds
83aa040c45
misc/dashboard/codereview: de-dup LGTMs.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
2012-05-01 11:41:32 +10:00
David Symonds
c3c8e35af2
encoding/json: don't match field name if a JSON struct tag is present.
...
Fixes #3566 .
R=rsc
CC=golang-dev
https://golang.org/cl/6139048
2012-05-01 11:37:44 +10:00
David Symonds
dae2992c98
misc/dashboard/codereview: send mail immediately, and fill in time.Time fields.
...
If we delay the mail sending, we can't send as the current user.
If we don't fill in the time.Time fields, datastore.Put will fail
because the zero time.Time value is out of its range.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6136053
2012-05-01 11:33:25 +10:00
Nigel Tao
4de15a5cda
compress/flate: optimize history-copy decoding.
...
The forwardCopy function could be re-written in asm, and the copyHuff
method could probably be rolled into huffmanBlock and copyHist, but
I'm leaving those changes for future CLs.
compress/flate benchmarks:
benchmark old ns/op new ns/op delta
BenchmarkDecoderBestSpeed1K 385327 435140 +12.93%
BenchmarkDecoderBestSpeed10K 1245190 1062112 -14.70%
BenchmarkDecoderBestSpeed100K 8512365 5833680 -31.47%
BenchmarkDecoderDefaultCompression1K 382225 421301 +10.22%
BenchmarkDecoderDefaultCompression10K 867950 613890 -29.27%
BenchmarkDecoderDefaultCompression100K 5658240 2466726 -56.40%
BenchmarkDecoderBestCompression1K 383760 421634 +9.87%
BenchmarkDecoderBestCompression10K 867743 614671 -29.16%
BenchmarkDecoderBestCompression100K 5660160 2464996 -56.45%
image/png benchmarks:
benchmark old ns/op new ns/op delta
BenchmarkDecodeGray 2540834 2389624 -5.95%
BenchmarkDecodeNRGBAGradient 10052700 9534565 -5.15%
BenchmarkDecodeNRGBAOpaque 8704710 8163430 -6.22%
BenchmarkDecodePaletted 1458779 1325017 -9.17%
BenchmarkDecodeRGB 7183606 6794668 -5.41%
Wall time for Denis Cheremisov's PNG-decoding program given in
https://groups.google.com/group/golang-nuts/browse_thread/thread/22aa8a05040fdd49
Before: 3.07s
After: 2.32s
Delta: -24%
Before profile:
Total: 304 samples
159 52.3% 52.3% 251 82.6% compress/flate.(*decompressor).huffmanBlock
58 19.1% 71.4% 76 25.0% compress/flate.(*decompressor).huffSym
32 10.5% 81.9% 32 10.5% hash/adler32.update
16 5.3% 87.2% 22 7.2% bufio.(*Reader).ReadByte
16 5.3% 92.4% 37 12.2% compress/flate.(*decompressor).moreBits
7 2.3% 94.7% 7 2.3% hash/crc32.update
7 2.3% 97.0% 7 2.3% runtime.memmove
5 1.6% 98.7% 5 1.6% scanblock
2 0.7% 99.3% 9 3.0% runtime.copy
1 0.3% 99.7% 1 0.3% compress/flate.(*huffmanDecoder).init
After profile:
Total: 230 samples
59 25.7% 25.7% 70 30.4% compress/flate.(*decompressor).huffSym
45 19.6% 45.2% 45 19.6% hash/adler32.update
35 15.2% 60.4% 35 15.2% compress/flate.forwardCopy
20 8.7% 69.1% 151 65.7% compress/flate.(*decompressor).huffmanBlock
16 7.0% 76.1% 24 10.4% compress/flate.(*decompressor).moreBits
15 6.5% 82.6% 15 6.5% runtime.memmove
11 4.8% 87.4% 50 21.7% compress/flate.(*decompressor).copyHist
7 3.0% 90.4% 7 3.0% hash/crc32.update
6 2.6% 93.0% 9 3.9% bufio.(*Reader).ReadByte
4 1.7% 94.8% 4 1.7% runtime.slicearray
R=rsc, rogpeppe, dave
CC=golang-dev, krasin
https://golang.org/cl/6127064
2012-05-01 10:51:34 +10:00
Robert Hencke
84ce0f7687
cmd/go: do not ignore DepsErrors in 'go run'
...
Fixes #3490 .
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6040046
2012-04-30 17:00:24 -04:00
Shenghou Ma
44fd1d1a6a
runtime: give proper messages when user defined DYLD_INSERT_LIBRARIES on Darwin
...
also gives clear error when bsdthread_register fails on Darwin
Fixes #2992 .
R=rsc, krautz
CC=golang-dev
https://golang.org/cl/5966067
2012-04-30 15:55:07 -04:00
David Symonds
1bdb788b2e
misc/dashboard/codereview: record Message-ID of code review thread mails.
...
This will allow us to properly thread "R=..." mails at a later time.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
2012-04-30 22:47:51 +10:00
David Symonds
5d331964e7
misc/dashboard/codereview: add handy logout URL.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
2012-04-30 22:47:06 +10:00
David Symonds
4335ec9eeb
misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in.
...
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
2012-04-30 22:03:56 +10:00
Brad Fitzpatrick
ed90fbc747
encoding/base64: don't ignore underlying souce read error in decode
...
Fixes #3577
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6137054
2012-04-30 17:14:41 +10:00
Brad Fitzpatrick
fe2ce5285e
syscall: add a test for passing an fd over a unix socket
...
Re-submitting previously reverted change 160ec5506cb7.
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6129052
2012-04-30 15:31:14 +10:00