1
0
mirror of https://github.com/golang/go synced 2024-10-01 03:08:33 -06:00
Commit Graph

3 Commits

Author SHA1 Message Date
Matt T. Proud
7f3a9aa4e4 benchmark/parse: fix cosmetic defect in error str.
The "Benchmark" header parser's error string lacked a closing double
quotation mark.

Change-Id: I2361cc86866296503f2733aa84b3fd52cdf33c09
Reviewed-on: https://go-review.googlesource.com/3683
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2015-02-02 17:07:43 +00:00
Dominik Honnef
9f20d8c198 benchmark/parser, cmd/benchcmp: improve names of exported identifiers
Most of the names have been brought in line with the names used in
testing/BenchmarkResult. For example, NsOp becomes NsPerOp.

Additionally, "Bench" becomes "Benchmark" and "BenchSet" becomes "Set".

Change-Id: I7dfca68a804e285a87ab9692b5bb99ccb676da7f
Reviewed-on: https://go-review.googlesource.com/2610
Reviewed-by: Rob Pike <r@golang.org>
2015-01-15 01:28:17 +00:00
Dominik Honnef
0ff6678340 benchmark/parse, cmd/benchcmp: new package for parsing benchmarks
Move the parser for benchmark output from cmd/benchcmp into its own
package, benchmark/parse.

The majority of the change is just moving code around. Instead of
implementing the '-best' flag in ParseBenchSet, it is now implemented in
its own function 'selectBest' in cmd/benchcmp.

Bench.Ord (the ordinal position of a Bench within a BenchSet) has been
exported.

Change-Id: Id27032a220f9ff2596117b58b86243998695a804
Reviewed-on: https://go-review.googlesource.com/2102
Reviewed-by: Rob Pike <r@golang.org>
2015-01-06 01:34:08 +00:00