3 Commits

Author	SHA1	Message	Date
Rohan Challa	7124308813	internal/lsp/tests: add severity parameter to @diag markers ... This change will add another parameter to the diagnostic markers (@diag). Change-Id: I69f4672e7d5417099c11d1a46d9bc45a4d1e5ecc Reviewed-on: https://go-review.googlesource.com/c/tools/+/217719 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-02-04 19:24:00 +00:00
Rebecca Stambler	747b8b11d4	internal/lsp: refactor error handling code in type-checking ... This change adds a source.Error type which is used to collect the error information that comes out of the loading, parsing, and type checking stages. We also add specific sources per-error, rather than having them all be labeled as "LSP". This change will enable follow-ups that do a better job of extracting error ranges. Change-Id: I3fbb5e42d66aa2c5bb1b2f41d1eadfc45f3a749b Reviewed-on: https://go-review.googlesource.com/c/tools/+/202298 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-21 18:57:46 +00:00
Rebecca Stambler	cae9aa5434	internal/lsp: show "do not edit" message when user opens generated file ... This is probably a better approach than showing an extra diagnostic, since a user cannot dismiss a diagnostic. Fixes golang/go#33397 Change-Id: I92b9a00f51a463673993793abfd4cfb99ce69a91 Reviewed-on: https://go-review.googlesource.com/c/tools/+/188766 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-08-07 16:44:42 +00:00