3 Commits

Author	SHA1	Message	Date
Alan Donovan	ced954c167	go.tools/go/types: split Info.Objects map into Defs and Uses. ... An identifier X in anonymous struct field struct{X} is both a definition of a field (*Var) and reference to a type (*TypeName). Now that we have split the map, we can capture both of these aspects. Interestingly, every client but one was going to extra effort to iterate over just the uses or just the defs; this simplifies them. Also, fix two bug related to tagless switches: - An entry was being recorded in the Object map for a piece of synthetic syntax. - The "true" identifier was being looked up in the current scope, which allowed perverse users to locally redefine it. Now we use the bool (not untyped boolean) constant true, per the consequent clarification of the spec (issue 7404). + tests. Fixes golang/go#7276 LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/68270044	2014-02-27 13:21:59 -05:00
Robert Griesemer	ebfa4efbc4	go.tools/go/types: cleanup: more consistent exported predicate names ... Renamed predicates: IsIdentical -> Identical IsAssignableTo -> AssignableTo Signature.IsVariadic -> Signature.Variadic Object.IsExported -> Object.Exported LGTM=adonovan R=adonovan CC=golang-codereviews https://golang.org/cl/53370043	2014-01-28 10:57:56 -08:00
Rob Pike	331c428e76	go.tools/cmd/vet: add check for shadowed variables ... Experimental feature. It's too noisy yet to be enabled by default, so it must be enabled explicitly by go tool vet -shadow *.go or go tool vet -shadow directory (The go command does not know about the -shadow flag.) Fixes golang/go#5634. R=golang-dev, gri CC=golang-dev https://golang.org/cl/10409047	2013-06-21 11:27:53 -07:00