3 Commits

Author	SHA1	Message	Date
Alan Donovan	ced954c167	go.tools/go/types: split Info.Objects map into Defs and Uses. ... An identifier X in anonymous struct field struct{X} is both a definition of a field (*Var) and reference to a type (*TypeName). Now that we have split the map, we can capture both of these aspects. Interestingly, every client but one was going to extra effort to iterate over just the uses or just the defs; this simplifies them. Also, fix two bug related to tagless switches: - An entry was being recorded in the Object map for a piece of synthetic syntax. - The "true" identifier was being looked up in the current scope, which allowed perverse users to locally redefine it. Now we use the bool (not untyped boolean) constant true, per the consequent clarification of the spec (issue 7404). + tests. Fixes golang/go#7276 LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/68270044	2014-02-27 13:21:59 -05:00
Alan Donovan	64ec206bfd	go.tools/go/types: combine Info.{Types,Values} maps. ... This results in significant improvement to type-checking time: it reduces by 4% the entire running time of ssa/stdlib_test (GOMAXPROCS=8, n=7). LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/57770043	2014-01-28 16:46:24 -05:00
Andrew Gerrand	74ecc2c09b	go.tools/cmd/vet: detect useless function comparisons ... Also fix bug in types.go discovered by this check. Fixes golang/go#5347. R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/13102043	2013-08-20 16:11:01 +10:00