3 Commits

Author	SHA1	Message	Date
Ian Cottrell	e2f00d1e07	internal/lsp: make pipe mode the default for command line tests ... now there are no more race conditions in the jsonrpc or server code make connected pipe (rather than direct API) the default in the tests to make sure we stay clean. Change-Id: Id1ffede795a660dbf7b265b9e0419c60cf83c6e8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170181 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-04-01 16:30:59 +00:00
Ian Cottrell	4471d52094	internal/lsp: allow command line tests to connect through a pipe ... With this change (finally, after a lot of detours) if you run the lsp tests with `-race -pipe` then you can reliably reproduce the race in golang/go#30091 Change-Id: Ibd9fda5e07409a15d1bc8d14cb46fde41155aa6e Reviewed-on: https://go-review.googlesource.com/c/tools/+/169999 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-29 15:12:06 +00:00
Ian Cottrell	ab21143f23	internal/lsp: adding command line access to diagnostics ... Change-Id: I011e337ec2bce93199cf762c09e002442ca1bd0d Reviewed-on: https://go-review.googlesource.com/c/tools/+/167697 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-28 21:17:00 +00:00