3 Commits

Author	SHA1	Message	Date
Rebecca Stambler	bffc5affc6	internal/lsp: support definitions and hover for builtins ... This change adds support for definitions and hover for builtin types and functions. It also includes some small (non-logic) changes to the import spec definition function. Additionally, there are some resulting changes in diagnostics to ignore the builtin file but also use it for definitions (Ian, you were right with your comment on my earlier review...). Fixes golang/go#31696 Change-Id: I52d43d010a5ca8359b539c33e40782877eb730d0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/177517 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-05-17 00:35:10 +00:00
Rebecca Stambler	2e9de471eb	internal/lsp: handle definitions for variables with error types ... Fixes golang/go#31465 Change-Id: I2f79fe2167bab79b497125995efc938f2b63d274 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172117 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-04-15 20:59:51 +00:00
Ian Cottrell	6dfe7efaa9	internal/lsp: add definition tests from godef ... This makes our internal version of go to definition be tested with the same test data that godef now uses Change-Id: I04e488b6b9b2d891181f202ea1125b823a079c50 Reviewed-on: https://go-review.googlesource.com/c/150045 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2018-11-19 18:17:22 +00:00