3 Commits

Author	SHA1	Message	Date
pjw	57a9e4404b	internal/lsp: fix new bug duplicating comments after includes ... Fixes https://github.com/golang/go/issues/39147 Change-Id: I6f78efccbabf21dbb00e56a49d88e26ff4733fba Reviewed-on: https://go-review.googlesource.com/c/tools/+/234584 Reviewed-by: Heschi Kreinick <heschi@google.com>	2020-05-19 20:57:26 +00:00
pjw	8979540587	internal/lsp: simplify and correct fixing imports for CodeAction ... The code was introducting syntax errors for some edge cases (example in regtest/import_test.go), and I found it hard to follow. The new code passes all the tests. There are new regtests to guarantee no CodeActions are returned for some cases that vim testing noticed. Change-Id: Ia09da667f74673c11bfe185e4f76a76c66940105 Reviewed-on: https://go-review.googlesource.com/c/tools/+/233117 Run-TryBot: Peter Weinberger <pjw@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>	2020-05-18 22:54:12 +00:00
Heschi Kreinick	95ece921ff	internal/lsp/source: trim file very carefully ... Apparently the AST will sometimes give us offsets past the end of the file. Don't crash when it does. Fixes golang/go#36610. Change-Id: I3cfbf8645bfcea94a5d87bca5bef4236d657b2c0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215119 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-01-17 20:34:13 +00:00