3 Commits

Author	SHA1	Message	Date
Rebecca Stambler	0bb5a05de8	internal/lsp: use the AST to get correct ranges ... Fixes golang/go#29150 Change-Id: I0cb8be25f7f40f7f8becedf2e0002c58620c72da Reviewed-on: https://go-review.googlesource.com/c/tools/+/202542 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-22 16:21:03 +00:00
Rebecca Stambler	de666e9706	internal/lsp: add a test to make sure we handle bad imports ... There was a regression where gopls would not type-check any package with a bad import. This change fixes the regression and adds a test to make sure it doesn't happen again. Change-Id: I3acf0917d46e9444c20135559f057f0ecd20e15b Reviewed-on: https://go-review.googlesource.com/c/tools/+/201539 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-17 20:52:05 +00:00
Rebecca Stambler	c006dc79eb	internal/lsp: reorganize completion tests ... Our completion tests check for a lot of different behaviors. It may be easier to develop if we have separate tests for things like deep completion and completion snippets. Change-Id: I7f4b0c0e52670f2a6c00247199933fd1ffa0096f Reviewed-on: https://go-review.googlesource.com/c/tools/+/196021 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-09-24 17:09:08 +00:00