3 Commits

Author	SHA1	Message	Date
Ian Cottrell	7504fd2219	internal/lsp: fix broken lsp logs ... ID's are now by value not pointer, which caused it to not use the Format method, resulting in broken id strings The id maps need to be crossover (set and get go to different maps for a given direction of message) Change-Id: Ide2b63ec1b009ae3587ee10e8bce018732ea342c Reviewed-on: https://go-review.googlesource.com/c/tools/+/229244 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Peter Weinberger <pjw@google.com>	2020-04-21 17:00:05 +00:00
Ian Cottrell	b854406a88	internal/jsonrpc2: make the wire structures private ... The wire structures do not need to be public, and making them so might make it harder to keep the package correct without breaking changes if the protocol changes in the future. Change-Id: I03a5618c63c9f7691183d4285f88a177ccdd3b35 Reviewed-on: https://go-review.googlesource.com/c/tools/+/227838 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-04-13 01:57:29 +00:00
Ian Cottrell	c92aeb7438	internal/lsp: improve ID formatting ... Replace the String method with a Format method so we can use it for extra formats. Add some tests to make sure it is all correct Change-Id: I39f361ffba036fad99c93f8c0944164f7cf199ec Reviewed-on: https://go-review.googlesource.com/c/tools/+/227486 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-04-10 13:25:36 +00:00