216 Commits

Author	SHA1	Message	Date
Brad Fitzpatrick	a257c753ac	misc/dashboard: don't email about netbsd failures ... Too flaky. R=iant, rsc CC=golang-dev https://golang.org/cl/6925056	2012-12-12 11:33:03 -08:00
Dave Cheney	6a1036422f	dashboard/builder: pass $CC to builder if set ... R=adg, minux.ma, rsc CC=golang-dev https://golang.org/cl/6843068	2012-11-22 08:41:02 +11:00
Robert Griesemer	465b9c35e5	gofmt: apply gofmt -w src misc ... Remove trailing whitespace in comments. No other changes. R=r CC=golang-dev https://golang.org/cl/6815053	2012-10-30 13:38:01 -07:00
Dave Cheney	be6afde348	misc/dashboard/builder: check http status before processing response ... Occasionally GAE will return a 500 error response, don't treat this as a valid JSON body. R=adg, dsymonds CC=golang-dev https://golang.org/cl/6775066	2012-10-31 02:24:08 +11:00
David Symonds	b506c3e17a	misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message. ... Too many people quote entire emails and put their reply at the top ("top posting"), so we shouldn't recognise review commands anywhere in the review text. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6815048	2012-10-29 22:03:58 +11:00
Brad Fitzpatrick	08d66439b4	builder: label the race builder as "race" ... R=golang-dev, adg, dave, rsc, minux.ma, dvyukov CC=golang-dev https://golang.org/cl/6648043	2012-10-15 20:30:41 -07:00
Brad Fitzpatrick	256daf2c85	misc/dashboard: set charset utf-8 on build log downloads ... Fixes #4187 R=golang-dev, dave, minux.ma CC=golang-dev https://golang.org/cl/6587071	2012-10-03 08:16:27 -07:00
Andrew Gerrand	af832ac0b9	misc/dashboard/builder: reinstate 'go get -d' error handling hack ... I thought this was redundant since the behavior of 'go get -d' had changed. I was wrong. Should have tested more thoroughly. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6500136	2012-09-17 11:21:02 -07:00
Andrew Gerrand	129b2bb19a	misc/dashboard/builder: increase default command timeout ... R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6499127	2012-09-17 11:05:43 -07:00
Andrew Gerrand	f005fedfa9	misc/dashboard/builder: add timeout to all external command invocations ... Fixes #4083. R=golang-dev, r CC=golang-dev https://golang.org/cl/6498136	2012-09-17 10:41:47 -07:00
Alex Brainman	db3c800d19	misc/dashboard/builder: use c:\ as default buildroot on windows ... We have some tests (misc/cgo/test) that are disabled only because they will fail to run on go builder - see issue 3358 for details. This change will allow us to enable these tests. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6493118	2012-09-14 12:53:30 +10:00
David Symonds	e803e1cfa6	misc/dashboard/codereview: fixes for non-reviewers. ... Also rename the testing CGI argument from "email" to "user". R=golang-dev, r CC=golang-dev https://golang.org/cl/6454117	2012-08-08 13:16:21 +10:00
Russ Cox	bacccefa8d	misc/dashboard/codereview: fix obo ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6443091	2012-08-08 11:04:57 +10:00
Russ Cox	ab058b3540	misc/dashboard/codereview: show first line of last message in thread ... This line helps me to tell whether the CL is waiting for me or I'm waiting for the author. Also: - vertical-align table cells so buttons are always aligned with CL headers. - add email= to show front page for someone else. Demo at http://rsc.gocodereview.appspot.com/. Until this is deployed for real, some recently changed CLs may be missing the 'first line of last message' part. R=dsymonds CC=golang-dev https://golang.org/cl/6446065	2012-08-05 14:35:35 -04:00
Russ Cox	09f1f5d76d	misc/dashboard/codereview: add LastUpdate field to CL ... To be filled in by a later CL. I deployed a test version to App Engine to work on setting the values, so there are a few records that have this field set already. That field is breaking the live version, so I have pushed a new copy with this 1-line change to the live version I assumed that appengine/datastore was like every other marshaling and unmarshaling package we have in Go (for example, encoding/gob, encoding/json, encoding/xml, and protobuf) and that if it loaded an unknown field it would just ignore it. Apparently not. Sorry. R=dsymonds TBR=dsymonds CC=golang-dev https://golang.org/cl/6454064	2012-07-30 10:13:54 -04:00
David Symonds	2a9478ed64	misc/dashboard/codereview: pass user information to gobot when assigning reviewer. ... R=bradfitz CC=gobot, golang-dev, rsc https://golang.org/cl/6457052	2012-07-30 14:41:04 +10:00
David Symonds	e53351013d	misc/dashboard/codereview: switch to using gobot to update CL reviewer info. ... R=rsc CC=golang-dev https://golang.org/cl/6453063	2012-07-30 14:13:12 +10:00
David Symonds	4168804639	misc/dashboard/codereview: bump user-specific table limits to 100. ... R=rsc CC=golang-dev https://golang.org/cl/6457051	2012-07-30 14:11:51 +10:00
David Symonds	482ceeda6d	misc/dashboard/codereview: interpret zero reviewers as the CL being closed. ... This is the state when the CL has been submitted by someone other than the CL author, but before the CL author has synched their client. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6458044	2012-07-30 13:51:21 +10:00
David Symonds	be629bf79e	misc/dashboard/codereview: make all active CL tables hold up to 50 CLs. ... R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6449060	2012-07-30 11:45:17 +10:00
David Symonds	3fe5f3353f	misc/dashboard/codereview: fix tag nesting. ... R=golang-dev, rsc, minux.ma CC=golang-dev https://golang.org/cl/6454062	2012-07-30 11:37:20 +10:00
David Symonds	3cc9d16792	misc/dashboard/codereview: recognize "NOT LGTM". ... A "NOT LGTM" overrules a previous "LGTM" by the same person, and vice versa. "NOT LGTM"s are shown in the same location as LGTMs, colored red. R=rsc CC=golang-dev https://golang.org/cl/6453062	2012-07-30 10:54:50 +10:00
David Symonds	a8ce9ab46c	misc/dashboard/codereview: add admin-only link to force-update a CL. ... R=nigeltao CC=golang-dev https://golang.org/cl/6431055	2012-07-23 12:41:23 +10:00
Andrew Gerrand	5528211158	misc/dashboard/app: fix build failure notifications ... The datastore.Query methods once mutated the Query value, but now they return a derivative query, so the Hash= and ParentHash= filters were not being applied. R=golang-dev, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/6300058	2012-06-07 09:27:39 +10:00
David Symonds	935d8d16d4	misc/dashboard/codereview: handle abandoned CLs. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6257082	2012-06-01 10:55:55 +10:00
Andrew Gerrand	735ec94591	misc/dashboard/app: add debug logging to notifyOnFailure; remove unused Result.OK function ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6258064	2012-05-31 14:09:50 +10:00
Andrew Gerrand	023a7e881c	misc/dashboard/app: fix tests ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6244069	2012-05-31 14:09:24 +10:00
David Symonds	a90cbd741a	misc/dashboard/codereview: add sameer. ... R=r CC=golang-dev https://golang.org/cl/6203076	2012-05-15 08:38:05 +10:00
David Symonds	58bcec62c0	misc/dashboard/codereview: set In-Reply-To header to properly thread mail. ... R=adg CC=golang-dev https://golang.org/cl/6208051	2012-05-14 10:05:39 +10:00
David Symonds	c44a22cc49	misc/dashboard/codereview: remove transitional code. ... All current CLs have subject lines, so we don't need to check any more. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6196044	2012-05-04 16:40:24 +10:00
Andrew Gerrand	7a77645aa8	misc/dashboard/codereview: add copyright notices to Go files ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6177043	2012-05-03 09:22:45 +10:00
Rob Pike	ce30769ce3	misc/dashboard/codereview: LGTM favicon ... R=dsymonds CC=golang-dev https://golang.org/cl/6158043	2012-05-02 13:48:49 +10:00
David Symonds	cc9a5c3be7	misc/dashboard/codereview: preserve CL ordering. ... R=r CC=golang-dev https://golang.org/cl/6136056	2012-05-01 16:15:32 +10:00
David Symonds	83aa040c45	misc/dashboard/codereview: de-dup LGTMs. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6127066	2012-05-01 11:41:32 +10:00
David Symonds	dae2992c98	misc/dashboard/codereview: send mail immediately, and fill in time.Time fields. ... If we delay the mail sending, we can't send as the current user. If we don't fill in the time.Time fields, datastore.Put will fail because the zero time.Time value is out of its range. R=golang-dev, r CC=golang-dev https://golang.org/cl/6136053	2012-05-01 11:33:25 +10:00
David Symonds	1bdb788b2e	misc/dashboard/codereview: record Message-ID of code review thread mails. ... This will allow us to properly thread "R=..." mails at a later time. R=golang-dev, r CC=golang-dev https://golang.org/cl/6135053	2012-04-30 22:47:51 +10:00
David Symonds	5d331964e7	misc/dashboard/codereview: add handy logout URL. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6135052	2012-04-30 22:47:06 +10:00
David Symonds	4335ec9eeb	misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in. ... R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/6128054	2012-04-30 22:03:56 +10:00
David Symonds	24cce5c60c	misc/dashboard/codereview: don't depend on map iteration order for unit calculation. ... Fix auth requirements for /gc endpoint too. R=golang-dev, r CC=golang-dev https://golang.org/cl/6133049	2012-04-28 09:47:15 +10:00
David Symonds	fe252584f5	misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6128044	2012-04-27 23:16:54 +10:00
David Symonds	1a79053725	misc/dashboard/codereview: more abbreviated modification duration. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6131044	2012-04-27 17:12:09 +10:00
David Symonds	0175e3f1e0	misc/dashboard/codereview: new app. ... This is live at http://gocodereview.appspot.com/. R=golang-dev, r CC=golang-dev https://golang.org/cl/6134043	2012-04-27 16:36:02 +10:00
Andrew Gerrand	b6522c43d5	dashboard: sort user interface by internal counter, not date ... R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6114053	2012-04-25 13:01:08 -07:00
David Symonds	e6c5e2a363	misc/dashboard: cope with removed Package fields. ... adg removed some now-unwanted fields in Package a while ago, but there are still datastore entities with those fields, so we must explicitly check for ErrFieldMismatch and ignore it. R=golang-dev, rsc CC=adg, golang-dev https://golang.org/cl/6007043	2012-04-12 09:55:37 +10:00
Andrew Gerrand	48a76e13a5	misc/dashboard: set api_version to go1 ... R=golang-dev CC=golang-dev https://golang.org/cl/5952046	2012-04-03 08:10:51 +10:00
Shenghou Ma	a84056dabe	gobuilder: work with codereview plugin enabled in .hgrc ... Fixes #3312. R=golang-dev, adg CC=golang-dev https://golang.org/cl/5907065	2012-04-02 18:46:24 +08:00
Andrew Gerrand	c58163c572	misc/dashboard: remove remnants of package dashboard ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5847070	2012-03-20 13:35:31 +11:00
Andrew Gerrand	e9f82e6b68	misc/dashboard: remove old python package dashboard ... This leaves only the project page, which now resides at the web root. R=golang-dev, bsiegert, rsc CC=golang-dev https://golang.org/cl/5833044	2012-03-16 08:20:02 +11:00
Francisco Souza	235863cb12	doc: add "Godoc: documenting Go code" article ... Originally published on The Go Programming Language Blog, March 31, 2011. http://blog.golang.org/2011/03/godoc-documenting-go-code.html R=golang-dev, adg CC=golang-dev https://golang.org/cl/5830043	2012-03-15 14:51:44 +11:00
Robert Griesemer	56cae1c230	all: gofmt -w -s src misc ... R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5781058	2012-03-08 10:48:51 -08:00