6 Commits

Author	SHA1	Message	Date
Rob Pike	331c428e76	go.tools/cmd/vet: add check for shadowed variables ... Experimental feature. It's too noisy yet to be enabled by default, so it must be enabled explicitly by go tool vet -shadow *.go or go tool vet -shadow directory (The go command does not know about the -shadow flag.) Fixes golang/go#5634. R=golang-dev, gri CC=golang-dev https://golang.org/cl/10409047	2013-06-21 11:27:53 -07:00
Rob Pike	df787c2073	go.tools/cmd/vet: check for missing printf verb ... A trailing % resulted in a bad error message. Also clean up a couple of dregs left over from the refactoring to add indexed formats. R=dsymonds CC=golang-dev https://golang.org/cl/10336044	2013-06-18 08:21:06 -07:00
Rob Pike	3402cf10ab	go.tools/cmd/vet: verify printf for String and Error implementers ... Fixes golang/go#5624. R=adonovan CC=gobot, golang-dev, gri https://golang.org/cl/9657048	2013-06-06 16:05:14 -07:00
Rob Pike	838e9a8987	go.tools/cmd/vet: check indexed arguments in printf ... Refactor the printf parser to be easier to understand. R=gri CC=golang-dev https://golang.org/cl/9909043	2013-05-31 16:31:01 -04:00
Rob Pike	c7f7fa1381	cmd/vet: simplify format checker ... Simplify the code a bit, get it working after recent go/types changes, and handle "%*%" just in case. Preparation for handling argument indexing. R=gri CC=golang-dev https://golang.org/cl/9747045	2013-05-28 15:37:34 -04:00
Rob Pike	bf87b9f0f5	go.tools/cmd/vet: use "go test" to test ... - remove Makefile - move test data into a subdirectory - encapsulate the invocation of errchk into a standard Test using os.exec R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/9509045	2013-05-22 10:20:50 -07:00