The changes were not tested for real in an App Engine environment,
so extra care should be taken. That said, some static testing
was done with pyflakes, and a few existent problems were fixed on
the way.
R=adg
CC=golang-dev
https://golang.org/cl/4378053
We replace the current Open with:
OpenFile(name, flag, perm) // same as old Open
Open(name) // same as old Open(name, O_RDONLY, 0)
Create(name) // same as old Open(name, O_RDWR|O_TRUNC|O_CREAT, 0666)
This CL includes a gofix module and full code updates: all.bash passes.
(There may be a few comments I missed.)
The interesting packages are:
gofix
os
Everything else is automatically generated except for hand tweaks to:
src/pkg/io/ioutil/ioutil.go
src/pkg/io/ioutil/tempfile.go
src/pkg/crypto/tls/generate_cert.go
src/cmd/goyacc/goyacc.go
src/cmd/goyacc/units.y
R=golang-dev, bradfitzwork, rsc, r2
CC=golang-dev
https://golang.org/cl/4357052
This aligns the naming scheme with the testing package and
also lets govet work on more logging calls.
R=rsc
CC=golang-dev
https://golang.org/cl/4001048
- fix release upload
- add -rev= flag to build specific revision and exit
- added support for all-$GOARCH.bash
R=rsc
CC=golang-dev
https://golang.org/cl/2247044
Plus automatic package<->project association script.
(This is just a helper script for now. I intend to fully automate
the associations further down the track.)
R=rsc
CC=golang-dev
https://golang.org/cl/1715054
This results in a 10-20x size reduction per record.
(from ~150kb to ~10kb)
This revision has been pushed live, as I'm in the process of
converting Log records to bz2-compresed CompressedLog records.
I would have waited but we're running seriously low on space
and it seemed like a sane (and reversible) move.
R=rsc
CC=golang-dev
https://golang.org/cl/872048
various caching. make benchmark data a list
in a single per-builder,benchmark record instead
of having one record for each data point.
significant reduction in datastore cpu charges.
R=agl1, agl
CC=golang-dev
https://golang.org/cl/217111
reorganize benchmark computation so that it is
incremental. if it times out, it doesn't lose the
pieces it already computed, so that next time it
has a fighting chance to finish.
R=agl1, agl
CC=golang-dev
https://golang.org/cl/216046
* fix bug in benchmark collection: bad benchmark data key
meant that all the builders collided when writing data.
* report benchmarks even if make bench exits non-zero.
* graphical and json presentations
R=agl1
CC=golang-dev
https://golang.org/cl/201065
so that if you have a key.py with the real key,
there is no chance hg change will accidentally
make a CL with the real key and upload it to codereview.
R=agl1
CC=golang-dev
https://golang.org/cl/196051
