1
0
mirror of https://github.com/golang/go synced 2024-11-21 22:04:39 -07:00
Commit Graph

5 Commits

Author SHA1 Message Date
Brad Fitzpatrick
05a1b7ec41 http: remove finalURL from Client.Get; move to Response
This CL:

-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
   the final url to the blank identifier; warning otherwise

Caller who did:

res, finalURL, err := http.Get(...)

now need to do:

res, err := http.Get(...)
if err != nil {
   ...
}
finalURL := res.Request.URL.String()

R=rsc
CC=golang-dev
https://golang.org/cl/4535056
2011-05-13 07:31:24 -07:00
Rob Pike
eea18d959e log: rename Exit* to Fatal*
This aligns the naming scheme with the testing package and
also lets govet work on more logging calls.

R=rsc
CC=golang-dev
https://golang.org/cl/4001048
2011-02-01 12:47:35 -08:00
Russ Cox
634cef25c3 doc/codelab/wiki: fixes
make test.sh runnable as a command.
announce only on 127.0.0.1.
rebuild final-test.bin when final-test.go changes.

R=adg, r
CC=golang-dev
https://golang.org/cl/4030044
2011-01-28 09:42:51 -05:00
Andrew Gerrand
5899cab037 doc/codelab/wiki: tests use available TCP port
R=bradfitz, dsymonds, r2, dangabrad, rsc
CC=golang-dev
https://golang.org/cl/4043043
2011-01-27 23:19:37 +10:00
Andrew Gerrand
9ec785af2f doc/codelab/wiki: replace curl with a Go program
R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4087043
2011-01-27 10:32:41 +10:00