1
0
mirror of https://github.com/golang/go synced 2024-11-22 07:14:40 -07:00
Commit Graph

868 Commits

Author SHA1 Message Date
Rob Pike
fb9e37cd9b template: reverse order of arguments to Execute
In line with other functions such as Fprintf, put the
thing to be written first.

Apologies for the breakages this is sure to cause.

R=rsc, gri, adg, eds, r2, aam
CC=golang-dev
https://golang.org/cl/4169042
2011-02-09 14:23:01 -08:00
Robert Griesemer
2a81292ac3 srcextract: HTML-escape output if so desired
This functionality was removed with CL 4169041.

Minor simplifications.

R=r, adg
CC=golang-dev
https://golang.org/cl/4171042
2011-02-09 14:08:19 -08:00
Rob Pike
6d51fc6c1e codelab: update due to recent changes in go/printer
R=gri, adg
CC=golang-dev
https://golang.org/cl/4169041
2011-02-09 12:46:34 -08:00
Anthony Martin
0122a667b6 go spec: fix a few typos
The spec can now be parsed with an
xml.Parser using the HTML settings.

R=gri
CC=golang-dev
https://golang.org/cl/4155042
2011-02-08 14:51:15 -08:00
Robert Griesemer
2a838d6424 go spec: clarification re: method sets of newly declared pointer types
- added an example to Type declarations section clarifying the
  situation brought up with issue 1324
- slightly re-ordered paragraphs in Types section
- added separate heading for method set section and refer to it
  from elsewhere in the spec
- no language changes

R=rsc, r, iant, ken2, r2
CC=golang-dev
https://golang.org/cl/4145043
2011-02-08 13:31:01 -08:00
Andrey Mirtchovski
b2b29814bf Codelab/wiki: fix typo
Missing closing bracket renders the next code snippet unreadable.

R=adg, gri
CC=golang-dev
https://golang.org/cl/4119060
2011-02-07 11:51:17 -08:00
Andrey Mirtchovski
61c93cac3e Codelab: correct function definitions for handlers before closures are introduced.
A couple of post-closure function definitions were introduced too early, making the resulting
code fail compilation.

Also, the TitleValidator regexp was missing.

R=adg
CC=golang-dev
https://golang.org/cl/4105054
2011-02-07 09:23:18 +01:00
Gustavo Niemeyer
f8404ee3e1 spec: fix Typeof() return type
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4121058
2011-02-04 09:29:08 -08:00
Robert Griesemer
76f3228520 go spec, effective go: cleanups
Removed most of the detailed examples about handing panics
from the go spec since it's now covered by Effective Go.

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/4128058
2011-02-04 08:43:21 -08:00
Robert Griesemer
838b5ad9d6 go spec: move to Unicode 6.0
R=r, r2
CC=golang-dev
https://golang.org/cl/4128055
2011-02-03 12:27:41 -08:00
Robert Griesemer
fa3d0d73f0 go spec: adjust notion of Assignability
This change makes it legal to pass a struct value as receiver
outside the package declaring the struct even if the respective
struct type has non-exported fields.

This is a backwards-compatible language change motivated by the
fact that it is already possible to circumvent the assignment
restriction when calling methods through interfaces (see issue
1402).

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/3926044
2011-02-03 10:53:31 -08:00
Russ Cox
a6736cae30 spec: allow imported packages named main
Prior to this CL, there were two requirements about the
package name main.

1. The package that sits at the root of the import graph
   (the one where program execution begins)
   must be named main.

2. No other package in the program can be named main.

This CL only removes requirement #2, which can be done
without changing any other Go documentation.

The new wording and formatting is such that removing
requirement #1 can be done by deleting a single line,
but making that change is explicitly outside the scope
of this CL, because it would require changes to other
documentation at the same time.

R=gri, r, gri1
CC=golang-dev
https://golang.org/cl/4126053
2011-02-03 13:40:51 -05:00
Robert Griesemer
68b40fbbb8 Getting Started guide: update for new versions of Mercurial
Newer versions of Mercurial require the configuration
of Certification Authorities.

R=rsc
CC=golang-dev
https://golang.org/cl/4128052
2011-02-02 15:53:32 -08:00
Robert Griesemer
bd4e49f524 Effective Go: fix typo
Fixes #1467.

R=r, r2
CC=golang-dev
https://golang.org/cl/3981054
2011-02-02 11:02:56 -08:00
Andrew Gerrand
7aa758df0c release.2011-02-01
R=rsc
CC=golang-dev
https://golang.org/cl/4119050
2011-02-02 10:59:59 +11:00
Robert Griesemer
7fc4e37853 go spec: s/log.Crash/log.Panic/
There is no log.Crash.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4058048
2011-02-01 12:51:10 -08:00
Rob Pike
eea18d959e log: rename Exit* to Fatal*
This aligns the naming scheme with the testing package and
also lets govet work on more logging calls.

R=rsc
CC=golang-dev
https://golang.org/cl/4001048
2011-02-01 12:47:35 -08:00
Robert Griesemer
b50ed022f5 go spec: follow-up cleanups after communication operator changes
These are syntactical changes to better reflect the communication
operator's new status in the language.

- sending to a channel is now done via a send statement
- there is no binary communication operation anymore which
  leads to a reduction of the number of precedence levels
  from 6 to 5 (yeah!)
- small semantic change: since a send operation is not part
  of the expression syntax anymore, a <- send operator is
  binding weaker than any other operator now
- receiving from a channel is done as before via the unary
  receive expression
- communication clauses in select statement now can contain
  send statements or receive expressions

R=rsc, r, iant, ken2, gri1
CC=golang-dev
https://golang.org/cl/3973051
2011-02-01 12:02:49 -08:00
Russ Cox
614391860a ebnflint: exit with non-zero status on error
Tweak spec to avoid ebnflint complaints.

R=gri
CC=golang-dev
https://golang.org/cl/3973050
2011-01-31 17:42:10 -05:00
Rob Pike
6990bc124f doc/progs: make sure all programs compile and run
Fixes #1455.

R=rsc
CC=golang-dev
https://golang.org/cl/4079055
2011-01-31 14:41:36 -08:00
Rob Pike
61978aa579 effective go: remove non-blocking ops in leaky bucket example
R=rsc
CC=golang-dev
https://golang.org/cl/4029048
2011-01-31 12:46:38 -08:00
Russ Cox
634cef25c3 doc/codelab/wiki: fixes
make test.sh runnable as a command.
announce only on 127.0.0.1.
rebuild final-test.bin when final-test.go changes.

R=adg, r
CC=golang-dev
https://golang.org/cl/4030044
2011-01-28 09:42:51 -05:00
Russ Cox
19d9a40845 spec: remove non-blocking channel operators
Add intended changes for close + closed, commented out.

R=golang-dev, niemeyer, r, gri1
CC=golang-dev
https://golang.org/cl/4013045
2011-01-27 15:34:28 -05:00
Andrew Gerrand
5899cab037 doc/codelab/wiki: tests use available TCP port
R=bradfitz, dsymonds, r2, dangabrad, rsc
CC=golang-dev
https://golang.org/cl/4043043
2011-01-27 23:19:37 +10:00
Andrew Gerrand
9ec785af2f doc/codelab/wiki: replace curl with a Go program
R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4087043
2011-01-27 10:32:41 +10:00
Robert Griesemer
0e1d941e5c go spec: clarify address operators.
Fixes #1445.

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/4109041
2011-01-26 11:21:23 -08:00
Rob Pike
a64e63227a faq: fix minor errors in programs reported by Wojciech Mikanik
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4114041
2011-01-26 10:41:32 -08:00
Russ Cox
bba20fc1fa codelab/wiki: fix freebsd build
TBR=adg
CC=golang-dev
https://golang.org/cl/4092042
2011-01-26 13:02:09 -05:00
Russ Cox
770acbe7b8 codelab/wiki: fix build
TBR=adg
CC=golang-dev
https://golang.org/cl/4077045
2011-01-26 12:54:07 -05:00
Andrew Gerrand
549d7f49d5 doc/codelab/wiki: rename textarea name from Body to body
R=mattn
CC=golang-dev
https://golang.org/cl/4034046
2011-01-26 17:25:37 +10:00
Andrew Gerrand
add4e167e3 doc/codelab/wiki: update to work with template changes, add to run.bash
Fixes #1444.

R=rsc, r
CC=golang-dev
https://golang.org/cl/3979045
2011-01-26 14:56:52 +10:00
Russ Cox
27c74d3499 spec, runtime, tests: send on closed channel panics
Close of closed channel panics.
Receive from closed channel never panics,
even if done repeatedly.

Fixes #1349.
Fixes #1419.

R=gri, iant, ken2, r, gri1, r2, iant2, rog, albert.strasheim, niemeyer, ejsherry
CC=golang-dev
https://golang.org/cl/3989042
2011-01-21 15:07:13 -05:00
Robert Griesemer
955aa159ad godoc: show line numbers for non-go files (bug fix)
Also: Give line numbers a style and make them less intrusive.

R=rsc
CC=golang-dev
https://golang.org/cl/4060043
2011-01-20 10:43:55 -08:00
Russ Cox
34c1b13c2a release.2011-01-20
R=r, adg
CC=golang-dev
https://golang.org/cl/3998045
2011-01-20 00:02:59 -05:00
Rob Pike
80e25fc923 docs: float->float64 plus a couple of other tweaks.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/3978042
2011-01-19 23:07:38 -05:00
Robert Griesemer
b94c0d2a77 go spec: remove float, complex in favor of float64 and complex128
The default float type is not very useful but for the most basic applications.
For instance, as it is now, using the math package requires conversions for float
variables (the arguments for math functions are usually float64). Typical real
applications tend to specify the floating point precision required.

This proposal removes the predeclared types float and complex. Variable declarations
without type specification but with constant floating point or complex initializer
expressions will assume the type float64 or complex128 respectively.

The predeclared function cmplx is renamed to complex.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/3423041
2011-01-19 23:07:21 -05:00
Andrew Gerrand
4b7fab83b5 release.2011-01-19
R=r, rsc, r2
CC=golang-dev
https://golang.org/cl/4087041
2011-01-20 14:01:32 +11:00
Robert Griesemer
dfc5bb5ff6 go spec: adjust language for constant typing
Fixes #1421.

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/4039042
2011-01-19 10:33:41 -08:00
Rob Pike
eaade07d63 tutorial: update go_tutorial.txt
should have been included in last CL; no idea why it was not

R=brainman
CC=golang-dev
https://golang.org/cl/4005043
2011-01-18 11:07:02 -08:00
Rob Pike
166b444a93 tutorial: make stdin, stdout, stderr work on Windows.
R=brainman
CC=golang-dev
https://golang.org/cl/4042042
2011-01-18 11:01:47 -08:00
Robert Griesemer
97025ebfef go_spec: specify that int and uint have the same size
R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/3992041
2011-01-13 10:24:04 -08:00
Andrew Gerrand
c3e33975aa release.2011-01-12
R=r
CC=golang-dev
https://golang.org/cl/3972041
2011-01-13 12:04:43 +11:00
Robert Griesemer
4bdaf59cc9 godoc: support for regular expression full text search
Regular expressions may now be used in conjuction with full text
search. Godoc will show the first 10000 occurences in the source
code and highlight the respective text segments.

- added new flag -testDir to specify a small directory for testing
  (fast index creation; default = "")

- use new FormatText function to format text and Go source
  code in HTML, supporting multiple kinds of text selections
  simulatenously); this replaces the uses of go/printer
  Stylers

- for now removed currently unused mechanism for identifier-
  specific JS popups (will come back in some form once we
  have type or other useful information)

- various typo fixes and minor cleanups throughout

Missing:
- indexing of non-.go files

R=r, r2
CC=golang-dev, rsc
https://golang.org/cl/3699041
2011-01-10 15:34:29 -08:00
Robert Griesemer
dd916be3d8 go spec: remove Maxalign from spec
Fixes #1285.

R=r, rsc, iant, ken2, r2
CC=golang-dev
https://golang.org/cl/3918041
2011-01-10 14:25:17 -08:00
Peter Mundy
c6ed78a4c1 doc: contribution copyright year 2011
R=r
CC=golang-dev
https://golang.org/cl/3907042
2011-01-08 17:17:15 -08:00
Andrew Gerrand
41170c91e5 release.2011-01-06
R=nigeltao, nigeltao_gnome
CC=golang-dev
https://golang.org/cl/3829043
2011-01-07 15:28:25 +11:00
Andrew Gerrand
4cd31e8a28 doc: add golanguage.ru to foreign-language doc list
R=r, brainman, r2
CC=golang-dev
https://golang.org/cl/3881041
2011-01-07 09:34:13 +11:00
Rob Pike
29d0f02bd2 effective go: explain the effect of repanicking better.
Also fix a <p> error in go_spec.html.

Fixes #1370.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/3835043
2011-01-05 11:39:57 -08:00
Nigel Tao
3f38342e24 doc: update contribution guidelines to prefix the change description
with the primary affected package.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/3867041
2011-01-05 13:00:08 +11:00
Nigel Tao
bf453eba90 doc: update Effective Go for template API change.
The original change 3378041 was submitted in December 2010:
template: change the signature of formatters for future development.

R=adg
CC=golang-dev
https://golang.org/cl/3862041
2011-01-04 15:52:03 +11:00
Andrew Gerrand
7d557ebc1d release.2010-12-22
R=r
CC=golang-dev
https://golang.org/cl/3809042
2010-12-23 13:32:20 +11:00
Andrew Gerrand
e253d37d3e doc/devel: release notes tweak
R=r
CC=golang-dev
https://golang.org/cl/3707041
2010-12-16 12:51:01 +11:00
Andrew Gerrand
e4fbcb2c23 release.2010-12-15
R=rsc
CC=golang-dev
https://golang.org/cl/3646043
2010-12-16 12:29:10 +11:00
Russ Cox
0c54225b51 remove nacl
The recent linker changes broke NaCl support
a month ago, and there are no known users of it.

The NaCl code can always be recovered from the
repository history.

R=adg, r
CC=golang-dev
https://golang.org/cl/3671042
2010-12-15 11:49:23 -05:00
Russ Cox
43f459ce51 typo
R=iant
CC=golang-dev
https://golang.org/cl/3582042
2010-12-14 11:33:17 -05:00
Anthony Martin
11a016151b go spec: fix two grammar typos
R=gri
CC=golang-dev
https://golang.org/cl/3580042
2010-12-13 22:19:41 -08:00
Russ Cox
7ff68b365b go_mem: goroutine exit is not special
R=r
CC=golang-dev
https://golang.org/cl/3628041
2010-12-13 17:08:27 -05:00
Russ Cox
3a2ba994b6 build: add a few missing --no-print-directory
Reported by W. Michael Petullo <mike@flyn.org>

Fixes #1269.

R=r, r2
CC=golang-dev
https://golang.org/cl/3618041
2010-12-13 15:50:57 -05:00
Rob Pike
e3b6188ca2 tutorial: a couple of minor fixes.
Fixes #1333.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/3556041
2010-12-09 16:18:31 -05:00
Andrew Gerrand
affd1ba94e doc: fix invalid id attribute in faq
R=r
CC=golang-dev
https://golang.org/cl/3516042
2010-12-09 08:59:29 +11:00
Peter Mundy
c17394df31 doc: fix installation $GOOS choices
The $GOOS choices text and combinations list should match.

R=adg
CC=golang-dev
https://golang.org/cl/3485046
2010-12-08 20:27:45 +11:00
Andrew Gerrand
f5ec1876c2 release.2010-12-08
R=rsc
CC=golang-dev
https://golang.org/cl/3463043
2010-12-08 14:24:35 +11:00
Andrew Gerrand
ab7884da7e doc: add link to WindowsPort page from install.html
R=r
CC=golang-dev
https://golang.org/cl/3442042
2010-12-08 08:31:26 +11:00
Andrew Gerrand
f89050d7d8 doc/install: describe GOHOSTOS and GOHOSTARCH
Fixes #1303.

R=rsc, PeterGo
CC=golang-dev
https://golang.org/cl/3442041
2010-12-05 12:04:15 +09:00
Andrew Gerrand
09e4d860bc godoc: add separators between quick reference topics
R=bradfitz, dangabrad
CC=golang-dev
https://golang.org/cl/3433042
2010-12-03 14:37:55 +11:00
Andrew Gerrand
7f1b064f1e release.2010-12-02
R=r, r2
CC=golang-dev
https://golang.org/cl/3433041
2010-12-03 11:48:18 +11:00
Andrew Gerrand
bddc699b77 doc: add gofrontend paper to talks/ and docs.html
R=r, iant
CC=golang-dev
https://golang.org/cl/3434041
2010-12-03 11:47:33 +11:00
Andrew Gerrand
0e3eefaf0f doc: add Practical Go Programming to front page and docs.html
R=r
CC=golang-dev
https://golang.org/cl/3391042
2010-12-03 06:57:30 +09:00
Robert Griesemer
777a96a5b0 go_spec: fixed a couple omissions/type errors
- use math.Sqrt instead of Math.sqrt
- use float64 for Point fields to match math.Sqrt
- distinguish between Point and Point3D for clarity
- add alignment sizes for complex types

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/3420041
2010-12-02 12:32:14 -08:00
Rob Pike
4bafef8184 roadmap: update gdb status
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/3395041
2010-12-01 17:10:26 -08:00
Kyle Consalus
009aebdba8 Removed bytes.Add and bytes.AddByte; we now have 'append'.
Changed all uses of bytes.Add (aside from those testing bytes.Add) to append(a, b...).
Also ran "gofmt -s" and made use of copy([]byte, string) in the fasta benchmark.

R=golang-dev, r, r2
CC=golang-dev
https://golang.org/cl/3302042
2010-12-01 11:59:13 -08:00
Anschel Schaffer-Cohen
93f97ca235 doc/code.html: fix reference to "gomake build"
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/3288042
2010-11-29 09:17:28 -08:00
Peter Mundy
abb0c0967c doc: fix docs typos
R=adg
CC=golang-dev
https://golang.org/cl/3315041
2010-11-29 10:10:02 +09:00
Andrew Gerrand
fbfa971a16 release.2010-11-23
R=nigeltao
CC=golang-dev
https://golang.org/cl/3293041
2010-11-24 10:47:59 +11:00
Yves Junqueira
de3a397615 doc: add link to codewalks.
Fixes #1281.

R=adg
CC=golang-dev
https://golang.org/cl/3150041
2010-11-23 10:43:16 +11:00
Yves Junqueira
52c23f3009 Documentation: how to write Makefiles for commands.
Fixes #1282.

R=adg
CC=golang-dev
https://golang.org/cl/3152041
2010-11-23 10:42:04 +11:00
Anschel Schaffer-Cohen
5083eedf88 Fixed recover() documentation.
Added a "return" to the end of an example which previously threw a compile error if used.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/3052041
2010-11-12 09:57:46 -08:00
Rob Pike
013af62ae9 release step 1
R=gri
CC=golang-dev
https://golang.org/cl/3022041
2010-11-10 14:22:40 -08:00
Peter Mundy
5928e1d4dc doc: fix go_spec spelling errors
R=gri
CC=golang-dev
https://golang.org/cl/2970042
2010-11-09 10:10:57 -08:00
Peter Mundy
9626180918 doc: fix go_spec spelling error
R=rsc, gri
CC=golang-dev
https://golang.org/cl/2985041
2010-11-09 08:46:13 -08:00
Andrey Mirtchovski
f1af2ecbab doc/codewalk: update for changes in log package
R=adg, r
CC=golang-dev
https://golang.org/cl/2984041
2010-11-08 09:58:57 -08:00
Nigel Tao
fc98af93ac doc: make root.html's blog section less cluttered.
R=r
CC=golang-dev
https://golang.org/cl/2925041
2010-11-05 16:13:58 +11:00
Robert Griesemer
d73d1c5f32 go spec: line comments may end in EOF
Consistency argument: A valid Go program should
remain valid after stripping leading and trailing
whitespace. This was not true so far if the last
text in the source was a line comment.

R=iant, ken2, r, rsc, r2
CC=golang-dev
https://golang.org/cl/2906041
2010-11-04 13:48:32 -07:00
Rob Pike
70d0b6b242 Effective Go: correct error in recent edit: "..." is in call to Sprintln, not Output.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/2853042
2010-11-03 11:09:43 -07:00
Andrew Gerrand
1e86d46a76 release.2010-11-02
R=golang-dev, gri, r2, r
CC=golang-dev
https://golang.org/cl/2846041
2010-11-03 11:49:22 +11:00
Rob Pike
0808b199e0 Effective Go: append and a few words about ...
R=rsc, gri, iant
CC=golang-dev
https://golang.org/cl/2821041
2010-11-01 21:46:04 -07:00
Robert Griesemer
11684680fa go spec: append is now implemented
R=r, r2
CC=golang-dev
https://golang.org/cl/2717043
2010-10-29 11:44:48 -07:00
Andrew Gerrand
9e4031ae56 release.2010-10-27
R=rsc
CC=golang-dev
https://golang.org/cl/2747044
2010-10-28 11:19:52 +11:00
Robert Griesemer
904adfdc46 go spec: clarify return type of append, argument type for ...T parameters
R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2774041
2010-10-27 10:44:31 -07:00
Robert Griesemer
a8abb64a71 go spec: note re: append() not being implemented yet
R=rsc
CC=golang-dev
https://golang.org/cl/2761041
2010-10-26 20:30:35 -07:00
Russ Cox
e8bde0ec19 install doc: arm is a little better
R=adg, r, r2
CC=golang-dev
https://golang.org/cl/2749041
2010-10-26 08:34:40 -07:00
Andrew Gerrand
e9860628ee doc: update roadmap
R=rsc
CC=golang-dev
https://golang.org/cl/2735042
2010-10-26 16:29:21 +11:00
Andrew Gerrand
d7424b1a71 doc: update roadmap
R=r, rsc, iant
CC=golang-dev
https://golang.org/cl/2312042
2010-10-26 16:18:12 +11:00
Robert Griesemer
07e983a965 go spec: append built-in
R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2627043
2010-10-25 16:50:31 -07:00
Robert Griesemer
425bbadd3c go_spec: allow copy() to copy bytes from a string into a []byte
(language change as discussed a while ago)

R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2716041
2010-10-25 16:41:06 -07:00
Robert Griesemer
a12141e5f4 go spec: relaxed syntax for array, slice, and map composite literals
For elements which are themselves composite literals, the type may
be omitted if it is identical to the element type of the containing
composite literal.

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/2661041
2010-10-22 08:58:52 -07:00
Andrew Gerrand
a89b0ed7e4 playground: s/it/this/
R=r, r2
CC=golang-dev
https://golang.org/cl/2663041
2010-10-22 10:49:29 +11:00
Andrew Gerrand
7de5e6e84d go_tutorial: change wording slightly and sync .txt and .html post-gofmt
Fixes #1211.

R=r, r2
CC=golang-dev
https://golang.org/cl/2635041
2010-10-21 14:59:23 +11:00
Andrew Gerrand
ec2c9937f4 release.2010-10-20
R=r, rsc
CC=golang-dev
https://golang.org/cl/2629041
2010-10-21 11:33:41 +11:00
Rob Pike
122fc3b5b7 fix bug in example. need to convert Value to float in Abs example
R=adg
CC=golang-dev
https://golang.org/cl/2486043
2010-10-18 16:05:50 -07:00