qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-04 00:11:21 -06:00
Code Releases Activity
2,265 Commits 58 Branches 402 Tags 522 MiB
140aed9ab7
Commit Graph

1418 Commits

Author SHA1 Message Date
Ian Lance Taylor
7aabf2d9b1 Add os.Link, os.Symlink, os.Readlink. 
R=r,rsc
DELTA=161  (161 added, 0 deleted, 0 changed)
OCL=28745
CL=28747
 2009-05-13 10:16:46 -07:00
Rob Pike
52f071ed43 Rename ParseError to Error 
R=rsc
DELTA=13  (6 added, 1 deleted, 6 changed)
OCL=28743
CL=28746
 2009-05-13 10:01:55 -07:00
Rob Pike
b66d703941 change name of reflect.NewInitValue to the more descriptive NewZeroValue. 
R=rsc
DELTA=10  (0 added, 0 deleted, 10 changed)
OCL=28717
CL=28720
 2009-05-12 16:16:52 -07:00
Russ Cox
d06a79e31b no need for compiler to hard-code definition of runtime. 
use the actual go source instead.

R=r
DELTA=90  (66 added, 18 deleted, 6 changed)
OCL=28708
CL=28719
 2009-05-12 16:15:52 -07:00
Russ Cox
28516d4c78 update reflect for upcoming interface representation change. 
test case for new change.

both work with the current compiler too.

R=r
DELTA=150  (145 added, 2 deleted, 3 changed)
OCL=28703
CL=28715
 2009-05-12 16:08:16 -07:00
Russ Cox
daf44e2fa5 fix build: proto depends on fmt now 
TBR=r,dsymonds
OCL=28711
CL=28711
 2009-05-12 15:47:55 -07:00
David Symonds
6c384d2268 Allow http.Redirect to do both temporary (307) and permanent (301) redirects. 
This also adds a missing 'return' when a malformed URL is passed to it.

R=rsc
APPROVED=rsc
DELTA=30  (13 added, 2 deleted, 15 changed)
OCL=28598
CL=28710
 2009-05-12 15:41:19 -07:00
Rob Pike
a8f6e38bce implement IsNil() bool for those types that can be nil. most of them, anyway. 
R=rsc
DELTA=97  (96 added, 0 deleted, 1 changed)
OCL=28596
CL=28702
 2009-05-12 14:57:44 -07:00
Robert Griesemer
c6da3e5a69 A couple of godoc improvements: 
- sort directories before printing
- apply filtering to factory functions and methods
- remove a couple of unused files

R=r
DELTA=84  (34 added, 40 deleted, 10 changed)
OCL=28657
CL=28657
 2009-05-11 16:52:59 -07:00
Russ Cox
3619f1ea6a change utf8.FullRuneInString and utf8.DecodeRuneInString 
to use single string argument instead of string, index.

R=r
DELTA=136  (9 added, 7 deleted, 120 changed)
OCL=28642
CL=28644
 2009-05-11 14:10:34 -07:00
Russ Cox
0880593436 gobuild: command printing bug fix 
R=r
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=28583
CL=28590
 2009-05-08 16:38:42 -07:00
Russ Cox
59be46ca35 use exitgroup on linux to exit whole process. 
R=r
DELTA=60  (38 added, 19 deleted, 3 changed)
OCL=28589
CL=28589
 2009-05-08 16:36:46 -07:00
Rob Pike
20850fc014 Package unsafe is undocumented. By installing (but not compiling) this file, 
which contains only declarations, we can have godoc present documentation
for the package.

R=gri,rsc
DELTA=44  (43 added, 0 deleted, 1 changed)
OCL=28555
CL=28588
 2009-05-08 16:24:55 -07:00
Rob Pike
4f21161269 Document runtime functions. 
R=rsc
DELTA=25  (25 added, 0 deleted, 0 changed)
OCL=28574
CL=28580
 2009-05-08 15:55:45 -07:00
Russ Cox
b3533dfd72 6g: 
new type equality restrictions
	better handling of renamed packages
	"sys" is no longer available to programs

R=ken
OCL=28553
CL=28578
 2009-05-08 15:40:31 -07:00
Russ Cox
917aa35f8f implications of stricter type equality: 
if both types are named, they must be
the same type (arising from the same
declaration).

R=r,gri
DELTA=44  (21 added, 4 deleted, 19 changed)
OCL=28436
CL=28577
 2009-05-08 15:40:14 -07:00
Russ Cox
cd3ab57a9c fix comment 
R=r
DELTA=1  (0 added, 1 deleted, 0 changed)
OCL=28576
CL=28576
 2009-05-08 15:39:18 -07:00
Russ Cox
7e235c1e27 fix build - missing file 
TBR=r
OCL=28575
CL=28575
 2009-05-08 15:29:43 -07:00
Russ Cox
918afd9491 move things out of sys into os and runtime 
R=r
OCL=28569
CL=28573
 2009-05-08 15:21:41 -07:00
Rob Pike
c367d1b789 Move sys.Reflect and sys.Unreflect into unsafe. 
R=rsc
DELTA=19  (4 added, 5 deleted, 10 changed)
OCL=28563
CL=28566
 2009-05-08 14:57:56 -07:00
Russ Cox
d4fa253837 eqtype(t1, t2, 0) => eqtype(t1, t2) 
R=ken
OCL=28559
CL=28562
 2009-05-08 14:40:38 -07:00
Russ Cox
1b301bac1a throw away os._Error. 
make some error types in a few packages

R=r
DELTA=110  (25 added, 46 deleted, 39 changed)
OCL=28382
CL=28561
 2009-05-08 14:40:20 -07:00
Rob Pike
01712ae7d3 embeddability: change bufio.BufRead to bufio.Reader etc. 
R=rsc
DELTA=112  (0 added, 4 deleted, 108 changed)
OCL=28537
CL=28543
 2009-05-08 11:52:39 -07:00
Rob Pike
c8b47c6fce Name change to improve embeddability: 
io.Read->io.Reader
	io.Write,Close,etc.->io.Writer,Closer etc.

R=rsc
DELTA=190  (0 added, 0 deleted, 190 changed)
OCL=28525
CL=28535
 2009-05-08 11:22:57 -07:00
Russ Cox
63629d5307 minor cleanup, not required by compiler changes 
R=r
DELTA=14  (1 added, 4 deleted, 9 changed)
OCL=28447
CL=28509
 2009-05-08 10:14:55 -07:00
Russ Cox
97bc222d5c another attempt at avoiding IPv6 when it's not supported. 
dsymonds confirms that this one works.

R=r
DELTA=50  (23 added, 17 deleted, 10 changed)
OCL=28433
CL=28444
 2009-05-07 17:36:29 -07:00
Rob Pike
93bbbf90ef make go/src/lib/hash one directory per package 
(slipped through the cracks last time)

R=rsc
DELTA=2436  (1337 added, 1090 deleted, 9 changed)
OCL=28427
CL=28443
 2009-05-07 17:15:24 -07:00
David Symonds
abdf4853a7 Define Len() for JSON Map. 
R=rsc
APPROVED=rsc
DELTA=6  (5 added, 0 deleted, 1 changed)
OCL=28398
CL=28430
 2009-05-07 15:09:32 -07:00
Russ Cox
401a95aa83 if a struct s contains an anonymous interface value 
with method m, s.m() is ok and m now shows up
in s's method set for interface runtime.

see http://cl/28419-p2 for new test interface10.go.

R=ken
OCL=28420
CL=28423
 2009-05-07 13:42:47 -07:00
Russ Cox
0d33992866 next step for 6.out on Borg: fix and test 
net code on IPv4-only machines.

R=r
DELTA=27  (25 added, 0 deleted, 2 changed)
OCL=28404
CL=28411
 2009-05-07 10:31:48 -07:00
Russ Cox
88a1aa8e1a 6g: error messages 
part 2; missing files

R=ken
OCL=28408
CL=28410
 2009-05-07 10:30:22 -07:00
Russ Cox
b5e212ffdd 6g: error messages 
replace "shape error across CALL" with more information.

x.go:7: not enough arguments to CALL
	a int, b int
	int
x.go:10: assignment count mismatch: 3 = 2
x.go:12: too many arguments to RETURN
	[no arguments expected]
	int, int, int

also leave type alone after conversion failure,
for later errors:

bug049.go:6: cannot convert nil constant to string
bug049.go:6: illegal types for operand: EQ
	string
	nil		# this used to be blank

R=ken
OCL=28405
CL=28407
 2009-05-07 10:29:35 -07:00
Russ Cox
5a67ea3883 6g: simplify trampoline by postponing load. 
TEXT tramp
		MOVQ 8(SP), AX
		ADDQ $40, AX
		MOVQ AX, 8(SP)
		JMP oldfunc

	is now

	TEXT tramp
		ADDQ $40, 8(SP)
		JMP oldfunc

	and if s/40/0/, then it simplifies to

	TEXT tramp
		JMP oldfunc

	(the tramp is still needed to satisfy
	symbol references from other object files)

R=ken
OCL=28377
CL=28381
 2009-05-06 17:06:06 -07:00
Russ Cox
3071f8c8e5 fix a few type errors, make ErrorString a value 
will submit with fixed compiler

R=r
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=28371
CL=28379
 2009-05-06 17:05:46 -07:00
Russ Cox
a6ba5ec535 6g: new interface rules (code got simpler!) 
R=ken
OCL=28374
CL=28378
 2009-05-06 17:05:35 -07:00
Russ Cox
1d1316c885 makefile fixes 
R=r
OCL=28369
CL=28369
 2009-05-06 16:16:55 -07:00
Russ Cox
83cd4ee070 6g: generate string data as individual symbols, 
so that 6l can discard strings used by dead code.
also, for short strings, generate DUPOK global
symbols so that references to, say, "%s: %s" in
multiple files result in only a single symbol.

R=ken
OCL=28361
CL=28361
 2009-05-06 13:47:40 -07:00
Rob Pike
0c3a43e7b2 error handling had a bug in execute: the error channel was being shared. 
fix that and clean up state handling a little.

R=rsc
DELTA=44  (18 added, 8 deleted, 18 changed)
OCL=28359
CL=28359
 2009-05-06 13:42:59 -07:00
Rob Pike
68382ec021 add missing Makefile to repair build 
TBR=gri
OCL=28320
CL=28320
 2009-05-05 21:31:22 -07:00
Ken Thompson
c4de24981a signs on div and mod 
R=r
OCL=28319
CL=28319
 2009-05-05 21:19:58 -07:00
Robert Griesemer
1d6bd79ceb new dir structure for lib/go 
R=r
DELTA=9298  (4760 added, 4536 deleted, 2 changed)
OCL=28317
CL=28317
 2009-05-05 18:38:45 -07:00
Russ Cox
3e9b171b79 6g bug: was dropping assignment of nil to globals 
R=ken
OCL=28314
CL=28314
 2009-05-05 17:33:51 -07:00
Rob Pike
86043a87c9 mv container/vector down one level for new rules. 
simplify run.bash now that lib has make test that recurs.

R=rsc
DELTA=1179  (578 added, 596 deleted, 5 changed)
OCL=28313
CL=28313
 2009-05-05 17:24:01 -07:00
Rob Pike
9b2c5da922 directory-per-package step 1: move files from lib/X.go to lib/X/X.go 
no substantive changes except:
	- new Makefiles, all auto-generated
	- go/src/lib/Makefile has been extensively edited

R=rsc
OCL=28310
CL=28310
 2009-05-05 17:05:39 -07:00
Russ Cox
f821e3c7c3 6g tweaks 
* byteastring is no longer used
	* do not generate ODCL, OAS for globals
	  (wasn't generating any code but might
	  save one or two init functions)
	* do not call self from Init function

R=ken
OCL=28309
CL=28309
 2009-05-05 16:53:46 -07:00
Russ Cox
9cba9c8890 6l: eliminate dead code, not just the symbols 
editing the firstp list was ineffective,
because follow rebuilds it from the textp list.

the symbols for dead code were being dropped
from the binary but the code was all still there.

text for fmt.Printf("hello, world\n") drops
from 143945 to 128650.

R=r,ken
DELTA=22  (20 added, 0 deleted, 2 changed)
OCL=28255
CL=28290
 2009-05-05 12:43:00 -07:00
Robert Griesemer
eea33fc69c better io.ByteBuffer implementation: 
- more light-weight
- better buffer management
- added test cases

R=r
DELTA=227  (167 added, 35 deleted, 25 changed)
OCL=28252
CL=28289
 2009-05-05 12:00:52 -07:00
Russ Cox
747e26166a fmt: dead code and data 
R=r
DELTA=10  (0 added, 10 deleted, 0 changed)
OCL=28258
CL=28287
 2009-05-05 11:24:03 -07:00
Rob Pike
2067b9fb92 string slicing is efficient so remove base and bounds arguments from RuneCountInString 
R=rsc
DELTA=6  (1 added, 0 deleted, 5 changed)
OCL=28242
CL=28256
 2009-05-04 22:12:13 -07:00
Ken Thompson
567a7bf664 more code optimization 
1. dont clear external and heap objects
2. propagate constant assignment

R=r
OCL=28254
CL=28254
 2009-05-04 21:48:46 -07:00
David Symonds
2f284948af Remake exvar package to be more Go-ish. 
It now exports a Var interface (anyone can export their own custom var types now), so users need to create and manage their own vars and mark them as exportable via the Publish function. They are exposed via /debug/vars.

R=r,rsc
APPROVED=r
DELTA=605  (314 added, 186 deleted, 105 changed)
OCL=28143
CL=28239
 2009-05-04 15:14:22 -07:00
Ken Thompson
5963f59067 more morestack fiddling 
R=r
OCL=28204
CL=28204
 2009-05-03 19:09:14 -07:00
Ken Thompson
a5a878986c more code fiddling 
R=r
OCL=28201
CL=28201
 2009-05-03 15:17:03 -07:00
David Symonds
fc51a98ffb Fix mismatched quote in a comment. 
R=gri
APPROVED=gri
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=28184
CL=28192
 2009-05-02 17:59:42 -07:00
Ken Thompson
49f7494894 code optmization 
drip init function if it doesnt do anything

R=r
OCL=28180
CL=28180
 2009-05-01 18:55:16 -07:00
Ken Thompson
1ed7f18165 code improvement 
better calling of morestack

R=r
OCL=28179
CL=28179
 2009-05-01 18:07:33 -07:00
Kai Backman
eac5db7f4c Copied 8g/6g into 5g. Used sharp tools to coax a .5 file out 
of 5g. 5l balks at the output and running 5g with -S shows
the true extent of the disaster. Still, better than
yesterday. Maybe.

Tested on the canonical:

package main
func main() {
}

R=rsc
APPROVED=rsc
DELTA=4182  (4181 added, 0 deleted, 1 changed)
OCL=27601
CL=28175
 2009-05-01 13:21:53 -07:00
Robert Griesemer
68523603e1 - incorporated feedback per rsc 
- fixed a bug and added corresponding test case

R=rsc
DELTA=114  (18 added, 29 deleted, 67 changed)
OCL=28114
CL=28128
 2009-04-30 14:43:06 -07:00
Russ Cox
83e976d53e bug146: array/slice conversion before I left missed conversions 
R=ken
OCL=28120
CL=28124
 2009-04-30 13:49:58 -07:00
Russ Cox
bd8e25ca57 auto-detect whether to use IPv6 or IPv4 kernel interface 
R=r
DELTA=12  (9 added, 0 deleted, 3 changed)
OCL=28096
CL=28118
 2009-04-30 13:41:36 -07:00
Russ Cox
10817ab9d2 better error messages, not that anyone ever sees them 
R=r
DELTA=30  (9 added, 1 deleted, 20 changed)
OCL=28104
CL=28117
 2009-04-30 13:40:55 -07:00
Russ Cox
48974f553d change 6l library directory flag to -L, 
to match traditional c linkers.

R=r
DELTA=42  (8 added, 12 deleted, 22 changed)
OCL=28101
CL=28115
 2009-04-30 13:32:39 -07:00
Rob Pike
5dc95206f2 don't print binary data. add TODO for better errors. 
TBR=rsc
DELTA=2  (1 added, 0 deleted, 1 changed)
OCL=28066
CL=28070
 2009-04-29 23:33:48 -07:00
Rob Pike
93831d25db rename variables for clarity. 
add test for structure alignment/offset.

R=gri
DELTA=49  (35 added, 0 deleted, 14 changed)
OCL=28068
CL=28068
 2009-04-29 22:16:53 -07:00
Russ Cox
89f8238a99 don't set CLONE_PTRACE -- it confuses strace 
R=r
DELTA=4  (3 added, 1 deleted, 0 changed)
OCL=28063
CL=28065
 2009-04-29 18:54:44 -07:00
Russ Cox
d2e42f3e48 if the process stops with SIGTRAP (breakpoint), 
don't relay the signal when restarting it.

R=r
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=28060
CL=28064
 2009-04-29 18:53:01 -07:00
Rob Pike
c0b8b969ae Bug in reflect found by gri. Structs in 6g have a minimum alignment. 
iant: will this be ok in gccgo?

R=rsc
DELTA=9  (8 added, 0 deleted, 1 changed)
OCL=28059
CL=28062
 2009-04-29 18:51:12 -07:00
Rob Pike
49eb63cfd5 drop unused result name - trivial change. 
R=rsc
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=28056
CL=28058
 2009-04-29 18:20:09 -07:00
Russ Cox
f7d3eb9db9 exit with error status EPIPE if 
one fd gets too many EPIPEs in a row
during write.

R=r
DELTA=10  (9 added, 0 deleted, 1 changed)
OCL=28057
CL=28057
 2009-04-29 18:18:42 -07:00
Brendan O'Dea
2cf5c809d0 Ignore SIGPIPE such that write returns EPIPE. 
Currently a http server will be killed on receipt of SIGPIPE
if a client closes a socket which the server is trying to
write to.

R=rsc
APPROVED=rsc
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=27959
CL=28055
 2009-04-29 17:36:58 -07:00
Brendan O'Dea
7326a389fc Fix channels used by WaitWrite (http server hangs on writes 
which hit EAGAIN).

R=rsc
APPROVED=rsc
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=27955
CL=28054
 2009-04-29 17:36:37 -07:00
Ken Thompson
7a98315c96 allow "defer close(chan)" 
bug found by anton

R=r
OCL=28001
CL=28001
 2009-04-28 17:20:18 -07:00
Ken Thompson
91ce0ef8f3 bug 139 
R=r
OCL=27987
CL=27987
 2009-04-28 13:52:56 -07:00
Ken Thompson
ad36c39211 bug 145 
R=r
OCL=27979
CL=27979
 2009-04-28 12:28:31 -07:00
Robert Griesemer
4fc82c2e1e fix for broken build 
TBR=r
DELTA=1  (0 added, 0 deleted, 1 changed)
OCL=27969
CL=27969
 2009-04-28 09:56:33 -07:00
David Symonds
a08fb0ff33 Add a HTTP handler to the exvar package. 
R=r
APPROVED=r
DELTA=20  (11 added, 6 deleted, 3 changed)
OCL=27782
CL=27950
 2009-04-28 04:26:07 -07:00
David Symonds
1304183efc Add more dependencies for lib/go. 
This makes "make nuke install" work again.

R=r
APPROVED=r
DELTA=2  (1 added, 0 deleted, 1 changed)
OCL=27929
CL=27932
 2009-04-27 21:52:30 -07:00
Rob Pike
bd3b2f843f implement .alternates 
R=rsc
OCL=27928
CL=27928
 2009-04-27 21:04:46 -07:00
Stephen Ma
eb5eea9a8f Fix the chunked encoding - terminate the chunk with CRLF. 
R=rsc
APPROVED=r
DELTA=11  (10 added, 0 deleted, 1 changed)
OCL=27723
CL=27879
 2009-04-27 00:38:04 -07:00
David Symonds
f4b92c8624 Add string-valued variables to exvar. 
R=r
APPROVED=r
DELTA=62  (58 added, 1 deleted, 3 changed)
OCL=27756
CL=27877
 2009-04-26 20:57:01 -07:00
Brendan O'Dea
68b881791f flags.Usage() calls fmt.Fprintf() with incorrect args 
R=r
APPROVED=r
DELTA=2  (0 added, 0 deleted, 2 changed)
OCL=27777
CL=27876
 2009-04-26 18:36:17 -07:00
Robert Griesemer
bf53e16f6d - install doc in lib/go 
- adjust dependent files

R=rsc
DELTA=1132  (567 added, 562 deleted, 3 changed)
OCL=27862
CL=27862
 2009-04-25 17:01:41 -07:00
Ken Thompson
b03b541b7a recognize a defined constant 
as a new name in a later declaration
(bug 144)

R=r
OCL=27850
CL=27850
 2009-04-24 16:43:31 -07:00
Robert Griesemer
9c3a9b71c8 - fixed a couple of potential end-less loops 
(no progress in presence of syntax errors)
- end parsing early if source doesn't start
  proper package clause

R=iant
DELTA=18  (7 added, 6 deleted, 5 changed)
OCL=27840
CL=27842
 2009-04-24 12:59:09 -07:00
Ben Eitzen
155ec1d904 Clear upper bits of 64-bit indexing register when using types smaller than 64 bits. 
APPROVED=ken
OCL=27811
CL=27823
 2009-04-23 18:23:34 -07:00
Rob Pike
258a08ed8f add {.tab} 
fix a couple of comments

TBR=rsc
OCL=27716
CL=27716
 2009-04-22 00:53:35 -07:00
David Symonds
d724092407 Clean up some more code after bug143 was fixed. 
R=r
APPROVED=r
DELTA=6  (0 added, 5 deleted, 1 changed)
OCL=27708
CL=27708
 2009-04-21 20:24:28 -07:00
Ken Thompson
190a540892 2 minor bugs. 
lv context for some [] operations
calling implicit(*map) before walk.

R=r
OCL=27706
CL=27706
 2009-04-21 19:52:13 -07:00
Ken Thompson
c18db5aa18 bug in shift of longer operand 
by a shorter operand. the bits
in the difference were not cheared.

R=r
OCL=27705
CL=27705
 2009-04-21 19:38:58 -07:00
David Symonds
f8931c6ceb Bug 143 is fixed, so clean up some of exvar. 
R=r
APPROVED=r
DELTA=8  (3 added, 1 deleted, 4 changed)
OCL=27699
CL=27701
 2009-04-21 18:36:53 -07:00
Ken Thompson
b5e7562191 supply default indirection to 
map indexing - bug 143

R=r
OCL=27695
CL=27695
 2009-04-21 17:00:08 -07:00
David Symonds
5cb6843a4e Change exvar to use a goroutine channel worker instead of a mutex for synchronisation. 
Also it should be more testable, as there's less global state.

R=r
APPROVED=r
DELTA=113  (38 added, 12 deleted, 63 changed)
OCL=27653
CL=27694
 2009-04-21 16:50:09 -07:00
Robert Griesemer
9c456283f3 minor adjustment to comment formatting for better godoc output 
R=r
DELTA=5  (0 added, 0 deleted, 5 changed)
OCL=27687
CL=27689
 2009-04-21 15:30:17 -07:00
Robert Griesemer
011bf2b6d3 minor adjustments to comments for better godoc output 
R=r
DELTA=6  (0 added, 0 deleted, 6 changed)
OCL=27686
CL=27688
 2009-04-21 15:14:34 -07:00
Robert Griesemer
3ae849d47d - documentation for bignum package 
- removed some constants from public interface

R=r
DELTA=375  (238 added, 14 deleted, 123 changed)
OCL=27636
CL=27668
 2009-04-21 10:52:00 -07:00
David Symonds
de489fb38c Refactor exvar to use interface types, and add mapVar. 
R=r
APPROVED=r
DELTA=170  (136 added, 6 deleted, 28 changed)
OCL=27628
CL=27652
 2009-04-20 22:38:14 -07:00
Rob Pike
a6bc344351 rewrite template library: 
- separate parsing from execution
	- rearrange code for organizational clarity
	- provide execution errors and parse-time errors
	- implement .or for repeated

TBR=rsc
OCL=27650
CL=27650
 2009-04-20 18:51:13 -07:00
David Symonds
8e4b65d041 Move iterable package to usr/dsymonds/. 
R=r
APPROVED=r
DELTA=598  (330 added, 266 deleted, 2 changed)
OCL=27627
CL=27649
 2009-04-20 18:13:14 -07:00
David Symonds
d88fb9f0f6 Oops, forgot to commit this change. 
R=r
APPROVED=r
DELTA=3  (1 added, 0 deleted, 2 changed)
OCL=27624
CL=27626
 2009-04-20 00:43:10 -07:00
David Symonds
dc5cffbeb7 Use the mutex in exvar.Set since map access is not atomic. 
Imagine your var has a value of zero. If you have a goroutine calling Set(5),
and another calling Increment(+1), then you only want one of these outcomes:
  - Set completes first, and then Increment occurs => 6
  - Increment completes first, and then Set occurs => 5

However, you could get a sequence:
  - read (for Increment) 0
  - set (for Set) 5
  - write (for Increment) 1
This results in a value of 1, which is undesirable.

Kudos to dnadasi for catching this.

R=r
APPROVED=r
DELTA=3  (3 added, 0 deleted, 0 changed)
OCL=27625
CL=27625
 2009-04-20 00:42:08 -07:00