3 Commits

Author	SHA1	Message	Date
Ian Cottrell	1249273038	internal/telemetry: make metrics take a strongly typed key ... Now that keys are solidly typed, we can use them for the metrics. This prevents accidentally using the wrong type of key, and allows us to use the typed accesorrs rather than the raw value. Change-Id: I553bd8e12128d3f00a3e926dbd3bfd420cd3f135 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225378 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-03-26 17:45:58 +00:00
Ian Cottrell	224c947ce5	internal/telemetry: replace TagSet with TagMap and TagPointer ... This separates the concerns of tag collections that have to be iterated and tag collections that need lookup by key. Also make it so that events just carry a plain slice of tags. We pass a TagMap down through the exporters and allow it to be extended on the way. We no longer need the event.Query method (or the event type) We now exclusivley use Key as the identity, and no longer have a common core implementation but just implement it directly in each type. This removes some confusion that was causing the same key through different paths to end up with a different identity. Change-Id: I61e47adcb397f4ca83dd90342b021dd8e9571ed3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/224278 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>	2020-03-25 01:00:44 +00:00
Ian Cottrell	8dcfad9e01	internal/telemetry: switch metrics to use the event system ... Change-Id: If036530ffe47e7df925bcf6592f664d6020a3d65 Reviewed-on: https://go-review.googlesource.com/c/tools/+/223997 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>	2020-03-23 14:44:30 +00:00