Yasuhiro Matsumoto
d6eada282e
misc/vim: "PACKAGE DOCUMENTATION" is not hilighted
...
R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/14018043
2013-09-27 12:57:09 +10:00
Yasuhiro Matsumoto
b128426804
misc/vim: godoc is optional. so should point installation instruction.
...
R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/14017043
2013-09-27 12:35:03 +10:00
Rob Pike
fa7791e922
all: fix some mistakes found by go tool vet .
...
R=golang-dev, iant, adg
CC=golang-dev
https://golang.org/cl/14000043
2013-09-27 10:09:15 +10:00
Andrew Gerrand
1f7c8a9aed
doc: update links to spec and memory model
...
Fixes #6488 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14004043
2013-09-27 09:46:36 +10:00
Adam Langley
f752484c74
crypto/tls: don't select TLS 1.2 cipher suites in prior versions.
...
AES-GCM cipher suites are only defined for TLS 1.2, although there's
nothing really version specific about them. However, development
versions of NSS (meaning Firefox and Chrome) have an issue where
they'll advertise TLS 1.2-only cipher suites in a TLS 1.1 ClientHello
but then balk when the server selects one.
This change causes Go clients not to advertise TLS 1.2 cipher suites
unless TLS 1.2 is being used, and prevents servers from selecting them
unless TLS 1.2 has been negotiated.
https://code.google.com/p/chromium/issues/detail?id=297151
https://bugzilla.mozilla.org/show_bug.cgi?id=919677
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13573047
2013-09-26 17:09:56 -04:00
Dave Cheney
649a2a9be5
runtime, syscall: update freebsd/arm calling convention to match EABI
...
Fixes #6451 .
There is still some breakages unrelated to the syscall change.
[root@beaglebone ~/go/src]# /root/go/pkg/tool/freebsd_arm/go_bootstrap version
go version devel freebsd/arm
a std@beaglebone ~/go/src]# /root/go/pkg/tool/freebsd_arm/go_bootstrap install -
fatal error: mark - finalizer inconsistency
runtime stack:
runtime.throw(0x3e80ac)
/root/go/src/pkg/runtime/panic.c:464 +0x5c
addfinroots(0x2)
/root/go/src/pkg/runtime/mgc0.c:1501 +0x74
runtime.walkfintab(0x6c200)
/root/go/src/pkg/runtime/mfinal.c:216 +0xa0
addroots()
/root/go/src/pkg/runtime/mgc0.c:1561 +0x188
gc(0x50632f78)
/root/go/src/pkg/runtime/mgc0.c:2098 +0x19c
mgc(0x306170a0)
/root/go/src/pkg/runtime/mgc0.c:2049 +0x30
runtime.mcall(0x3e97b0)
/root/go/src/pkg/runtime/asm_arm.s:165 +0x3c
goroutine 1 [garbage collection]:
runtime.gc(0x0)
/root/go/src/pkg/runtime/mgc0.c:2020 +0x1a0 fp=0x50632f80
runtime.mallocgc(0x680, 0x1b1971, 0x1)
/root/go/src/pkg/runtime/malloc.goc:143 +0x210 fp=0x50632fbc
----- stack segment boundary -----
cnew(0x1b1970, 0x640, 0x1)
/root/go/src/pkg/runtime/malloc.goc:718 +0xc4 fp=0x50626110
runtime.cnewarray(0x1b1970, 0x640)
/root/go/src/pkg/runtime/malloc.goc:731 +0x3c fp=0x50626120
makeslice1(0x1ac6d0, 0x500, 0x640, 0x50626190)
/root/go/src/pkg/runtime/slice.c:57 +0x50 fp=0x5062612c
growslice1(0x1ac6d0, 0x30714a00, 0x500, 0x500, 0x501, ...)
/root/go/src/pkg/runtime/slice.c:113 +0x8c fp=0x50626144
runtime.growslice(0x1ac6d0, 0x30714a00, 0x500, 0x500, 0x1, ...)
/root/go/src/pkg/runtime/slice.c:80 +0x19c fp=0x50626174
go/build.(*importReader).readByte(0x3070d1b0, 0xb384e)
/root/go/src/pkg/go/build/read.go:43 +0xbc fp=0x506261b4
go/build.(*importReader).peekByte(0x3070d1b0, 0x3070d101, 0x3070d180)
/root/go/src/pkg/go/build/read.go:89 +0x210 fp=0x506261d0
go/build.readComments(0x203e2560, 0x306f79a8, 0x306f79a8, 0x203e2560, 0x306f79a8, ...)
/root/go/src/pkg/go/build/read.go:194 +0x84 fp=0x506261f4
go/build.(*Context).matchFile(0x3e9730, 0x306209c0, 0x13, 0x306c42b4, 0x5, ...)
/root/go/src/pkg/go/build/build.go:812 +0x74c fp=0x5062629c
go/build.(*Context).Import(0x3e9730, 0x1f95c8, 0x1, 0x30620960, 0x13, ...)
/root/go/src/pkg/go/build/build.go:580 +0xd64 fp=0x506268dc
go/build.(*Context).ImportDir(0x3e9730, 0x30620960, 0x13, 0x0, 0x24d901, ...)
/root/go/src/pkg/go/build/build.go:397 +0x5c fp=0x50626904
main.func·021(0x30620960, 0x13, 0x203e2200, 0x30680330, 0x0, ...)
/root/go/src/cmd/go/main.go:521 +0x2cc fp=0x5062696c
path/filepath.walk(0x30620960, 0x13, 0x203e2200, 0x30680330, 0x50626ae8, ...)
/root/go/src/pkg/path/filepath/path.go:341 +0x5c fp=0x506269d8
path/filepath.walk(0x3067e720, 0x11, 0x203e2200, 0x30680210, 0x50626ae8, ...)
/root/go/src/pkg/path/filepath/path.go:359 +0x308 fp=0x50626a44
path/filepath.Walk(0x3067e720, 0x11, 0x50626ae8, 0x1f9728, 0x1)
/root/go/src/pkg/path/filepath/path.go:380 +0xb4 fp=0x50626a68
main.matchPackages(0xbfffedea, 0x3, 0x1b1190, 0x3067e600, 0x10)
/root/go/src/cmd/go/main.go:530 +0x2c0 fp=0x50626b1c
main.allPackages(0xbfffedea, 0x3, 0x1fadc8, 0x3, 0x1)
/root/go/src/cmd/go/main.go:474 +0x34 fp=0x50626b70
main.importPathsNoDotExpansion(0x30620018, 0x1, 0x1, 0x0, 0xffffffff, ...)
/root/go/src/cmd/go/main.go:305 +0x2f8 fp=0x50626c04
main.importPaths(0x30620018, 0x1, 0x1, 0x3, 0x0, ...)
/root/go/src/cmd/go/main.go:315 +0x44 fp=0x50626c88
main.packagesAndErrors(0x30620018, 0x1, 0x1, 0x50626d60, 0x90f44, ...)
/root/go/src/cmd/go/pkg.go:798 +0x1bc fp=0x50626d1c
main.packagesForBuild(0x30620018, 0x1, 0x1, 0x53490, 0x0, ...)
/root/go/src/cmd/go/pkg.go:818 +0x44 fp=0x50626dac
main.runInstall(0x3e46e0, 0x30620018, 0x1, 0x1)
/root/go/src/cmd/go/build.go:311 +0x48 fp=0x50626e60
main.main()
/root/go/src/cmd/go/main.go:161 +0x518 fp=0x50626f8c
runtime.main()
/root/go/src/pkg/runtime/proc.c:222 +0x100 fp=0x50626fc0
runtime.goexit()
/root/go/src/pkg/runtime/proc.c:1396 fp=0x50626fc0
goroutine 3 [syscall]:
os/signal.loop()
/root/go/src/pkg/os/signal/signal_unix.go:21 +0x24
created by os/signal.init·1
/root/go/src/pkg/os/signal/signal_unix.go:27 +0x48
R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/13824044
2013-09-26 21:35:49 +10:00
Shenghou Ma
752960aa5c
cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang
...
Fixes #6480 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13925043
2013-09-25 16:18:33 -04:00
Andrew Gerrand
bc0e51555c
doc: mention the install locations for godoc, cover, and vet
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13893043
2013-09-25 18:15:29 +10:00
Rob Pike
4be17b7a7e
doc/go1.2.html: add go/ast.SliceExpr.Slice3
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13877044
2013-09-25 16:17:54 +10:00
Andrew Gerrand
bc5e77fef9
doc: fix typo in install-source.html
...
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13892043
2013-09-25 14:27:23 +10:00
Andrew Gerrand
b3caa86f91
doc: document installation of go.tools commands
...
Fixes #5663 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13891043
2013-09-25 14:10:49 +10:00
Ian Lance Taylor
935a826a2f
cmd/cgo: fix so that tests pass again when using gccgo
...
Use the symbol prefixes with the prologue functions when using
gccgo.
Use an & when referring to a function declared as a variable.
Fix the malloc prologue function.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13878043
2013-09-24 18:11:13 -07:00
Rob Pike
e2e9d1d684
html/template: update the Tree field after parsing new templates
...
After text/template.Parse, all the templates may have changed, so
we need to set them all back to their unescaped state. The code
did this but (mea culpa) forgot to set the Tree field of the html/template
struct.
Since the Tree is reset during escaping, this only matters if an error
arises during escaping and we want to print a message.
Fixes #6459 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13877043
2013-09-25 10:00:09 +10:00
Robert Griesemer
20db0f428a
go/ast: add Slice3 field to SliceExpr
...
If Slice3 is set, the expression is
a 3-index slice expression (2 colons).
Required for type-checking.
Backward-compatible API extension.
R=r, rsc
CC=golang-dev
https://golang.org/cl/13826050
2013-09-24 16:35:35 -07:00
Kamil Kisiel
b0ef6aeff9
math/big: Fix variable name in documentation for *Int.Bytes and BitLen.
...
R=golang-dev, iant, gri
CC=golang-dev
https://golang.org/cl/13869043
2013-09-24 16:32:23 -07:00
Russ Cox
828a4b9376
sync/atomic: adjust for new runtime.cas64 prototype
...
R=golang-dev, minux.ma, josharian
CC=golang-dev
https://golang.org/cl/13859043
2013-09-24 15:54:48 -04:00
Russ Cox
5639d2754b
cmd/cgo: retain Go pointer passed to C call for duration of call
...
Fixes #6397 .
R=golang-dev, bradfitz, iant
CC=golang-dev
https://golang.org/cl/13858043
2013-09-24 15:52:48 -04:00
Shenghou Ma
7616c94921
cmd/dist, cmd/go: embed default C++ compiler into cmd/go
...
Fixes #6426 .
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/13704044
2013-09-24 00:17:08 -04:00
Alex Brainman
b80ef1ab48
net: re-enable raw socket tests on windows
...
Since CL 38bf89161a72 raw socket tests are not executed
on windows builders. This change re-enable them again.
It will attempt to run raw socket tests only if user
is permitted to create raw socket by OS.
Fixes #6392
R=golang-dev
CC=golang-dev, mikioh.mikioh, rsc
https://golang.org/cl/13422044
2013-09-24 13:15:49 +10:00
Brad Fitzpatrick
0f3ea75020
encoding/json: don't cache value addressability when building first encoder
...
newTypeEncoder (called once per type and then cached) was
looking at the first value seen of that type's addressability
and caching the encoder decision. If the first value seen was
addressable and a future one wasn't, it would panic.
Instead, introduce a new wrapper encoder type that checks
CanAddr at runtime.
Fixes #6458
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13839045
2013-09-23 19:57:19 -07:00
Russ Cox
e8bbbe0886
net: ensure that ResolveTCPAddr(addr.String()) reproduces addr
...
And same for UDP.
Fixes #6465 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13740048
2013-09-23 22:40:24 -04:00
Albert Strasheim
2be62360b2
net: fix Close of autobind unix listener
...
Fixes #6455 .
R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/13457058
2013-09-23 22:33:42 -04:00
Andrew Gerrand
2d2ae53119
reflect: update docs; Interface can return a method value
...
Fixes #6460 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13761046
2013-09-24 10:49:54 +10:00
Russ Cox
d9f034dc9e
net/http: accept Content-Range for entire file
...
Fixes a bug reported privately.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13846043
2013-09-23 17:16:59 -04:00
Dmitriy Vyukov
39361170d4
misc/pprof: support block profile
...
Fixes #6347 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13845044
2013-09-23 14:15:20 -07:00
Brad Fitzpatrick
547e4f9b2e
api: update next.txt
...
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13820046
2013-09-23 13:56:21 -07:00
Russ Cox
3c1ece2cb4
cmd/cgo: update #cgo docs to reflect reality
...
The syntax accepted is full build constraints, not just
GOOS, GOARCH, and GOOS/GOARCH.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/13504048
2013-09-23 16:29:53 -04:00
Russ Cox
05ff4d7a1a
runtime/pprof: fix profile parser in test
...
Fixes #6417 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13843043
2013-09-23 16:05:36 -04:00
Russ Cox
bc2c3388f4
crypto/tls: document that the package supports TLS 1.2
...
Fixes #6456 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13740047
2013-09-23 16:05:23 -04:00
Russ Cox
0fc9db7944
undo CL 13321048 / 9567c5da6e25
...
Makes build unnecessarily slower. Will fix the parser instead.
««« original CL description
runtime/pprof: run TestGoroutineSwitch for longer
Short test now takes about 0.5 second here.
Fixes #6417 .
The failure was also seen on our builders.
R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/13321048
»»»
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13720048
2013-09-23 15:58:35 -04:00
Kamil Kisiel
e07b5baf4f
reflect: add example for StructTag
...
Fix a few minor vet quibbles while I'm here.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13235059
2013-09-23 13:19:08 -04:00
Shenghou Ma
60513bf2f4
cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.
...
Fixes #6431 .
Change suggested by kin.wilson.za.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13314048
2013-09-23 13:08:00 -04:00
Péter Surányi
3861cb4388
go/build: add go1.2 build tag
...
Fixes #6449 .
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13829044
2013-09-23 18:11:25 +10:00
Rob Pike
3e3ed5d978
fmt: one bad index shouldn't spoil them all
...
In an indexed verb such as %[3]d, if the index is out of range, don't
skip processing the rest of the verbs. The bug was that the bad
index set a bit for the whole format instead of just the verb.
Ok for 1.2 because this is a bug in a 1.2 feature.
Fixes #6434
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13632058
2013-09-23 16:03:57 +10:00
Shenghou Ma
d00fb0a1ea
doc/go1.2: document that godoc and vet will always be installed to their old locations (not $GOPATH/bin).
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13830043
2013-09-23 01:23:42 -04:00
Andrew Gerrand
d851c6d478
doc: mention os/exec StdinPipe change in Go 1.2 doc
...
Fixes #6439 .
R=r, minux.ma
CC=golang-dev
https://golang.org/cl/13478045
2013-09-23 15:14:26 +10:00
Rob Pike
4977f9f926
doc/go1.2.html: fix 3-index slice example
...
A number was wrong; adjust as suggested to make things clearer.
Fixes #6452
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13422046
2013-09-23 14:41:20 +10:00
Dmitry Chestnykh
c2b7fb3902
net/http: send correct time in Date header.
...
Date header indicated that it contained GMT time,
however it actually sent local time. Fixed by
converting time to UTC.
Also fixes incorrect comment in appendTime().
Regression since CL 9432046.
R=golang-dev, dave, bradfitz
CC=golang-dev
https://golang.org/cl/13386047
2013-09-22 19:53:55 -07:00
ChaiShushan
e82031618a
misc/notepadplus: fix some number syntax highlight issue
...
notepadplus can only support some normal golang's hex and imaginary numbers.
it can't detect some special number, eg. 1./1.e/1.i/1+0.1i (omit "0" in ".0").
R=golang-dev, gvdschoot
CC=ajstarks, golang-dev
https://golang.org/cl/13401047
2013-09-23 11:35:17 +10:00
Andrew Gerrand
d4c7f04d71
A+C: Nathan John Youngman (individual CLA)
...
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/13819045
2013-09-23 09:35:52 +10:00
Dmitriy Vyukov
3ec600d0ca
runtime/race: update runtime to r191161.
...
Fixes #6305 .
R=golang-dev, dave, alex.brainman, r
CC=golang-dev
https://golang.org/cl/13359046
2013-09-22 10:56:06 -07:00
Alex Brainman
521dbbfef3
runtime/pprof: run TestGoroutineSwitch for longer
...
Short test now takes about 0.5 second here.
Fixes #6417 .
The failure was also seen on our builders.
R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/13321048
2013-09-22 17:31:08 +10:00
Brad Fitzpatrick
afda774e95
cmd/api: always do API check if hg is available
...
Fixes #6124
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/13500046
2013-09-22 08:01:17 +01:00
Dominik Honnef
f70116102b
doc/go1.2.html: Go 1.2, not Go1.2
...
R=r
CC=golang-dev
https://golang.org/cl/13735044
2013-09-22 07:28:52 +10:00
Rob Pike
e4c1fffcb1
doc/go1.2.html: pre-emption; cgo and C++
...
These were bullet points that I had neglected to flesh out.
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/13816043
2013-09-21 17:53:44 +10:00
Carl Shapiro
1c45f98fa3
test/chan: avoid wrap-around in memstats comparison
...
The select2.go test assumed that the memory allocated between
its two samplings of runtime.ReadMemStats is strictly
increasing. To avoid failing the tests when this is not true,
a greater-than check is introduced before computing the
difference in allocated memory.
R=golang-dev, r, cshapiro
CC=golang-dev
https://golang.org/cl/13701046
2013-09-20 17:27:56 -07:00
Russ Cox
0826c04e14
cmd/yacc: report correct line for 'default action causes potential type clash'
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/13588044
2013-09-20 16:00:13 -04:00
Russ Cox
8ce9a4fd26
test/run: print command line for running an individual test
...
Fixes #5087 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13812043
2013-09-20 15:25:59 -04:00
Russ Cox
5be1821a31
cmd/gc: fix imported and not used error for import .
...
Fixes issues 6420.
R=ken2
CC=golang-dev
https://golang.org/cl/13703044
2013-09-20 15:25:43 -04:00
Russ Cox
36f8480965
cmd/gc: print expression in 'duplicate case in switch' error
...
The line number alone does not help when the line is
case '~', '*', '(', ')', '[', ']', '{', '}', '?', ':', ';', ',', '*', '%', '^', '!', '=', '<', '>', '+', '-', '&', '|':
R=ken2
CC=golang-dev
https://golang.org/cl/13431046
2013-09-20 15:15:43 -04:00