193 Commits

Author	SHA1	Message	Date
Andrew Gerrand	5528211158	misc/dashboard/app: fix build failure notifications ... The datastore.Query methods once mutated the Query value, but now they return a derivative query, so the Hash= and ParentHash= filters were not being applied. R=golang-dev, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/6300058	2012-06-07 09:27:39 +10:00
David Symonds	935d8d16d4	misc/dashboard/codereview: handle abandoned CLs. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6257082	2012-06-01 10:55:55 +10:00
Andrew Gerrand	735ec94591	misc/dashboard/app: add debug logging to notifyOnFailure; remove unused Result.OK function ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6258064	2012-05-31 14:09:50 +10:00
Andrew Gerrand	023a7e881c	misc/dashboard/app: fix tests ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6244069	2012-05-31 14:09:24 +10:00
David Symonds	a90cbd741a	misc/dashboard/codereview: add sameer. ... R=r CC=golang-dev https://golang.org/cl/6203076	2012-05-15 08:38:05 +10:00
David Symonds	58bcec62c0	misc/dashboard/codereview: set In-Reply-To header to properly thread mail. ... R=adg CC=golang-dev https://golang.org/cl/6208051	2012-05-14 10:05:39 +10:00
David Symonds	c44a22cc49	misc/dashboard/codereview: remove transitional code. ... All current CLs have subject lines, so we don't need to check any more. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6196044	2012-05-04 16:40:24 +10:00
Andrew Gerrand	7a77645aa8	misc/dashboard/codereview: add copyright notices to Go files ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6177043	2012-05-03 09:22:45 +10:00
Rob Pike	ce30769ce3	misc/dashboard/codereview: LGTM favicon ... R=dsymonds CC=golang-dev https://golang.org/cl/6158043	2012-05-02 13:48:49 +10:00
David Symonds	cc9a5c3be7	misc/dashboard/codereview: preserve CL ordering. ... R=r CC=golang-dev https://golang.org/cl/6136056	2012-05-01 16:15:32 +10:00
David Symonds	83aa040c45	misc/dashboard/codereview: de-dup LGTMs. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6127066	2012-05-01 11:41:32 +10:00
David Symonds	dae2992c98	misc/dashboard/codereview: send mail immediately, and fill in time.Time fields. ... If we delay the mail sending, we can't send as the current user. If we don't fill in the time.Time fields, datastore.Put will fail because the zero time.Time value is out of its range. R=golang-dev, r CC=golang-dev https://golang.org/cl/6136053	2012-05-01 11:33:25 +10:00
David Symonds	1bdb788b2e	misc/dashboard/codereview: record Message-ID of code review thread mails. ... This will allow us to properly thread "R=..." mails at a later time. R=golang-dev, r CC=golang-dev https://golang.org/cl/6135053	2012-04-30 22:47:51 +10:00
David Symonds	5d331964e7	misc/dashboard/codereview: add handy logout URL. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6135052	2012-04-30 22:47:06 +10:00
David Symonds	4335ec9eeb	misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in. ... R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/6128054	2012-04-30 22:03:56 +10:00
David Symonds	24cce5c60c	misc/dashboard/codereview: don't depend on map iteration order for unit calculation. ... Fix auth requirements for /gc endpoint too. R=golang-dev, r CC=golang-dev https://golang.org/cl/6133049	2012-04-28 09:47:15 +10:00
David Symonds	fe252584f5	misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6128044	2012-04-27 23:16:54 +10:00
David Symonds	1a79053725	misc/dashboard/codereview: more abbreviated modification duration. ... R=golang-dev, r CC=golang-dev https://golang.org/cl/6131044	2012-04-27 17:12:09 +10:00
David Symonds	0175e3f1e0	misc/dashboard/codereview: new app. ... This is live at http://gocodereview.appspot.com/. R=golang-dev, r CC=golang-dev https://golang.org/cl/6134043	2012-04-27 16:36:02 +10:00
Andrew Gerrand	b6522c43d5	dashboard: sort user interface by internal counter, not date ... R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6114053	2012-04-25 13:01:08 -07:00
David Symonds	e6c5e2a363	misc/dashboard: cope with removed Package fields. ... adg removed some now-unwanted fields in Package a while ago, but there are still datastore entities with those fields, so we must explicitly check for ErrFieldMismatch and ignore it. R=golang-dev, rsc CC=adg, golang-dev https://golang.org/cl/6007043	2012-04-12 09:55:37 +10:00
Andrew Gerrand	48a76e13a5	misc/dashboard: set api_version to go1 ... R=golang-dev CC=golang-dev https://golang.org/cl/5952046	2012-04-03 08:10:51 +10:00
Shenghou Ma	a84056dabe	gobuilder: work with codereview plugin enabled in .hgrc ... Fixes #3312. R=golang-dev, adg CC=golang-dev https://golang.org/cl/5907065	2012-04-02 18:46:24 +08:00
Andrew Gerrand	c58163c572	misc/dashboard: remove remnants of package dashboard ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5847070	2012-03-20 13:35:31 +11:00
Andrew Gerrand	e9f82e6b68	misc/dashboard: remove old python package dashboard ... This leaves only the project page, which now resides at the web root. R=golang-dev, bsiegert, rsc CC=golang-dev https://golang.org/cl/5833044	2012-03-16 08:20:02 +11:00
Francisco Souza	235863cb12	doc: add "Godoc: documenting Go code" article ... Originally published on The Go Programming Language Blog, March 31, 2011. http://blog.golang.org/2011/03/godoc-documenting-go-code.html R=golang-dev, adg CC=golang-dev https://golang.org/cl/5830043	2012-03-15 14:51:44 +11:00
Robert Griesemer	56cae1c230	all: gofmt -w -s src misc ... R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5781058	2012-03-08 10:48:51 -08:00
Andrew Gerrand	52db02bef3	undo CL 5699082 / 6223c9fe432b ... We decided not to record installs, for now at least. ««« original CL description misc/dashboard: record install counts for external packages R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5699082 »»» R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5790044	2012-03-08 22:34:59 +11:00
Andrew Gerrand	8a146e707c	misc/dashboard: remove obsolete package builder code ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5790045	2012-03-08 21:54:46 +11:00
Shenghou Ma	d5f78d77c0	builder: use short test for subrepos ... R=rsc, golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5732053	2012-03-05 23:16:11 +08:00
Andrew Gerrand	2f4e5f79a6	gobuilder: send commit time in RFC3339 format ... R=golang-dev, gri CC=golang-dev https://golang.org/cl/5701063	2012-02-28 11:21:56 +11:00
Andrew Gerrand	2d6a6ed9fc	misc/dashboard: fix bug in UI template ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5700078	2012-02-27 16:18:58 +11:00
Andrew Gerrand	8421390cb9	misc/dashboard: record install counts for external packages ... R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5699082	2012-02-27 15:25:41 +11:00
Shenghou Ma	bb4a490928	builder: reuse existing workspace if possible ... R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/5690069	2012-02-22 15:39:53 -05:00
Brad Fitzpatrick	0427c583a5	builder: update for os.Wait changes. ... This compiles again. R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/5687078	2012-02-22 11:48:41 -08:00
Andrew Gerrand	92755f38ae	dashboard: rename buttons to satisfy pedantic souls ... R=golang-dev, r CC=golang-dev https://golang.org/cl/5686053	2012-02-21 17:13:14 +11:00
Brad Fitzpatrick	efacb2a1b4	os: remove Getenverror ... Fixes #3065 R=golang-dev, dsymonds, rsc CC=golang-dev https://golang.org/cl/5675094	2012-02-18 21:18:13 -08:00
David Symonds	e8edf84d81	dashboard: tidy up 'top' link. ... The previous link worked, but was unnecessary and had a trailing "}". R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5674068	2012-02-16 17:14:26 +11:00
Robert Griesemer	47afa4dba5	go/printer: don't lose relevant parentheses when rewriting selector expressions ... Also: Simplified handling of selector expressions. As a result, complicated multi-line expressions containing selectors and calls/indices with arguments broken accross lines don't get indented the same way as before, but the change is minimal (see tests) and there's no such code in the std library. It seems a worthwhile compromise given the much simpler code. Applied gofmt -w $GOROOT/src $GOROOT/misc . Fixes #1847. R=rsc CC=golang-dev https://golang.org/cl/5675062	2012-02-15 12:25:37 -08:00
Russ Cox	db93edfc28	builder: fix windows environment ... Not causing problems yet, but no need to keep using cygwin paths now that we're off cygwin. R=alex.brainman CC=golang-dev https://golang.org/cl/5656053	2012-02-14 01:23:25 -05:00
Alex Brainman	97235a769f	builder: really set $GOBUILDEXIT for Windows ... R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5649074	2012-02-13 14:32:45 +11:00
Russ Cox	0bc6836e81	builder: set $GOBUILDEXIT for Windows ... Actually %GOBUILDEXIT% I suppose. R=golang-dev CC=golang-dev https://golang.org/cl/5651058	2012-02-10 01:27:59 -05:00
Russ Cox	ee3e24f2d7	dashboard: add gobuilder -fail mode ... This is for filling a column with "fail", like I just did for Windows, when the builder would get stuck running that build. (We have safeguards against the tests getting stuck but this was the bootstrap build getting stuck.) I usually use -cmd=/bin/false, but this avoids the Mercurial checkouts, which means it runs instantly instead of requiring ~1 minute per "fail". R=golang-dev, adg CC=golang-dev https://golang.org/cl/5649049	2012-02-09 23:46:48 -05:00
Alex Brainman	947ea6f750	gobuilder: fix windows builder ... Do not rewrite commands if they have .bash extnsion. Use path/filepath to manipulate file paths everywhere. Use all.bat on windows, not all.bash. Use HOMEDRIVE/HOMEPATH to find .gobuildkey on windows. R=rsc CC=golang-dev https://golang.org/cl/5630062	2012-02-09 14:52:01 +11:00
Andrew Gerrand	22185aed74	dashboard: update to go1beta ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5624056	2012-02-06 09:26:32 +11:00
Andrew Gerrand	aa716e36a6	dashboard: don't send failing Go commits as todos for subrepos ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5608044	2012-02-03 14:03:46 +11:00
Russ Cox	2050a9e478	build: remove Make.pkg, Make.tool ... Consequently, remove many package Makefiles, and shorten the few that remain. gomake becomes 'go tool make'. Turn off test phases of run.bash that do not work, flagged with $BROKEN. Future CLs will restore these, but this seemed like a big enough CL already. R=golang-dev, r CC=golang-dev https://golang.org/cl/5601057	2012-01-30 23:43:46 -05:00
Andrew Gerrand	1f5f457ba3	dashboard: better ui layout for subrepo status ... R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5595048	2012-01-31 12:09:56 +11:00
Andrew Gerrand	0f2659a323	builder: drop recover blocks ... The one time they recovered from anything they obscured a useful stack trace. We're better off just crashing hard. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5577073	2012-01-30 14:53:48 +11:00
Andrew Gerrand	faa1bf04fd	dashboard: ask builders to re-build Go tip to freshen subrepos ... This ensures we always have results for subrepo-tip at go-tip. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5569091	2012-01-30 14:50:36 +11:00