qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 08:27:56 -07:00
Code Releases Activity

[dev.typeparams] cmd/compile: set sym.Def to ir.Name for method value wrappers

Browse Source 
The code for generating method value wrappers is weird that it sets
sym.Def to the generated ir.Func, whereas normally sym.Def points to
ir.Name.

While here, change methodValueWrapper to return the ir.Name too, since
that's what the caller wants.

Change-Id: I3da5320ca0bf4d32d7b420345454f19075d19a26
Reviewed-on: https://go-review.googlesource.com/c/go/+/339410
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Matthew Dempsky 2021-08-03 10:37:33 -07:00
parent 656f0888b7
commit fe73f28dc5
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/noder/reader.go
View File

@ -2253,7 +2253,7 @@ func (r *reader) methodValueWrapper(tbase *types.Type, method *types.Field, targ
pos := base.AutogeneratedPos pos := base.AutogeneratedPos
fn := r.newWrapperFunc(pos, sym, nil, method) fn := r.newWrapperFunc(pos, sym, nil, method)
sym.Def = fn sym.Def = fn.Nname
// Declare and initialize variable holding receiver. // Declare and initialize variable holding receiver.
recv := ir.NewHiddenParam(pos, fn, typecheck.Lookup(".this"), recvType) recv := ir.NewHiddenParam(pos, fn, typecheck.Lookup(".this"), recvType)

12
src/cmd/compile/internal/walk/closure.go
View File

@ -179,7 +179,7 @@ func walkMethodValue(n *ir.SelectorExpr, init *ir.Nodes) ir.Node {
clos := ir.NewCompLitExpr(base.Pos, ir.OCOMPLIT, ir.TypeNode(typ), nil) clos := ir.NewCompLitExpr(base.Pos, ir.OCOMPLIT, ir.TypeNode(typ), nil)
clos.SetEsc(n.Esc()) clos.SetEsc(n.Esc())
clos.List = []ir.Node{ir.NewUnaryExpr(base.Pos, ir.OCFUNC, methodValueWrapper(n).Nname), n.X} clos.List = []ir.Node{ir.NewUnaryExpr(base.Pos, ir.OCFUNC, methodValueWrapper(n)), n.X}
addr := typecheck.NodAddr(clos) addr := typecheck.NodAddr(clos)
addr.SetEsc(n.Esc()) addr.SetEsc(n.Esc())
@ -199,11 +199,11 @@ func walkMethodValue(n *ir.SelectorExpr, init *ir.Nodes) ir.Node {
return walkExpr(cfn, init) return walkExpr(cfn, init)
} }
// methodValueWrapper returns the DCLFUNC node representing the // methodValueWrapper returns the ONAME node representing the
// wrapper function (*-fm) needed for the given method value. If the // wrapper function (*-fm) needed for the given method value. If the
// wrapper function hasn't already been created yet, it's created and // wrapper function hasn't already been created yet, it's created and
// added to typecheck.Target.Decls. // added to typecheck.Target.Decls.
func methodValueWrapper(dot *ir.SelectorExpr) *ir.Func { func methodValueWrapper(dot *ir.SelectorExpr) *ir.Name {
if dot.Op() != ir.OMETHVALUE { if dot.Op() != ir.OMETHVALUE {
base.Fatalf("methodValueWrapper: unexpected %v (%v)", dot, dot.Op()) base.Fatalf("methodValueWrapper: unexpected %v (%v)", dot, dot.Op())
} }
@ -214,7 +214,7 @@ func methodValueWrapper(dot *ir.SelectorExpr) *ir.Func {
sym := ir.MethodSymSuffix(rcvrtype, meth, "-fm") sym := ir.MethodSymSuffix(rcvrtype, meth, "-fm")
if sym.Uniq() { if sym.Uniq() {
return sym.Def.(*ir.Func) return sym.Def.(*ir.Name)
} }
sym.SetUniq(true) sym.SetUniq(true)
@ -262,10 +262,10 @@ func methodValueWrapper(dot *ir.SelectorExpr) *ir.Func {
// typecheckslice() requires that Curfn is set when processing an ORETURN. // typecheckslice() requires that Curfn is set when processing an ORETURN.
ir.CurFunc = fn ir.CurFunc = fn
typecheck.Stmts(fn.Body) typecheck.Stmts(fn.Body)
sym.Def = fn sym.Def = fn.Nname
typecheck.Target.Decls = append(typecheck.Target.Decls, fn) typecheck.Target.Decls = append(typecheck.Target.Decls, fn)
ir.CurFunc = savecurfn ir.CurFunc = savecurfn
base.Pos = saveLineNo base.Pos = saveLineNo
return fn return fn.Nname
} }