qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 12:40:11 -07:00
Code Releases Activity

net: don't check LookupHost error in TestLookupNullByte

Browse Source 
net.LookupHost("foo\x00bar") may resolve successfully on some networks.
Reduce the scope of the test to check only that the call doesn't panic.

Also update the test comment to reference the relevant issue.

Fixes #37031
Updates #31597

Change-Id: If175deed8121625ef507598c6145e937ccffd89e
Reviewed-on: https://go-review.googlesource.com/c/go/+/217729
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Dmitri Shuralyov 2020-02-04 19:41:48 -05:00
parent f770366f6d
commit fb93cd45a6
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/net/lookup_test.go
View File

@ -1179,12 +1179,9 @@ func TestWithUnexpiredValuesPreserved(t *testing.T) {
} }
} }
// Issue 31586: don't crash on null byte in name // Issue 31597: don't panic on null byte in name
func TestLookupNullByte(t *testing.T) { func TestLookupNullByte(t *testing.T) {
testenv.MustHaveExternalNetwork(t) testenv.MustHaveExternalNetwork(t)
testenv.SkipFlakyNet(t) testenv.SkipFlakyNet(t)
_, err := LookupHost("foo\x00bar") // used to crash on Windows LookupHost("foo\x00bar") // check that it doesn't panic; it used to on Windows
if err == nil {
t.Errorf("unexpected success")
}
} }