qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 21:54:40 -07:00
Code Releases Activity

bytes: don't use an iota for the readOp constants

Browse Source 
As per the comments in golang.org/cl/78617. Also leaving a comment here,
to make sure noone else thinks to re-introduce the iota like I did.

Change-Id: I2a2275998b81896eaa0e9d5ee0197661ebe84acf
Reviewed-on: https://go-review.googlesource.com/78676
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Daniel Martí 2017-11-19 13:40:05 +00:00 committed by Brad Fitzpatrick
parent e4a3043d1d
commit f91ab6c025
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/bytes/buffer.go
View File

@ -30,13 +30,15 @@ type Buffer struct {
// converted to int they correspond to the rune size that was read. // converted to int they correspond to the rune size that was read.
type readOp int8 type readOp int8
// Don't use iota for these, as the values need to correspond with the
// names and comments, which is easier to see when being explicit.
const ( const (
opRead readOp = iota - 1 // Any other read operation. opRead readOp = -1 // Any other read operation.
opInvalid // Non-read operation. opInvalid readOp = 0 // Non-read operation.
opReadRune1 // Read rune of size 1. opReadRune1 readOp = 1 // Read rune of size 1.
opReadRune2 // Read rune of size 2. opReadRune2 readOp = 2 // Read rune of size 2.
opReadRune3 // Read rune of size 3. opReadRune3 readOp = 3 // Read rune of size 3.
opReadRune4 // Read rune of size 4. opReadRune4 readOp = 4 // Read rune of size 4.
) )
// ErrTooLarge is passed to panic if memory cannot be allocated to store data in a buffer. // ErrTooLarge is passed to panic if memory cannot be allocated to store data in a buffer.