qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-02 06:28:33 -06:00
Code Releases Activity

[dev.cc] cmd/asm: accept #define A /* nothing */

Browse Source 
Was rejected but should be legal.

Change-Id: I0189e3bef6b67c6ba390c75a48a8d9d8f39b7636
Reviewed-on: https://go-review.googlesource.com/5286
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Rob Pike 2015-02-19 12:57:33 -08:00
parent d7eb51e70e
commit f60fb5c5ad
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/asm/internal/lex/input.go
View File

@ -206,7 +206,7 @@ func (in *Input) macroDefinition(name string) ([]string, []Token) {
prevCol := in.Stack.Col() prevCol := in.Stack.Col()
tok := in.Stack.Next() tok := in.Stack.Next()
if tok == '\n' || tok == scanner.EOF { if tok == '\n' || tok == scanner.EOF {
in.Error("no definition for macro:", name) return nil, nil // No definition for macro
} }
var args []string var args []string
// The C preprocessor treats // The C preprocessor treats

5
src/cmd/asm/internal/lex/lex_test.go
View File

@ -36,6 +36,11 @@ var lexTests = []lexTest{
), ),
"1234.\n", "1234.\n",
}, },
{
"define without value",
"#define A",
"",
},
{ {
"macro without arguments", "macro without arguments",
"#define A() 1234\n" + "A()\n", "#define A() 1234\n" + "A()\n",