qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-23 15:20:13 -06:00
Code Releases Activity

refactor setting canPanic

Browse Source
This commit is contained in:
Derek Parker 2023-05-08 14:13:42 -07:00
parent aa8ec88ccc
commit f57ee07d05
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/compile/internal/compare/compare.go
View File

@ -173,7 +173,6 @@ func EqStruct(t *types.Type, np, nq ir.Node) ([]ir.Node, bool) {
// The conditions are a list-of-lists. Conditions are reorderable
// within each inner list. The outer lists must be evaluated in order.
var conds [][]ir.Node
var canPanic bool
conds = append(conds, []ir.Node{})
and := func(n ir.Node) {
i := len(conds) - 1
@ -192,9 +191,6 @@ func EqStruct(t *types.Type, np, nq ir.Node) ([]ir.Node, bool) {
}
typeCanPanic := EqCanPanic(f.Type)
if !canPanic {
canPanic = typeCanPanic
}
// Compare non-memory fields with field equality.
if !IsRegularMemory(f.Type) {
@ -247,7 +243,7 @@ func EqStruct(t *types.Type, np, nq ir.Node) ([]ir.Node, bool) {
})
flatConds = append(flatConds, c...)
}
return flatConds, canPanic
return flatConds, len(conds) > 1
}
// EqString returns the nodes