qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 16:24:28 -06:00
Code Releases Activity

net/http: deflake TestIssue4191_InfiniteGetTimeout

Browse Source 
This test exercises the case where a net.Conn error occurs while
writing a response body. It injects an error by setting a timeout
on the Conn. If this timeout expires before response headers are
written, the test fails. The test attempts to recover from this
failure by extending the timeout and retrying.

Set the timeout after the response headers are removed, and
remove the retry loop.

Fixes #56274.

Change-Id: I293f8bedb7b20a21d14f43ea9bb48fc56b59441c
Reviewed-on: https://go-review.googlesource.com/c/go/+/452175
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
This commit is contained in:
Damien Neil 2022-11-18 14:10:50 -08:00
parent c6cdfd88c7
commit f4f8397fed
1 changed files with 14 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/net/http/transport_test.go
View File

@ -2224,57 +2224,37 @@ func testTransportConcurrency(t *testing.T, mode testMode) {
func TestIssue4191_InfiniteGetTimeout(t *testing.T) { run(t, testIssue4191_InfiniteGetTimeout) }
func testIssue4191_InfiniteGetTimeout(t *testing.T, mode testMode) {
const debug = false
mux := NewServeMux()
mux.HandleFunc("/get", func(w ResponseWriter, r *Request) {
io.Copy(w, neverEnding('a'))
})
ts := newClientServerTest(t, mode, mux).ts
timeout := 100 * time.Millisecond
connc := make(chan net.Conn, 1)
c := ts.Client()
c.Transport.(*Transport).Dial = func(n, addr string) (net.Conn, error) {
conn, err := net.Dial(n, addr)
if err != nil {
return nil, err
}
conn.SetDeadline(time.Now().Add(timeout))
if debug {
conn = NewLoggingConn("client", conn)
select {
case connc <- conn:
default:
}
return conn, nil
}
getFailed := false
nRuns := 5
if testing.Short() {
nRuns = 1
res, err := c.Get(ts.URL + "/get")
if err != nil {
t.Fatalf("Error issuing GET: %v", err)
}
for i := 0; i < nRuns; i++ {
if debug {
println("run", i+1, "of", nRuns)
}
sres, err := c.Get(ts.URL + "/get")
if err != nil {
if !getFailed {
// Make the timeout longer, once.
getFailed = true
t.Logf("increasing timeout")
i--
timeout *= 10
continue
}
t.Errorf("Error issuing GET: %v", err)
break
}
_, err = io.Copy(io.Discard, sres.Body)
if err == nil {
t.Errorf("Unexpected successful copy")
break
}
}
if debug {
println("tests complete; waiting for handlers to finish")
defer res.Body.Close()
conn := <-connc
conn.SetDeadline(time.Now().Add(1 * time.Millisecond))
_, err = io.Copy(io.Discard, res.Body)
if err == nil {
t.Errorf("Unexpected successful copy")
}
}