From f4748f1e218c3584348f2f5c297e73f494182e54 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Fri, 16 Sep 2016 17:15:12 -0400 Subject: [PATCH] cmd/dist: skip libgcc test on arm64 and mips64 This test was always being run with external linking on these platforms because the linker was silently forcing external linking until CL 28971. Now it produces an error instead. Change-Id: I794e0812711e05b150daf805dc3451507bb4cae8 Reviewed-on: https://go-review.googlesource.com/29360 Run-TryBot: David Crawshaw Reviewed-by: Keith Randall TryBot-Result: Gobot Gobot --- src/cmd/dist/test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 779140f446..b56289d854 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -420,8 +420,10 @@ func (t *tester) registerTests() { break } - // Darwin/Android ARM64 fails with internal linking. - if (t.goos == "darwin" || t.goos == "android") && t.goarch == "arm64" { + // Internally linking cgo is incomplete on some architectures. + // https://golang.org/issue/10373 + // https://golang.org/issue/14449 + if t.goarch == "arm64" || t.goarch == "mips64" { break }