qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 03:04:42 -07:00
Code Releases Activity

debug/dwarf, encoding/asn1, go/ast: fix old comments

Browse Source 
The debug/dwarf and encoding/asn1 examples were added in 2009, a few
months before Go added implicit semicolons, and never updated.

The go/ast node types have always been named just "Expr", "Stmt", and
"Decl", so the comments about "ExprNode", "StmtNode", and "DeclNode"
were likely just mistaken because the interface tag methods are
"exprNode", "stmtNode", and "declNode", respectively.

Change-Id: I9d138cc3a16c1a51453da1406914d7b320bf6270
Reviewed-on: https://go-review.googlesource.com/7980
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Matthew Dempsky 2015-03-23 15:28:51 -07:00 committed by Brad Fitzpatrick
parent 717cb74907
commit f1878c0d46
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/debug/dwarf/entry.go
View File

@ -112,7 +112,7 @@ type Field struct {
// //
// A common idiom is to merge the check for nil return with // A common idiom is to merge the check for nil return with
// the check that the value has the expected dynamic type, as in: // the check that the value has the expected dynamic type, as in:
// v, ok := e.Val(AttrSibling).(int64); // v, ok := e.Val(AttrSibling).(int64)
// //
func (e *Entry) Val(a Attr) interface{} { func (e *Entry) Val(a Attr) interface{} {
for _, f := range e.Field { for _, f := range e.Field {

2
src/encoding/asn1/marshal.go
View File

@ -18,7 +18,7 @@ import (
// A forkableWriter is an in-memory buffer that can be // A forkableWriter is an in-memory buffer that can be
// 'forked' to create new forkableWriters that bracket the // 'forked' to create new forkableWriters that bracket the
// original. After // original. After
// pre, post := w.fork(); // pre, post := w.fork()
// the overall sequence of bytes represented is logically w+pre+post. // the overall sequence of bytes represented is logically w+pre+post.
type forkableWriter struct { type forkableWriter struct {
*bytes.Buffer *bytes.Buffer

6
src/go/ast/ast.go
View File

@ -486,7 +486,7 @@ func (x *MapType) End() token.Pos { return x.Value.End() }
func (x *ChanType) End() token.Pos { return x.Value.End() } func (x *ChanType) End() token.Pos { return x.Value.End() }
// exprNode() ensures that only expression/type nodes can be // exprNode() ensures that only expression/type nodes can be
// assigned to an ExprNode. // assigned to an Expr.
// //
func (*BadExpr) exprNode() {} func (*BadExpr) exprNode() {}
func (*Ident) exprNode() {} func (*Ident) exprNode() {}
@ -787,7 +787,7 @@ func (s *ForStmt) End() token.Pos { return s.Body.End() }
func (s *RangeStmt) End() token.Pos { return s.Body.End() } func (s *RangeStmt) End() token.Pos { return s.Body.End() }
// stmtNode() ensures that only statement nodes can be // stmtNode() ensures that only statement nodes can be
// assigned to a StmtNode. // assigned to a Stmt.
// //
func (*BadStmt) stmtNode() {} func (*BadStmt) stmtNode() {}
func (*DeclStmt) stmtNode() {} func (*DeclStmt) stmtNode() {}
@ -951,7 +951,7 @@ func (d *FuncDecl) End() token.Pos {
} }
// declNode() ensures that only declaration nodes can be // declNode() ensures that only declaration nodes can be
// assigned to a DeclNode. // assigned to a Decl.
// //
func (*BadDecl) declNode() {} func (*BadDecl) declNode() {}
func (*GenDecl) declNode() {} func (*GenDecl) declNode() {}