qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 16:04:48 -07:00
Code Releases Activity

runtime: flush assist credit on goroutine exit

Browse Source 
Currently dead goroutines retain their assist credit. This credit can
be used if the goroutine gets recycled, but in general this can make
assist pacing over-aggressive by hiding an amount of credit
proportional to the number of exited (and not reused) goroutines.

Fix this "hidden credit" by flushing assist credit to the global
credit pool when a goroutine exits.

Updates #14812.

Change-Id: I65f7f75907ab6395c04aacea2c97aea963b60344
Reviewed-on: https://go-review.googlesource.com/24703
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rick Hudson <rlh@golang.org>
This commit is contained in:
Austin Clements 2016-07-01 11:31:04 -04:00
parent 86cd9c1176
commit f10d99f51d
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/runtime/proc.go
View File

@ -2671,6 +2671,15 @@ func goexit0(gp *g) {
gp.labels = nil gp.labels = nil
gp.timer = nil gp.timer = nil
if gcBlackenEnabled != 0 && gp.gcAssistBytes > 0 {
// Flush assist credit to the global pool. This gives
// better information to pacing if the application is
// rapidly creating an exiting goroutines.
scanCredit := int64(gcController.assistWorkPerByte * float64(gp.gcAssistBytes))
atomic.Xaddint64(&gcController.bgScanCredit, scanCredit)
gp.gcAssistBytes = 0
}
// Note that gp's stack scan is now "valid" because it has no // Note that gp's stack scan is now "valid" because it has no
// stack. // stack.
gp.gcscanvalid = true gp.gcscanvalid = true