qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 08:50:14 -07:00
Code Releases Activity

go/parser: permit parentheses in receiver types

Browse Source 
Pending acceptance of CL 101500044
and adjustment of test/fixedbugs/bug299.go.

LGTM=adonovan
R=golang-codereviews, adonovan
CC=golang-codereviews
https://golang.org/cl/110160043
This commit is contained in:
Robert Griesemer 2014-06-26 09:45:11 -07:00
parent 89f185fe8a
commit ef639b0936
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkg/go/parser/parser.go
View File

@ -2310,9 +2310,9 @@ func (p *parser) parseReceiver(scope *ast.Scope) *ast.FieldList {
return par
}
// recv type must be of the form ["*"] identifier
// recv type must be of the form ["*"] identifier, possibly using parentheses
recv := par.List[0]
base := deref(recv.Type)
base := unparen(deref(unparen(recv.Type)))
if _, isIdent := base.(*ast.Ident); !isIdent {
if _, isBad := base.(*ast.BadExpr); !isBad {
// only report error if it's a new one

3
src/pkg/go/parser/short_test.go
View File

@ -35,6 +35,9 @@ var valids = []string{
`package p; func f() { for _ = range "foo" + "bar" {} };`,
`package p; func f() { var s []int; g(s[:], s[i:], s[:j], s[i:j], s[i:j:k], s[:j:k]) };`,
`package p; var ( _ = (struct {*T}).m; _ = (interface {T}).m )`,
`package p; func ((T),) m() {}`,
`package p; func ((*T),) m() {}`,
`package p; func (*(T),) m() {}`,
}
func TestValid(t *testing.T) {