From eea5a432cb629670522dc2903d3c464b58652fee Mon Sep 17 00:00:00 2001 From: Andrew Balholm Date: Fri, 20 Apr 2012 15:48:13 +1000 Subject: [PATCH] exp/html: start making inBodyIM match the spec Reorder some start tags. Improve handling of . Handle . Pass 2 additional tests (by handling ). R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/6082043 --- src/pkg/exp/html/parse.go | 56 ++++++++++++---------- src/pkg/exp/html/testlogs/tests15.dat.log | 2 +- src/pkg/exp/html/testlogs/webkit01.dat.log | 2 +- 3 files changed, 33 insertions(+), 27 deletions(-) diff --git a/src/pkg/exp/html/parse.go b/src/pkg/exp/html/parse.go index b5ee425747..780b47a27a 100644 --- a/src/pkg/exp/html/parse.go +++ b/src/pkg/exp/html/parse.go @@ -640,6 +640,29 @@ func inBodyIM(p *parser) bool { switch p.tok.Data { case "html": copyAttributes(p.oe[0], p.tok) + case "base", "basefont", "bgsound", "command", "link", "meta", "noframes", "script", "style", "title": + return inHeadIM(p) + case "body": + if len(p.oe) >= 2 { + body := p.oe[1] + if body.Type == ElementNode && body.Data == "body" { + p.framesetOK = false + copyAttributes(body, p.tok) + } + } + case "frameset": + if !p.framesetOK || len(p.oe) < 2 || p.oe[1].Data != "body" { + // Ignore the token. + return true + } + body := p.oe[1] + if body.Parent != nil { + body.Parent.Remove(body) + } + p.oe = p.oe[:1] + p.addElement(p.tok.Data, p.tok.Attr) + p.im = inFramesetIM + return true case "address", "article", "aside", "blockquote", "center", "details", "dir", "div", "dl", "fieldset", "figcaption", "figure", "footer", "header", "hgroup", "menu", "nav", "ol", "p", "section", "summary", "ul": p.popUntil(buttonScope, "p") p.addElement(p.tok.Data, p.tok.Attr) @@ -758,29 +781,6 @@ func inBodyIM(p *parser) bool { } p.reconstructActiveFormattingElements() p.addElement(p.tok.Data, p.tok.Attr) - case "body": - if len(p.oe) >= 2 { - body := p.oe[1] - if body.Type == ElementNode && body.Data == "body" { - p.framesetOK = false - copyAttributes(body, p.tok) - } - } - case "frameset": - if !p.framesetOK || len(p.oe) < 2 || p.oe[1].Data != "body" { - // Ignore the token. - return true - } - body := p.oe[1] - if body.Parent != nil { - body.Parent.Remove(body) - } - p.oe = p.oe[:1] - p.addElement(p.tok.Data, p.tok.Attr) - p.im = inFramesetIM - return true - case "base", "basefont", "bgsound", "command", "link", "meta", "noframes", "script", "style", "title": - return inHeadIM(p) case "image": p.tok.Data = "img" return false @@ -847,8 +847,14 @@ func inBodyIM(p *parser) bool { case EndTagToken: switch p.tok.Data { case "body": - // TODO: autoclose the stack of open elements. - p.im = afterBodyIM + if p.elementInScope(defaultScope, "body") { + p.im = afterBodyIM + } + case "html": + if p.elementInScope(defaultScope, "body") { + p.parseImpliedToken(EndTagToken, "body", nil) + return false + } return true case "p": if !p.elementInScope(buttonScope, "p") { diff --git a/src/pkg/exp/html/testlogs/tests15.dat.log b/src/pkg/exp/html/testlogs/tests15.dat.log index ddaae4041c..d8ff9dd205 100644 --- a/src/pkg/exp/html/testlogs/tests15.dat.log +++ b/src/pkg/exp/html/testlogs/tests15.dat.log @@ -2,7 +2,7 @@ PASS "

X" PASS "

\n

X" PASS " " PASS "" -FAIL "" +PASS "" PASS "X" PASS " X
" PASS " x
" diff --git a/src/pkg/exp/html/testlogs/webkit01.dat.log b/src/pkg/exp/html/testlogs/webkit01.dat.log index 5cdf79345a..088684bc0c 100644 --- a/src/pkg/exp/html/testlogs/webkit01.dat.log +++ b/src/pkg/exp/html/testlogs/webkit01.dat.log @@ -21,7 +21,7 @@ PASS "
" PASS "
" PASS "" PASS "x" -FAIL "x" +PASS "x" PASS "x" FAIL "

xx
" FAIL "
xx
"