From ecc7dd546998ad0b68e9055876db1ec82facca4b Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Sat, 21 Sep 2019 16:22:50 +0530 Subject: [PATCH] test/codegen: fix wasm codegen breakage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit i32.eqz instructions don't appear unless needed in if conditions anymore after CL 195204. I forgot to run the codegen tests while submitting the CL. Thanks to @martisch for catching it. Fixes #34442 Change-Id: I177b064b389be48e39d564849714d7a8839be13e Reviewed-on: https://go-review.googlesource.com/c/go/+/196580 Run-TryBot: Agniva De Sarker TryBot-Result: Gobot Gobot Reviewed-by: Martin Möhrmann --- test/codegen/comparisons.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/codegen/comparisons.go b/test/codegen/comparisons.go index 123199feee..c020ea8eb7 100644 --- a/test/codegen/comparisons.go +++ b/test/codegen/comparisons.go @@ -215,34 +215,34 @@ func CmpLogicalToZero(a, b, c uint32, d, e uint64) uint64 { // ppc64:"ANDCC",-"CMPW" // ppc64le:"ANDCC",-"CMPW" - // wasm:"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" + // wasm:"I64Eqz",-"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" if a&63 == 0 { return 1 } // ppc64:"ANDCC",-"CMP" // ppc64le:"ANDCC",-"CMP" - // wasm:"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" + // wasm:"I64Eqz",-"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" if d&255 == 0 { return 1 } // ppc64:"ANDCC",-"CMP" // ppc64le:"ANDCC",-"CMP" - // wasm:"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" + // wasm:"I64Eqz",-"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" if d&e == 0 { return 1 } // ppc64:"ORCC",-"CMP" // ppc64le:"ORCC",-"CMP" - // wasm:"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" + // wasm:"I64Eqz",-"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" if d|e == 0 { return 1 } // ppc64:"XORCC",-"CMP" // ppc64le:"XORCC",-"CMP" - // wasm:"I32Eqz",-"I64ExtendI32U",-"I32WrapI64" + // wasm:"I64Eqz","I32Eqz",-"I64ExtendI32U",-"I32WrapI64" if e^d == 0 { return 1 }