qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 06:47:58 -07:00
Code Releases Activity

cmd/go: disable fuzz instrumentation for internal/godebug

Browse Source 
This is thought to be the cause of certain recent longtest failures.
Let's try it out.

This appears to fix the longtests fuzz failures. I suspect that the
sync.Map in internal/godebug is at fault with the implementation
changing. I'm not sure yet exactly why this is a problem, maybe inlining
that didn't happen before? I don't know exactly when coverage
instrumentation happens in the compiler, but this is definitely the
problem.

For good measure, let's add internal/sync. If sync is on the list,
internal/sync should be, too.

Fixes #70429.
Fixes #70430.
Fixes #70431.

Change-Id: Ic9f49daa0956e3a50192bcc7778983682b5d12b8
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/629475
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Anthony Knyszek 2024-11-18 22:23:43 +00:00 committed by Michael Knyszek
parent 79c0041daf
commit ec7824b6bb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/test/test.go
View File

@ -933,7 +933,9 @@ func runTest(ctx context.Context, cmd *base.Command, args []string) {
var skipInstrumentation = map[string]bool{ var skipInstrumentation = map[string]bool{
"context": true, "context": true,
"internal/fuzz": true, "internal/fuzz": true,
"internal/godebug": true,
"internal/runtime/maps": true, "internal/runtime/maps": true,
"internal/sync": true,
"reflect": true, "reflect": true,
"runtime": true, "runtime": true,
"sync": true, "sync": true,