From eb68c4af092aff2efa20f5fca92e674307784739 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 11 Nov 2019 16:30:35 -0500 Subject: [PATCH] cmd/link: disable a DWARF testpoint on Windows pending investigation Disable a portion of the TestDWARF testpoint for Windows using c-archive buildmode, pending investigation of the issue at hand, so as to get the longtest builder unblocked. Updates #35512. Change-Id: Ib72d82ceaa674b9a51da220fb8e225231d5c3433 Reviewed-on: https://go-review.googlesource.com/c/go/+/206557 Run-TryBot: Than McIntosh Reviewed-by: Jeremy Faller --- src/cmd/link/dwarf_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/cmd/link/dwarf_test.go b/src/cmd/link/dwarf_test.go index f33082e7f72..db9f384e7fd 100644 --- a/src/cmd/link/dwarf_test.go +++ b/src/cmd/link/dwarf_test.go @@ -139,6 +139,13 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string) } } + // Until there is a fix for issue 35512, don't try to use + // SeekPC or look at the line table on Windows under + // c-archive build mode. + if buildmode == "c-archive" && runtime.GOOS == "windows" { + t.Skip("avoiding SeekPC until 35512 fixed") + } + // TODO: We'd like to use filepath.Join here. // Also related: golang.org/issue/19784. wantFile := path.Join(prog, "main.go")