mirror of
https://github.com/golang/go
synced 2024-11-18 11:44:45 -07:00
runtime: require gdb version 7.9 for gdb test
Issue 11214 reports problems with older versions of gdb. It does work with gdb 7.9 on my Ubuntu Trusty system, so take that as the minimum required version. Fixes #11214. Change-Id: I61b732895506575be7af595f81fc1bcf696f58c2 Reviewed-on: https://go-review.googlesource.com/12626 Reviewed-by: Austin Clements <austin@google.com>
This commit is contained in:
parent
d23973d23c
commit
eb248c4df2
@ -9,6 +9,7 @@ import (
|
|||||||
"path/filepath"
|
"path/filepath"
|
||||||
"regexp"
|
"regexp"
|
||||||
"runtime"
|
"runtime"
|
||||||
|
"strconv"
|
||||||
"testing"
|
"testing"
|
||||||
)
|
)
|
||||||
|
|
||||||
@ -22,6 +23,23 @@ func checkGdbPython(t *testing.T) {
|
|||||||
if string(out) != "go gdb python support\n" {
|
if string(out) != "go gdb python support\n" {
|
||||||
t.Skipf("skipping due to lack of python gdb support: %s", out)
|
t.Skipf("skipping due to lack of python gdb support: %s", out)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Issue 11214 reports various failures with older versions of gdb.
|
||||||
|
out, err = exec.Command("gdb", "--version").CombinedOutput()
|
||||||
|
re := regexp.MustCompile(`([0-9]+)\.([0-9]+)`)
|
||||||
|
matches := re.FindSubmatch(out)
|
||||||
|
if len(matches) < 3 {
|
||||||
|
t.Skipf("skipping: can't determine gdb version from\n%s\n", out)
|
||||||
|
}
|
||||||
|
major, err1 := strconv.Atoi(string(matches[1]))
|
||||||
|
minor, err2 := strconv.Atoi(string(matches[2]))
|
||||||
|
if err1 != nil || err2 != nil {
|
||||||
|
t.Skipf("skipping: can't determine gdb version: %v, %v", err1, err2)
|
||||||
|
}
|
||||||
|
if major < 7 || (major == 7 && minor < 7) {
|
||||||
|
t.Skipf("skipping: gdb version %d.%d too old", major, minor)
|
||||||
|
}
|
||||||
|
t.Logf("gdb version %d.%d", major, minor)
|
||||||
}
|
}
|
||||||
|
|
||||||
const helloSource = `
|
const helloSource = `
|
||||||
|
Loading…
Reference in New Issue
Block a user