1
0
mirror of https://github.com/golang/go synced 2024-09-30 16:08:36 -06:00

runtime: prevent GC from seeing the contents of a frame in runfinq

This holds the last finalized object and arguments to its finalizer.
Fixes #5348.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/11454044
This commit is contained in:
Dmitriy Vyukov 2013-07-19 18:01:33 +04:00
parent e242562506
commit eb04df75cd

View File

@ -2274,7 +2274,11 @@ runfinq(void)
framesz = sizeof(uintptr) + f->nret;
if(framecap < framesz) {
runtime·free(frame);
frame = runtime·mal(framesz);
// The frame does not contain pointers interesting for GC,
// all not yet finalized objects are stored in finc.
// If we do not mark it as FlagNoPointers,
// the last finalized object is not collected.
frame = runtime·mallocgc(framesz, FlagNoPointers, 0, 1);
framecap = framesz;
}
*(void**)frame = f->arg;