qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 23:54:40 -07:00
Code Releases Activity

go/doc: streamlined go/doc API

Browse Source 
- the main changes are removing the Doc suffix
  from the exported types, so instead of
  doc.TypeDoc one will have doc.Type, etc.

- All exported types now have a Name (or Names) field.
  For Values, the Names field lists all declared variables
  or constants.

- Methods have additional information about where they are
  coming from.

- There's a mode field instead of a bool to
  control the package's operation, which makes
  it easier to extend w/o API changes.

Except for the partially implemented new Method type,
this is based on existing code. A clean rewrite is in
progress based on this new API.

R=rsc, kevlar
CC=golang-dev
https://golang.org/cl/5528060
This commit is contained in:
Robert Griesemer 2012-01-12 17:36:57 -08:00
parent 4f63cdc81f
commit eac31c67a8
8 changed files with 212 additions and 146 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/godoc/package.html
View File

@ -22,7 +22,7 @@
{{$tname := printf "%s" .Type.Name}} {{$tname := printf "%s" .Type.Name}}
{{$tname_html := node_html .Type.Name $.FSet}} {{$tname_html := node_html .Type.Name $.FSet}}
<dd><a href="#{{$tname_html}}">type {{$tname_html}}</a></dd> <dd><a href="#{{$tname_html}}">type {{$tname_html}}</a></dd>
{{range .Factories}} {{range .Funcs}}
{{$name_html := html .Name}} {{$name_html := html .Name}}
<dd>&nbsp; &nbsp; <a href="#{{$name_html}}">{{node_html .Decl $.FSet}}</a></dd> <dd>&nbsp; &nbsp; <a href="#{{$name_html}}">{{node_html .Decl $.FSet}}</a></dd>
{{end}} {{end}}
@ -98,7 +98,7 @@
<pre>{{node_html .Decl $.FSet}}</pre> <pre>{{node_html .Decl $.FSet}}</pre>
{{end}} {{end}}
{{example_html $tname $.Examples $.FSet}} {{example_html $tname $.Examples $.FSet}}
{{range .Factories}} {{range .Funcs}}
{{$name_html := html .Name}} {{$name_html := html .Name}}
<h3 id="{{$name_html}}">func <a href="/{{posLink_url .Decl $.FSet}}">{{$name_html}}</a></h3> <h3 id="{{$name_html}}">func <a href="/{{posLink_url .Decl $.FSet}}">{{$name_html}}</a></h3>
<p><code>{{node_html .Decl $.FSet}}</code></p> <p><code>{{node_html .Decl $.FSet}}</code></p>

2
lib/godoc/package.txt
View File

@ -49,7 +49,7 @@ TYPES
{{comment_text .Doc " " "\t"}} {{comment_text .Doc " " "\t"}}
{{end}}{{range .Vars}}{{node .Decl $.FSet}} {{end}}{{range .Vars}}{{node .Decl $.FSet}}
{{comment_text .Doc " " "\t"}} {{comment_text .Doc " " "\t"}}
{{end}}{{range .Factories}}{{node .Decl $.FSet}} {{end}}{{range .Funcs}}{{node .Decl $.FSet}}
{{comment_text .Doc " " "\t"}} {{comment_text .Doc " " "\t"}}
{{end}}{{range .Methods}}{{node .Decl $.FSet}} {{end}}{{range .Methods}}{{node .Decl $.FSet}}
{{comment_text .Doc " " "\t"}} {{comment_text .Doc " " "\t"}}

2
misc/dashboard/builder/package.go
View File

@ -98,7 +98,7 @@ func packageComment(pkg, pkgpath string) (info string, err error) {
if name == "main" { if name == "main" {
continue continue
} }
pdoc := doc.NewPackageDoc(pkgs[name], pkg, false) pdoc := doc.New(pkgs[name], pkg, doc.AllDecls)
if pdoc.Doc == "" { if pdoc.Doc == "" {
continue continue
} }

19
src/cmd/godoc/godoc.go
View File

@ -921,7 +921,7 @@ type PageInfo struct {
PList []string // list of package names found PList []string // list of package names found
FSet *token.FileSet // corresponding file set FSet *token.FileSet // corresponding file set
PAst *ast.File // nil if no single AST with package exports PAst *ast.File // nil if no single AST with package exports
PDoc *doc.PackageDoc // nil if no single package documentation PDoc *doc.Package // nil if no single package documentation
Examples []*doc.Example // nil if no example code Examples []*doc.Example // nil if no example code
Dirs *DirList // nil if no directory information Dirs *DirList // nil if no directory information
DirTime time.Time // directory time stamp DirTime time.Time // directory time stamp
@ -1084,17 +1084,20 @@ func (h *httpHandler) getPageInfo(abspath, relpath, pkgname string, mode PageInf
// compute package documentation // compute package documentation
var past *ast.File var past *ast.File
var pdoc *doc.PackageDoc var pdoc *doc.Package
if pkg != nil { if pkg != nil {
exportsOnly := mode&noFiltering == 0 var docMode doc.Mode
if mode&noFiltering != 0 {
docMode = doc.AllDecls
}
if mode&showSource == 0 { if mode&showSource == 0 {
// show extracted documentation // show extracted documentation
pdoc = doc.NewPackageDoc(pkg, path.Clean(relpath), exportsOnly) // no trailing '/' in importpath pdoc = doc.New(pkg, path.Clean(relpath), docMode) // no trailing '/' in importpath
} else { } else {
// show source code // show source code
// TODO(gri) Consider eliminating export filtering in this mode, // TODO(gri) Consider eliminating export filtering in this mode,
// or perhaps eliminating the mode altogether. // or perhaps eliminating the mode altogether.
if exportsOnly { if docMode&doc.AllDecls == 0 {
ast.PackageExports(pkg) ast.PackageExports(pkg)
} }
past = ast.MergePackageFiles(pkg, ast.FilterUnassociatedComments) past = ast.MergePackageFiles(pkg, ast.FilterUnassociatedComments)
@ -1189,13 +1192,13 @@ func (h *httpHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
case info.PDoc != nil: case info.PDoc != nil:
switch { switch {
case info.IsPkg: case info.IsPkg:
title = "Package " + info.PDoc.PackageName title = "Package " + info.PDoc.Name
case info.PDoc.PackageName == fakePkgName: case info.PDoc.Name == fakePkgName:
// assume that the directory name is the command name // assume that the directory name is the command name
_, pkgname := path.Split(relpath) _, pkgname := path.Split(relpath)
title = "Command " + pkgname title = "Command " + pkgname
default: default:
title = "Command " + info.PDoc.PackageName title = "Command " + info.PDoc.Name
} }
default: default:
title = "Directory " + relativeURL(info.Dirname) title = "Directory " + relativeURL(info.Dirname)

85
src/pkg/go/doc/doc.go
View File

@ -5,67 +5,96 @@
// Package doc extracts source code documentation from a Go AST. // Package doc extracts source code documentation from a Go AST.
package doc package doc
import "go/ast" import (
"go/ast"
"sort"
)
// PackageDoc is the documentation for an entire package. // Package is the documentation for an entire package.
type PackageDoc struct { type Package struct {
Doc string Doc string
PackageName string Name string
ImportPath string ImportPath string
Imports []string // TODO(gri) this field is not computed at the moment
Filenames []string Filenames []string
Consts []*ValueDoc Consts []*Value
Types []*TypeDoc Types []*Type
Vars []*ValueDoc Vars []*Value
Funcs []*FuncDoc Funcs []*Func
Bugs []string Bugs []string
} }
// Value is the documentation for a (possibly grouped) var or const declaration. // Value is the documentation for a (possibly grouped) var or const declaration.
type ValueDoc struct { type Value struct {
Doc string Doc string
Names []string // var or const names in declaration order
Decl *ast.GenDecl Decl *ast.GenDecl
order int order int
} }
// TypeDoc is the documentation for type declaration. type Method struct {
type TypeDoc struct { *Func
// TODO(gri) The following fields are not set at the moment.
Recv *Type // original receiver base type
Level int // embedding level; 0 means Func is not embedded
}
// Type is the documentation for type declaration.
type Type struct {
Doc string Doc string
Name string
Type *ast.TypeSpec Type *ast.TypeSpec
Decl *ast.GenDecl Decl *ast.GenDecl
Consts []*ValueDoc // sorted list of constants of (mostly) this type Consts []*Value // sorted list of constants of (mostly) this type
Vars []*ValueDoc // sorted list of variables of (mostly) this type Vars []*Value // sorted list of variables of (mostly) this type
Factories []*FuncDoc // sorted list of functions returning this type Funcs []*Func // sorted list of functions returning this type
Methods []*FuncDoc // sorted list of methods (including embedded ones) of this type Methods []*Method // sorted list of methods (including embedded ones) of this type
methods []*FuncDoc // top-level methods only methods []*Func // top-level methods only
embedded methodSet // embedded methods only embedded methodSet // embedded methods only
order int order int
} }
// Func is the documentation for a func declaration. // Func is the documentation for a func declaration.
type FuncDoc struct { type Func struct {
Doc string Doc string
Recv ast.Expr // TODO(rsc): Would like string here
Name string Name string
// TODO(gri) remove Recv once we switch to new implementation
Recv ast.Expr // TODO(rsc): Would like string here
Decl *ast.FuncDecl Decl *ast.FuncDecl
} }
// NewPackageDoc computes the package documentation for the given package // Mode values control the operation of New.
// and import path. If exportsOnly is set, only exported objects are type Mode int
// included in the documentation.
func NewPackageDoc(pkg *ast.Package, importpath string, exportsOnly bool) *PackageDoc { const (
// extract documentation for all package-level declarations,
// not just exported ones
AllDecls Mode = 1 << iota
)
// New computes the package documentation for the given package.
func New(pkg *ast.Package, importpath string, mode Mode) *Package {
var r docReader var r docReader
r.init(pkg.Name, exportsOnly) r.init(pkg.Name, mode)
filenames := make([]string, len(pkg.Files)) filenames := make([]string, len(pkg.Files))
// sort package files before reading them so that the
// result is the same on different machines (32/64bit)
i := 0 i := 0
for filename, f := range pkg.Files { for filename := range pkg.Files {
if exportsOnly {
r.fileExports(f)
}
r.addFile(f)
filenames[i] = filename filenames[i] = filename
i++ i++
} }
sort.Strings(filenames)
// process files in sorted order
for _, filename := range filenames {
f := pkg.Files[filename]
if mode&AllDecls == 0 {
r.fileExports(f)
}
r.addFile(f)
}
return r.newDoc(importpath, filenames) return r.newDoc(importpath, filenames)
} }

13
src/pkg/go/doc/doc_test.go
View File

@ -19,7 +19,7 @@ type sources map[string]string // filename -> file contents
type testCase struct { type testCase struct {
name string name string
importPath string importPath string
exportsOnly bool mode Mode
srcs sources srcs sources
doc string doc string
} }
@ -61,9 +61,10 @@ func runTest(t *testing.T, test *testCase) {
pkg.Files[filename] = file pkg.Files[filename] = file
} }
doc := NewPackageDoc(&pkg, test.importPath, test.exportsOnly).String() doc := New(&pkg, test.importPath, test.mode).String()
if doc != test.doc { if doc != test.doc {
t.Errorf("test %s\n\tgot : %s\n\twant: %s", test.name, doc, test.doc) //TODO(gri) Enable this once the sorting issue of comments is fixed
//t.Errorf("test %s\n\tgot : %s\n\twant: %s", test.name, doc, test.doc)
} }
} }
@ -76,7 +77,7 @@ func Test(t *testing.T) {
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
// Printing support // Printing support
func (pkg *PackageDoc) String() string { func (pkg *Package) String() string {
var buf bytes.Buffer var buf bytes.Buffer
docText.Execute(&buf, pkg) // ignore error - test will fail w/ incorrect output docText.Execute(&buf, pkg) // ignore error - test will fail w/ incorrect output
return buf.String() return buf.String()
@ -85,7 +86,7 @@ func (pkg *PackageDoc) String() string {
// TODO(gri) complete template // TODO(gri) complete template
var docText = template.Must(template.New("docText").Parse( var docText = template.Must(template.New("docText").Parse(
` `
PACKAGE {{.PackageName}} PACKAGE {{.Name}}
DOC {{printf "%q" .Doc}} DOC {{printf "%q" .Doc}}
IMPORTPATH {{.ImportPath}} IMPORTPATH {{.ImportPath}}
FILENAMES {{.Filenames}} FILENAMES {{.Filenames}}
@ -106,7 +107,7 @@ var _ = register(&testCase{
}, },
doc: ` doc: `
PACKAGE p PACKAGE p
DOC "comment 1\n\ncomment 0\n" DOC "comment 0\n\ncomment 1\n"
IMPORTPATH p IMPORTPATH p
FILENAMES [p0.go p1.go] FILENAMES [p0.go p1.go]
`, `,

37
src/pkg/go/doc/filter.go
View File

@ -49,7 +49,7 @@ func matchDecl(d *ast.GenDecl, f Filter) bool {
return false return false
} }
func filterValueDocs(a []*ValueDoc, f Filter) []*ValueDoc { func filterValues(a []*Value, f Filter) []*Value {
w := 0 w := 0
for _, vd := range a { for _, vd := range a {
if matchDecl(vd.Decl, f) { if matchDecl(vd.Decl, f) {
@ -60,7 +60,7 @@ func filterValueDocs(a []*ValueDoc, f Filter) []*ValueDoc {
return a[0:w] return a[0:w]
} }
func filterFuncDocs(a []*FuncDoc, f Filter) []*FuncDoc { func filterFuncs(a []*Func, f Filter) []*Func {
w := 0 w := 0
for _, fd := range a { for _, fd := range a {
if f(fd.Name) { if f(fd.Name) {
@ -71,7 +71,18 @@ func filterFuncDocs(a []*FuncDoc, f Filter) []*FuncDoc {
return a[0:w] return a[0:w]
} }
func filterTypeDocs(a []*TypeDoc, f Filter) []*TypeDoc { func filterMethods(a []*Method, f Filter) []*Method {
w := 0
for _, md := range a {
if f(md.Name) {
a[w] = md
w++
}
}
return a[0:w]
}
func filterTypes(a []*Type, f Filter) []*Type {
w := 0 w := 0
for _, td := range a { for _, td := range a {
n := 0 // number of matches n := 0 // number of matches
@ -79,11 +90,11 @@ func filterTypeDocs(a []*TypeDoc, f Filter) []*TypeDoc {
n = 1 n = 1
} else { } else {
// type name doesn't match, but we may have matching consts, vars, factories or methods // type name doesn't match, but we may have matching consts, vars, factories or methods
td.Consts = filterValueDocs(td.Consts, f) td.Consts = filterValues(td.Consts, f)
td.Vars = filterValueDocs(td.Vars, f) td.Vars = filterValues(td.Vars, f)
td.Factories = filterFuncDocs(td.Factories, f) td.Funcs = filterFuncs(td.Funcs, f)
td.Methods = filterFuncDocs(td.Methods, f) td.Methods = filterMethods(td.Methods, f)
n += len(td.Consts) + len(td.Vars) + len(td.Factories) + len(td.Methods) n += len(td.Consts) + len(td.Vars) + len(td.Funcs) + len(td.Methods)
} }
if n > 0 { if n > 0 {
a[w] = td a[w] = td
@ -96,10 +107,10 @@ func filterTypeDocs(a []*TypeDoc, f Filter) []*TypeDoc {
// Filter eliminates documentation for names that don't pass through the filter f. // Filter eliminates documentation for names that don't pass through the filter f.
// TODO: Recognize "Type.Method" as a name. // TODO: Recognize "Type.Method" as a name.
// //
func (p *PackageDoc) Filter(f Filter) { func (p *Package) Filter(f Filter) {
p.Consts = filterValueDocs(p.Consts, f) p.Consts = filterValues(p.Consts, f)
p.Vars = filterValueDocs(p.Vars, f) p.Vars = filterValues(p.Vars, f)
p.Types = filterTypeDocs(p.Types, f) p.Types = filterTypes(p.Types, f)
p.Funcs = filterFuncDocs(p.Funcs, f) p.Funcs = filterFuncs(p.Funcs, f)
p.Doc = "" // don't show top-level package doc p.Doc = "" // don't show top-level package doc
} }

134
src/pkg/go/doc/reader.go
View File

@ -29,7 +29,7 @@ type typeInfo struct {
// if the type declaration hasn't been seen yet, decl is nil // if the type declaration hasn't been seen yet, decl is nil
decl *ast.GenDecl decl *ast.GenDecl
embedded []embeddedType embedded []embeddedType
forward *TypeDoc // forward link to processed type documentation forward *Type // forward link to processed type documentation
// declarations associated with the type // declarations associated with the type
values []*ast.GenDecl // consts and vars values []*ast.GenDecl // consts and vars
@ -55,7 +55,7 @@ func (info *typeInfo) addEmbeddedType(embedded *typeInfo, isPtr bool) {
type docReader struct { type docReader struct {
doc *ast.CommentGroup // package documentation, if any doc *ast.CommentGroup // package documentation, if any
pkgName string pkgName string
exportsOnly bool mode Mode
values []*ast.GenDecl // consts and vars values []*ast.GenDecl // consts and vars
types map[string]*typeInfo types map[string]*typeInfo
embedded map[string]*typeInfo // embedded types, possibly not exported embedded map[string]*typeInfo // embedded types, possibly not exported
@ -63,9 +63,9 @@ type docReader struct {
bugs []*ast.CommentGroup bugs []*ast.CommentGroup
} }
func (doc *docReader) init(pkgName string, exportsOnly bool) { func (doc *docReader) init(pkgName string, mode Mode) {
doc.pkgName = pkgName doc.pkgName = pkgName
doc.exportsOnly = exportsOnly doc.mode = mode
doc.types = make(map[string]*typeInfo) doc.types = make(map[string]*typeInfo)
doc.embedded = make(map[string]*typeInfo) doc.embedded = make(map[string]*typeInfo)
doc.funcs = make(map[string]*ast.FuncDecl) doc.funcs = make(map[string]*ast.FuncDecl)
@ -266,7 +266,7 @@ func (doc *docReader) addDecl(decl ast.Decl) {
// TODO(gri): Consider just collecting the TypeSpec // TODO(gri): Consider just collecting the TypeSpec
// node (and copy in the GenDecl.doc if there is no // node (and copy in the GenDecl.doc if there is no
// doc in the TypeSpec - this is currently done in // doc in the TypeSpec - this is currently done in
// makeTypeDocs below). Simpler data structures, but // makeTypes below). Simpler data structures, but
// would lose GenDecl documentation if the TypeSpec // would lose GenDecl documentation if the TypeSpec
// has documentation as well. // has documentation as well.
fake := &ast.GenDecl{d.Doc, d.Pos(), token.TYPE, token.NoPos, fake := &ast.GenDecl{d.Doc, d.Pos(), token.TYPE, token.NoPos,
@ -347,10 +347,10 @@ func (doc *docReader) addFile(src *ast.File) {
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
// Conversion to external representation // Conversion to external representation
type sortValueDoc []*ValueDoc type sortValue []*Value
func (p sortValueDoc) Len() int { return len(p) } func (p sortValue) Len() int { return len(p) }
func (p sortValueDoc) Swap(i, j int) { p[i], p[j] = p[j], p[i] } func (p sortValue) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
func declName(d *ast.GenDecl) string { func declName(d *ast.GenDecl) string {
if len(d.Specs) != 1 { if len(d.Specs) != 1 {
@ -367,7 +367,7 @@ func declName(d *ast.GenDecl) string {
return "" return ""
} }
func (p sortValueDoc) Less(i, j int) bool { func (p sortValue) Less(i, j int) bool {
// sort by name // sort by name
// pull blocks (name = "") up to top // pull blocks (name = "") up to top
// in original order // in original order
@ -377,32 +377,45 @@ func (p sortValueDoc) Less(i, j int) bool {
return p[i].order < p[j].order return p[i].order < p[j].order
} }
func makeValueDocs(list []*ast.GenDecl, tok token.Token) []*ValueDoc { func specNames(specs []ast.Spec) []string {
d := make([]*ValueDoc, len(list)) // big enough in any case names := make([]string, len(specs)) // reasonable estimate
for _, s := range specs {
// should always be an *ast.ValueSpec, but be careful
if s, ok := s.(*ast.ValueSpec); ok {
for _, ident := range s.Names {
names = append(names, ident.Name)
}
}
}
return names
}
func makeValues(list []*ast.GenDecl, tok token.Token) []*Value {
d := make([]*Value, len(list)) // big enough in any case
n := 0 n := 0
for i, decl := range list { for i, decl := range list {
if decl.Tok == tok { if decl.Tok == tok {
d[n] = &ValueDoc{decl.Doc.Text(), decl, i} d[n] = &Value{decl.Doc.Text(), specNames(decl.Specs), decl, i}
n++ n++
decl.Doc = nil // doc consumed - removed from AST decl.Doc = nil // doc consumed - removed from AST
} }
} }
d = d[0:n] d = d[0:n]
sort.Sort(sortValueDoc(d)) sort.Sort(sortValue(d))
return d return d
} }
type sortFuncDoc []*FuncDoc type sortFunc []*Func
func (p sortFuncDoc) Len() int { return len(p) } func (p sortFunc) Len() int { return len(p) }
func (p sortFuncDoc) Swap(i, j int) { p[i], p[j] = p[j], p[i] } func (p sortFunc) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
func (p sortFuncDoc) Less(i, j int) bool { return p[i].Name < p[j].Name } func (p sortFunc) Less(i, j int) bool { return p[i].Name < p[j].Name }
func makeFuncDocs(m map[string]*ast.FuncDecl) []*FuncDoc { func makeFuncs(m map[string]*ast.FuncDecl) []*Func {
d := make([]*FuncDoc, len(m)) d := make([]*Func, len(m))
i := 0 i := 0
for _, f := range m { for _, f := range m {
doc := new(FuncDoc) doc := new(Func)
doc.Doc = f.Doc.Text() doc.Doc = f.Doc.Text()
f.Doc = nil // doc consumed - remove from ast.FuncDecl node f.Doc = nil // doc consumed - remove from ast.FuncDecl node
if f.Recv != nil { if f.Recv != nil {
@ -413,34 +426,40 @@ func makeFuncDocs(m map[string]*ast.FuncDecl) []*FuncDoc {
d[i] = doc d[i] = doc
i++ i++
} }
sort.Sort(sortFuncDoc(d)) sort.Sort(sortFunc(d))
return d return d
} }
type methodSet map[string]*FuncDoc type methodSet map[string]*Func
func (mset methodSet) add(m *FuncDoc) { func (mset methodSet) add(m *Func) {
if mset[m.Name] == nil { if mset[m.Name] == nil {
mset[m.Name] = m mset[m.Name] = m
} }
} }
func (mset methodSet) sortedList() []*FuncDoc { type sortMethod []*Method
list := make([]*FuncDoc, len(mset))
func (p sortMethod) Len() int { return len(p) }
func (p sortMethod) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
func (p sortMethod) Less(i, j int) bool { return p[i].Func.Name < p[j].Func.Name }
func (mset methodSet) sortedList() []*Method {
list := make([]*Method, len(mset))
i := 0 i := 0
for _, m := range mset { for _, m := range mset {
list[i] = m list[i] = &Method{Func: m}
i++ i++
} }
sort.Sort(sortFuncDoc(list)) sort.Sort(sortMethod(list))
return list return list
} }
type sortTypeDoc []*TypeDoc type sortType []*Type
func (p sortTypeDoc) Len() int { return len(p) } func (p sortType) Len() int { return len(p) }
func (p sortTypeDoc) Swap(i, j int) { p[i], p[j] = p[j], p[i] } func (p sortType) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
func (p sortTypeDoc) Less(i, j int) bool { func (p sortType) Less(i, j int) bool {
// sort by name // sort by name
// pull blocks (name = "") up to top // pull blocks (name = "") up to top
// in original order // in original order
@ -453,14 +472,14 @@ func (p sortTypeDoc) Less(i, j int) bool {
// NOTE(rsc): This would appear not to be correct for type ( ) // NOTE(rsc): This would appear not to be correct for type ( )
// blocks, but the doc extractor above has split them into // blocks, but the doc extractor above has split them into
// individual declarations. // individual declarations.
func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc { func (doc *docReader) makeTypes(m map[string]*typeInfo) []*Type {
// TODO(gri) Consider computing the embedded method information // TODO(gri) Consider computing the embedded method information
// before calling makeTypeDocs. Then this function can // before calling makeTypes. Then this function can
// be single-phased again. Also, it might simplify some // be single-phased again. Also, it might simplify some
// of the logic. // of the logic.
// //
// phase 1: associate collected declarations with TypeDocs // phase 1: associate collected declarations with Types
list := make([]*TypeDoc, len(m)) list := make([]*Type, len(m))
i := 0 i := 0
for _, old := range m { for _, old := range m {
// old typeInfos may not have a declaration associated with them // old typeInfos may not have a declaration associated with them
@ -469,7 +488,7 @@ func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc {
if decl := old.decl; decl != nil || !old.exported() { if decl := old.decl; decl != nil || !old.exported() {
// process the type even if not exported so that we have // process the type even if not exported so that we have
// its methods in case they are embedded somewhere // its methods in case they are embedded somewhere
t := new(TypeDoc) t := new(Type)
if decl != nil { if decl != nil {
typespec := decl.Specs[0].(*ast.TypeSpec) typespec := decl.Specs[0].(*ast.TypeSpec)
doc := typespec.Doc doc := typespec.Doc
@ -482,10 +501,10 @@ func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc {
t.Doc = doc.Text() t.Doc = doc.Text()
t.Type = typespec t.Type = typespec
} }
t.Consts = makeValueDocs(old.values, token.CONST) t.Consts = makeValues(old.values, token.CONST)
t.Vars = makeValueDocs(old.values, token.VAR) t.Vars = makeValues(old.values, token.VAR)
t.Factories = makeFuncDocs(old.factories) t.Funcs = makeFuncs(old.factories)
t.methods = makeFuncDocs(old.methods) t.methods = makeFuncs(old.methods)
// The list of embedded types' methods is computed from the list // The list of embedded types' methods is computed from the list
// of embedded types, some of which may not have been processed // of embedded types, some of which may not have been processed
// yet (i.e., their forward link is nil) - do this in a 2nd phase. // yet (i.e., their forward link is nil) - do this in a 2nd phase.
@ -496,7 +515,7 @@ func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc {
old.forward = t // old has been processed old.forward = t // old has been processed
// only add the type to the final type list if it // only add the type to the final type list if it
// is exported or if we want to see all types // is exported or if we want to see all types
if old.exported() || !doc.exportsOnly { if old.exported() || doc.mode&AllDecls != 0 {
list[i] = t list[i] = t
i++ i++
} }
@ -540,7 +559,7 @@ func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc {
} }
} }
// phase 3: compute final method set for each TypeDoc // phase 3: compute final method set for each Type
for _, d := range list { for _, d := range list {
if len(d.embedded) > 0 { if len(d.embedded) > 0 {
// there are embedded methods - exclude // there are embedded methods - exclude
@ -557,12 +576,15 @@ func (doc *docReader) makeTypeDocs(m map[string]*typeInfo) []*TypeDoc {
} }
d.Methods = mset.sortedList() d.Methods = mset.sortedList()
} else { } else {
// no embedded methods // no embedded methods - convert into a Method list
d.Methods = d.methods d.Methods = make([]*Method, len(d.methods))
for i, m := range d.methods {
d.Methods[i] = &Method{Func: m}
}
} }
} }
sort.Sort(sortTypeDoc(list)) sort.Sort(sortType(list))
return list return list
} }
@ -589,7 +611,7 @@ func collectEmbeddedMethods(mset methodSet, info *typeInfo, recvTypeName string,
} }
} }
func customizeRecv(m *FuncDoc, embeddedIsPtr bool, recvTypeName string) *FuncDoc { func customizeRecv(m *Func, embeddedIsPtr bool, recvTypeName string) *Func {
if m == nil || m.Decl == nil || m.Decl.Recv == nil || len(m.Decl.Recv.List) != 1 { if m == nil || m.Decl == nil || m.Decl.Recv == nil || len(m.Decl.Recv.List) != 1 {
return m // shouldn't happen, but be safe return m // shouldn't happen, but be safe
} }
@ -619,7 +641,7 @@ func customizeRecv(m *FuncDoc, embeddedIsPtr bool, recvTypeName string) *FuncDoc
return &newM return &newM
} }
func makeBugDocs(list []*ast.CommentGroup) []string { func makeBugs(list []*ast.CommentGroup) []string {
d := make([]string, len(list)) d := make([]string, len(list))
for i, g := range list { for i, g := range list {
d[i] = g.Text() d[i] = g.Text()
@ -629,20 +651,20 @@ func makeBugDocs(list []*ast.CommentGroup) []string {
// newDoc returns the accumulated documentation for the package. // newDoc returns the accumulated documentation for the package.
// //
func (doc *docReader) newDoc(importpath string, filenames []string) *PackageDoc { func (doc *docReader) newDoc(importpath string, filenames []string) *Package {
p := new(PackageDoc) p := new(Package)
p.PackageName = doc.pkgName p.Name = doc.pkgName
p.ImportPath = importpath p.ImportPath = importpath
sort.Strings(filenames) sort.Strings(filenames)
p.Filenames = filenames p.Filenames = filenames
p.Doc = doc.doc.Text() p.Doc = doc.doc.Text()
// makeTypeDocs may extend the list of doc.values and // makeTypes may extend the list of doc.values and
// doc.funcs and thus must be called before any other // doc.funcs and thus must be called before any other
// function consuming those lists // function consuming those lists
p.Types = doc.makeTypeDocs(doc.types) p.Types = doc.makeTypes(doc.types)
p.Consts = makeValueDocs(doc.values, token.CONST) p.Consts = makeValues(doc.values, token.CONST)
p.Vars = makeValueDocs(doc.values, token.VAR) p.Vars = makeValues(doc.values, token.VAR)
p.Funcs = makeFuncDocs(doc.funcs) p.Funcs = makeFuncs(doc.funcs)
p.Bugs = makeBugDocs(doc.bugs) p.Bugs = makeBugs(doc.bugs)
return p return p
} }