qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 21:01:31 -07:00
Code Releases Activity

net/http,doc: use HTTP status code constants where applicable

Browse Source 
There are a few places where the integer value is used.
Use the equivalent constants to aid with readability.

Change-Id: I023b1dbe605340544c056d0e0d9d6d5a7d7d0edc
GitHub-Last-Rev: c1c90bcd25
GitHub-Pull-Request: golang/go#24123
Reviewed-on: https://go-review.googlesource.com/96984
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This commit is contained in:
unknown 2018-02-26 04:41:20 +00:00 committed by Andrew Bonventre
parent 39852bf4cc
commit e9c57bea11
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/progs/error2.go
View File

@ -20,11 +20,11 @@ func viewRecord(w http.ResponseWriter, r *http.Request) {
key := datastore.NewKey(c, "Record", r.FormValue("id"), 0, nil) key := datastore.NewKey(c, "Record", r.FormValue("id"), 0, nil)
record := new(Record) record := new(Record)
if err := datastore.Get(c, key, record); err != nil { if err := datastore.Get(c, key, record); err != nil {
http.Error(w, err.Error(), 500) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }
if err := viewTemplate.Execute(w, record); err != nil { if err := viewTemplate.Execute(w, record); err != nil {
http.Error(w, err.Error(), 500) http.Error(w, err.Error(), http.StatusInternalServerError)
} }
} }

2
doc/progs/error3.go
View File

@ -33,7 +33,7 @@ type appHandler func(http.ResponseWriter, *http.Request) error
func (fn appHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (fn appHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
if err := fn(w, r); err != nil { if err := fn(w, r); err != nil {
http.Error(w, err.Error(), 500) http.Error(w, err.Error(), http.StatusInternalServerError)
} }
} }

4
src/net/http/triv.go
View File

@ -107,7 +107,7 @@ func DateServer(rw http.ResponseWriter, req *http.Request) {
date, err := exec.Command("/bin/date").Output() date, err := exec.Command("/bin/date").Output()
if err != nil { if err != nil {
http.Error(rw, err.Error(), 500) http.Error(rw, err.Error(), http.StatusInternalServerError)
return return
} }
rw.Write(date) rw.Write(date)
@ -115,7 +115,7 @@ func DateServer(rw http.ResponseWriter, req *http.Request) {
func Logger(w http.ResponseWriter, req *http.Request) { func Logger(w http.ResponseWriter, req *http.Request) {
log.Print(req.URL) log.Print(req.URL)
http.Error(w, "oops", 404) http.Error(w, "oops", http.StatusNotFound)
} }
var webroot = flag.String("root", os.Getenv("HOME"), "web root directory") var webroot = flag.String("root", os.Getenv("HOME"), "web root directory")