qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 21:34:46 -07:00
Code Releases Activity

cmd/link: disable DWARF by default in c-shared mode on darwin

Browse Source 
Currently, linking a Go c-shared object with C code using Apple's
new linker, it fails with

% cc a.c go.so
ld: segment '__DWARF' filesize exceeds vmsize in 'go.so'

Apple's new linker has more checks for unmapped segments. It is
very hard to make it accept a Mach-O shared object with an
additional DWARF segment.

We may want to stop combinding DWARF into the shared object (see
also #62577). For now, disable DWARF by default in c-shared mode
on darwin. (One can still enable it with -ldflags=-w=0, which will
contain DWARF, but it will need the old C linker to link against
with.)

For #61229.

Change-Id: I4cc77da54fac10e2c2cbcffa92779cba82706d75
Reviewed-on: https://go-review.googlesource.com/c/go/+/527415
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Cherry Mui 2023-09-11 15:53:49 -04:00
parent 905b58b537
commit e924ea03cc
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/link/internal/ld/main.go
View File

@ -245,6 +245,9 @@ func Main(arch *sys.Arch, theArch Arch) {
*FlagW = true *FlagW = true
case ternaryFlagUnset: case ternaryFlagUnset:
*FlagW = *FlagS // -s implies -w if not explicitly set *FlagW = *FlagS // -s implies -w if not explicitly set
if ctxt.IsDarwin() && ctxt.BuildMode == BuildModeCShared {
*FlagW = true // default to -w in c-shared mode on darwin, see #61229
}
} }
if !buildcfg.Experiment.RegabiWrappers { if !buildcfg.Experiment.RegabiWrappers {