From e8fe3b77574d9afadab664104a669d8e9f0f4303 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 12 Apr 2023 21:42:29 +0000 Subject: [PATCH] cmd/go: skip TestScript/list_goroot_symlink on darwin The list_goroot_symlink test relies on fsys.Walk (and ultimately syscall.Lstat) conforming to POSIX pathname resolution semantics. POSIX requires that symlinks ending in a slash be fully resolved, but it appears that lstat in current darwin kernels does not fully resolve the last pathname component when it is a symlink to a symlink. For #59586. For #35678. Change-Id: I37526f012ba94fa1796b33109a41c3226c967d3e Reviewed-on: https://go-review.googlesource.com/c/go/+/484216 Run-TryBot: Bryan Mills Reviewed-by: Michael Pratt Auto-Submit: Bryan Mills TryBot-Bypass: Bryan Mills --- src/cmd/go/testdata/script/list_goroot_symlink.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/testdata/script/list_goroot_symlink.txt b/src/cmd/go/testdata/script/list_goroot_symlink.txt index 40c99430659..1a34127eb9c 100644 --- a/src/cmd/go/testdata/script/list_goroot_symlink.txt +++ b/src/cmd/go/testdata/script/list_goroot_symlink.txt @@ -6,6 +6,7 @@ [short] skip 'copies the cmd/go binary' [!symlink] skip 'tests symlink-specific behavior' +[GOOS:darwin] skip 'Lstat on darwin does not conform to POSIX pathname resolution; see #59586' # Ensure that the relative path to $WORK/lib/goroot/src from $PWD is a different # number of ".." hops than the relative path to it from $WORK/share/goroot/src.