qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 16:14:28 -06:00
Code Releases Activity

net/http: correctly test for leading header spaces in TestReadRequest_Bad

Browse Source 
TestReadRequest_Bad's tests for leading whitespace in the first header
were also exercising the test verifying that a HEAD request has no
Content-Length. Also, the test intended to test a leading tab was
actually testing for a leading \t (literal backslash, literal t).

Change-Id: I05b46d05851b49bf75f1d1257c421b953b66ea9c
Reviewed-on: https://go-review.googlesource.com/c/go/+/428134
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Damien Neil 2022-09-02 14:48:28 -07:00
parent d8e6ed3262
commit e7312b1005
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/net/http/readrequest_test.go
View File

@ -455,12 +455,10 @@ Host: foo
Content-Length: 5`)},
// golang.org/issue/22464
{"leading_space_in_header", reqBytes(`HEAD / HTTP/1.1
Host: foo
Content-Length: 5`)},
{"leading_tab_in_header", reqBytes(`HEAD / HTTP/1.1
\tHost: foo
Content-Length: 5`)},
{"leading_space_in_header", reqBytes(`GET / HTTP/1.1
Host: foo`)},
{"leading_tab_in_header", reqBytes(`GET / HTTP/1.1
` + "\t" + `Host: foo`)},
}
func TestReadRequest_Bad(t *testing.T) {