qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 15:24:28 -06:00
Code Releases Activity

regexp: simplify BenchmarkCompileOnepass

Browse Source 
One benchmark is fine.
Having one per test case is overkill.

Change-Id: Id4ce789484dab1e79026bdd23cbcd63b2eaceb3f
Reviewed-on: https://go-review.googlesource.com/c/139777
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Russ Cox 2018-10-03 20:28:47 -04:00
parent 689321e108
commit e2d70b8b4b
1 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/regexp/onepass_test.go
View File

@ -227,21 +227,11 @@ func TestRunOnePass(t *testing.T) {
}
func BenchmarkCompileOnepass(b *testing.B) {
for _, test := range onePassTests {
if test.onePass == notOnePass {
continue
b.ReportAllocs()
const re = `^a.[l-nA-Cg-j]?e$`
for i := 0; i < b.N; i++ {
if _, err := Compile(re); err != nil {
b.Fatal(err)
}
name := test.re
if len(name) > 20 {
name = name[:20] + "..."
}
b.Run(name, func(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
if _, err := Compile(test.re); err != nil {
b.Fatal(err)
}
}
})
}
}