qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-12 01:00:22 -07:00
Code Releases Activity

cmd/go: deflake TestScript/gcflags_patterns

Browse Source 
The check below can fail incorrectly if the buildid ends with '-p'.

    ! stderr 'compile.* -e .*-p [^z]'

This fix changes regular expressions to '-e.* -p' or '-N.* -p' instead
of '-e .*-p'. '-l' is no longer used because the compiler accepts
multiple flags starting with '-l' ('-e' and '-N' do not have this
problem), so there could be false matches.

Change-Id: I827c411de28624019a287f853acc9666e87cbfb9
Reviewed-on: https://go-review.googlesource.com/c/156327
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Jay Conrod 2019-01-04 17:30:36 -05:00
parent 73fb3c38a6
commit e1b903788a
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/cmd/go/testdata/script/gcflags_patterns.txt vendored
View File

@ -2,28 +2,28 @@
# -gcflags=-e applies to named packages, not dependencies
go build -n -v -gcflags=-e z1 z2
stderr 'compile.* -e .*-p z1'
stderr 'compile.* -e .*-p z2'
stderr 'compile.* -e.* -p z1'
stderr 'compile.* -e.* -p z2'
stderr 'compile.* -p y'
! stderr 'compile.* -e .*-p [^z]'
! stderr 'compile.* -e.* -p [^z]'
# -gcflags can specify package=flags, and can be repeated; last match wins
go build -n -v -gcflags=-e -gcflags=z1=-N z1 z2
stderr 'compile.* -N .*-p z1'
! stderr 'compile.* -e .*-p z1'
! stderr 'compile.* -N .*-p z2'
stderr 'compile.* -e .*-p z2'
stderr 'compile.* -N.* -p z1'
! stderr 'compile.* -e.* -p z1'
! stderr 'compile.* -N.* -p z2'
stderr 'compile.* -e.* -p z2'
stderr 'compile.* -p y'
! stderr 'compile.* -e .*-p [^z]'
! stderr 'compile.* -N .*-p [^z]'
! stderr 'compile.* -e.* -p [^z]'
! stderr 'compile.* -N.* -p [^z]'
# -gcflags can have arbitrary spaces around the flags
go build -n -v -gcflags=' z1 = -e ' z1
stderr 'compile.* -e .*-p z1'
stderr 'compile.* -e.* -p z1'
# -gcflags='all=-N -l' should apply to all packages, even with go test
go test -c -n -gcflags='all=-N -l' z1
stderr 'compile.* -N -l .*-p z3 '
# -gcflags='all=-e' should apply to all packages, even with go test
go test -c -n -gcflags='all=-e' z1
stderr 'compile.* -e.* -p z3 '
# -ldflags for implicit test package applies to test binary
go test -c -n -gcflags=-N -ldflags=-X=x.y=z z1