From e14c4e4dfe1023df83339da73eb5dd632d52851b Mon Sep 17 00:00:00 2001 From: Alfonso Subiotto Marques Date: Mon, 3 Jun 2024 13:21:39 +0200 Subject: [PATCH] runtime: remove linkname from memhash{32,64} functions github.com/parquet-go/parquet-go was listed as the only user of these functions. https://github.com/parquet-go/parquet-go/pull/142 removes the linkname dependency on these functions, so the linkname directive can now be removed. --- src/runtime/alg.go | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/runtime/alg.go b/src/runtime/alg.go index 98b93f5565..43bbe5a0de 100644 --- a/src/runtime/alg.go +++ b/src/runtime/alg.go @@ -56,7 +56,6 @@ var useAeshash bool // - github.com/outcaste-io/ristretto // - github.com/puzpuzpuz/xsync/v2 // - github.com/puzpuzpuz/xsync/v3 -// - github.com/parquet-go/parquet-go // - github.com/authzed/spicedb // - github.com/pingcap/badger // @@ -66,26 +65,8 @@ var useAeshash bool //go:linkname memhash func memhash(p unsafe.Pointer, h, s uintptr) uintptr -// memhash32 should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/parquet-go/parquet-go -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname memhash32 func memhash32(p unsafe.Pointer, h uintptr) uintptr -// memhash64 should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/parquet-go/parquet-go -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. -// -//go:linkname memhash64 func memhash64(p unsafe.Pointer, h uintptr) uintptr // strhash should be an internal detail,